github-actions[bot] commented on code in PR #34145:
URL: https://github.com/apache/doris/pull/34145#discussion_r1580730664
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -313,12 +313,31 @@ class RuntimeFilterDependency final : public Dependency {
const IRuntimeFilter* _runtime_filter = nullptr;
};
+struct AggMemData {
+ AggMemData() {
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```cpp
AggMemData() {
^
```
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -579,14 +613,27 @@
bool probe_ignore_null = false;
};
+struct HashJoinMemData {
+ std::vector<std::unique_ptr<vectorized::MutableBlock>>
partitioned_build_blocks;
+ ~HashJoinMemData() {
+ //
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(_scanner->runtime_state()->query_mem_tracker());
+ std::vector<std::unique_ptr<vectorized::MutableBlock>>
{}.swap(partitioned_build_blocks);
+ }
+};
struct PartitionedHashJoinSharedState
: public HashJoinSharedState,
public std::enable_shared_from_this<PartitionedHashJoinSharedState> {
ENABLE_FACTORY_CREATOR(PartitionedHashJoinSharedState)
+ PartitionedHashJoinSharedState()
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
be/src/pipeline/pipeline_x/dependency.h:629:
```diff
- partitioned_build_blocks(mem_data->partitioned_build_blocks)
{}
+ partitioned_build_blocks(mem_data->partitioned_build_blocks)
= default;
```
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -313,12 +313,31 @@
const IRuntimeFilter* _runtime_filter = nullptr;
};
+struct AggMemData {
+ AggMemData() {
+ agg_data = std::make_unique<vectorized::AggregatedDataVariants>();
+ agg_arena_pool = std::make_unique<vectorized::Arena>();
+ }
+ ~AggMemData() {
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
~AggMemData() {
^
```
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -579,14 +613,27 @@
bool probe_ignore_null = false;
};
+struct HashJoinMemData {
+ std::vector<std::unique_ptr<vectorized::MutableBlock>>
partitioned_build_blocks;
+ ~HashJoinMemData() {
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
~HashJoinMemData() {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
