github-actions[bot] commented on code in PR #34145:
URL: https://github.com/apache/doris/pull/34145#discussion_r1582008487
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -579,14 +605,27 @@ struct HashJoinSharedState : public JoinSharedState {
bool probe_ignore_null = false;
};
+struct HashJoinMemData {
+ std::vector<std::unique_ptr<vectorized::MutableBlock>>
partitioned_build_blocks;
+ ~HashJoinMemData() {
+ //
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(_scanner->runtime_state()->query_mem_tracker());
+ std::vector<std::unique_ptr<vectorized::MutableBlock>>
{}.swap(partitioned_build_blocks);
+ }
+};
struct PartitionedHashJoinSharedState
: public HashJoinSharedState,
public std::enable_shared_from_this<PartitionedHashJoinSharedState> {
ENABLE_FACTORY_CREATOR(PartitionedHashJoinSharedState)
+ PartitionedHashJoinSharedState()
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
be/src/pipeline/pipeline_x/dependency.h:621:
```diff
- partitioned_build_blocks(mem_data->partitioned_build_blocks)
{}
+ partitioned_build_blocks(mem_data->partitioned_build_blocks)
= default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
