Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba merged PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

DongLiang-0 commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1694629859 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java: ## @@ -19,31 +19,34 @@ import org.apache.flink.annota

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1694430255 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java: ## @@ -19,31 +19,34 @@ import org.apache.flink.annotation

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

DongLiang-0 commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692814612 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumChangeContext.java: ## @@ -82,8 +84,9 @@

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

DongLiang-0 commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692847436 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java: ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692791210 ## flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/DorisTableConfigTest.java: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692788465 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -110,10 +109,6 @@ public void create() { this.exc

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692784532 ## flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSchemaFactory.java: ## @@ -55,14 +54,10 @@ public static TableSchema creat

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692779894 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java: ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foun

Re: [PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

JNSimba commented on code in PR #449: URL: https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692777906 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumChangeContext.java: ## @@ -82,8 +84,9 @@ publ

[PR] [improve]Improve the hardcode of tableConfig [doris-flink-connector]

DongLiang-0 opened a new pull request, #449: URL: https://github.com/apache/doris-flink-connector/pull/449 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original