JNSimba commented on code in PR #449:
URL:
https://github.com/apache/doris-flink-connector/pull/449#discussion_r1694430255
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java:
##########
@@ -19,31 +19,34 @@
import org.apache.flink.annotation.VisibleForTesting;
-import org.apache.commons.collections.MapUtils;
-
import java.io.Serializable;
+import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.Objects;
public class DorisTableConfig implements Serializable {
private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change";
// PROPERTIES parameter in doris table creation statement. such as:
replication_num=1.
- private final Map<String, String> tableProperties;
+ private Map<String, String> tableProperties;
// The specific parameters extracted from --table-conf need to be parsed
and integrated into the
// doris table creation statement. such as:
table-buckets="tbl1:10,tbl2:20,a.*:30,b.*:40,.*:50".
private Map<String, Integer> tableBuckets;
+ public DorisTableConfig() {}
+
Review Comment:
This constructor will cause tableProperties and tableBuckets to be null,
maybe giving an empty map would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
