JNSimba commented on code in PR #449:
URL:
https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692784532
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSchemaFactory.java:
##########
@@ -55,14 +54,10 @@ public static TableSchema createTableSchema(
tableSchema.setKeys(buildKeys(pkKeys, columnFields));
tableSchema.setTableComment(tableComment);
tableSchema.setDistributeKeys(buildDistributeKeys(pkKeys,
columnFields));
- tableSchema.setProperties(tableProperties);
- if (tableProperties.containsKey("table-buckets")) {
- if (MapUtils.isEmpty(tableBucketMap)) {
- String tableBucketsConfig =
tableProperties.get("table-buckets");
- tableBucketMap = buildTableBucketMap(tableBucketsConfig);
- }
- Integer buckets = parseTableSchemaBuckets(tableBucketMap, table);
- tableSchema.setTableBuckets(buckets);
+ if (Objects.nonNull(dorisTableConfig)) {
Review Comment:
The logic here seems different? If dorisTableConfig is not empty, it does
not necessarily mean that tableBuckets is not empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
