Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-22 Thread via GitHub
vishesh92 commented on code in PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2224377680 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -2547,11 +2547,23 @@ protected void setQuotaAndPe

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
rohityadavcloud commented on PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#issuecomment-3078865790 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
rohityadavcloud closed pull request #11213: kvm: implement Hyper-V enlightnements correctly URL: https://github.com/apache/cloudstack/pull/11213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
rohityadavcloud commented on PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#issuecomment-3078129275 @vishesh92 @weizhouapache this doesn't address the console performance like I originally thought, should I keep it open or close this? cc @DaanHoogland -- This is an autom

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
DaanHoogland commented on code in PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209734804 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java: ## @@ -379,10 +390,13 @@ public String toString() {

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
rohityadavcloud commented on code in PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209531725 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java: ## @@ -379,10 +390,13 @@ public String toString() {

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
DaanHoogland commented on code in PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209485409 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java: ## @@ -379,10 +390,13 @@ public String toString() {

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-16 Thread via GitHub
DaanHoogland commented on code in PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209485409 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java: ## @@ -379,10 +390,13 @@ public String toString() {

Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]

2025-07-15 Thread via GitHub
codecov[bot] commented on PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#issuecomment-3077098177 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme