rohityadavcloud commented on code in PR #11213:
URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209531725
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -379,10 +390,13 @@ public String toString() {
feaBuilder.append("<");
feaBuilder.append(e.getKey());
- if(e.getKey().equals("spinlocks")) feaBuilder.append("
state='" + e.getValue() + "' retries='" + getRetries() + "'");
- else feaBuilder.append("
state='" + e.getValue() + "'");
+ if (e.getKey().equals("spinlocks")) feaBuilder.append("
state='" + e.getValue() + "' retries='" + getRetries() + "'");
+ else if (e.getKey().equals("vendor_id")) feaBuilder.append("
state='" + e.getValue() + "' value='KVM Hv'");
+ else if (e.getKey().equals("stimer")) feaBuilder.append("
state='" + e.getValue() + "'><direct state='" + e.getValue() + "'/>");
+ else feaBuilder.append("
state='" + e.getValue() + "'");
- feaBuilder.append("/>\n");
+ if (e.getKey().equals("stimer"))
feaBuilder.append("</stimer>\n");
+ else feaBuilder.append("/>\n");
Review Comment:
Agree - in fact the whole class could use refactoring. For my purpose,
unfortunately these changes made no visible impact on console performance
https://github.com/apache/cloudstack/issues/10650#issuecomment-3077325236
I won't have time to refactor this today or later, but you and others are
welcome to collaborate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
