DaanHoogland commented on code in PR #11213:
URL: https://github.com/apache/cloudstack/pull/11213#discussion_r2209734804
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -379,10 +390,13 @@ public String toString() {
feaBuilder.append("<");
feaBuilder.append(e.getKey());
- if(e.getKey().equals("spinlocks")) feaBuilder.append("
state='" + e.getValue() + "' retries='" + getRetries() + "'");
- else feaBuilder.append("
state='" + e.getValue() + "'");
+ if (e.getKey().equals("spinlocks")) feaBuilder.append("
state='" + e.getValue() + "' retries='" + getRetries() + "'");
+ else if (e.getKey().equals("vendor_id")) feaBuilder.append("
state='" + e.getValue() + "' value='KVM Hv'");
+ else if (e.getKey().equals("stimer")) feaBuilder.append("
state='" + e.getValue() + "'><direct state='" + e.getValue() + "'/>");
+ else feaBuilder.append("
state='" + e.getValue() + "'");
- feaBuilder.append("/>\n");
+ if (e.getKey().equals("stimer"))
feaBuilder.append("</stimer>\n");
+ else feaBuilder.append("/>\n");
Review Comment:
if these have no results we can merge them on recomendation of redhat, but
further effort along this line seems mute to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
