Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-28 Thread via GitHub
DaanHoogland merged PR #7081: URL: https://github.com/apache/cloudstack/pull/7081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-12 Thread via GitHub
winterhazel commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2470904693 > @RodrigoDLopez @winterhazel , are you guys testing this? @DaanHoogland I already tested it in https://github.com/apache/cloudstack/pull/7081#issuecomment-2450828651, and c

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-12 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2470805809 @RodrigoDLopez @winterhazel , are you guys testing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2458140644 [SF] Trillian test result (tid-11741) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46174 seconds Marvin logs: https://github.com/

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-04 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2456426815 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-04 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2456427843 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-04 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2454285388 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-04 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2454159352 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-04 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2454157825 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2452846313 [SF] Trillian test result (tid-11732) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56878 seconds Marvin logs: https://github.com/

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451965817 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
winterhazel commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451880341 > > Hi @RodrigoDLopez It seems the issue #7483 is fixed with this PR. Can target this PR for 4.19.1? > > @winterhazel , will you considder this? My bad, I missed this

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451733027 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451734899 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451620874 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451511398 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451508761 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-01 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2451508577 > Everything seems to be working as intended now. Below are the tests I did. @weizhouapache , does this cover your concerns? > Hi @RodrigoDLopez It seems the issue #74

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-31 Thread via GitHub
winterhazel commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2450828651 Everything seems to be working as intended now. Below are the tests I did. ## Tests For each test, I created/updated/deleted port forwarding rules via the UI, and veri

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-31 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2450717673 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-31 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2450613735 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-31 Thread via GitHub
winterhazel commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2450611723 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-22 Thread via GitHub
weizhouapache commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r181096 ## systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py: ## @@ -339,6 +339,9 @@ def to_str(self, delete=False): printable = printable.replace('!_-'

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-22 Thread via GitHub
winterhazel commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811012616 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java: ## @@ -107,8 +108,13 @@ public class CreatePortForwardingR

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-22 Thread via GitHub
winterhazel commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811012616 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java: ## @@ -107,8 +108,13 @@ public class CreatePortForwardingR

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-22 Thread via GitHub
winterhazel commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811010176 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java: ## @@ -107,8 +108,13 @@ public class CreatePortForwardingR

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-10-22 Thread via GitHub
winterhazel commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811007783 ## systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py: ## @@ -339,6 +339,9 @@ def to_str(self, delete=False): printable = printable.replace('!_-',

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-06-06 Thread via GitHub
weizhouapache commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1629623888 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java: ## @@ -107,8 +108,13 @@ public class CreatePortForwardin

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-06-06 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2152249484 @RodrigoDLopez can you look at the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-03-12 Thread via GitHub
sureshanaparti commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-1991268859 Hi @RodrigoDLopez It seems the issue #7483 is fixed with this PR. Can target this PR for 4.19.1? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2023-11-15 Thread via GitHub
DaanHoogland commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-1812676241 ping @RodrigoDLopez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c