weizhouapache commented on code in PR #7081:
URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1629623888
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java:
##########
@@ -107,8 +108,13 @@ public class CreatePortForwardingRuleCmd extends
BaseAsyncCreateCmd implements P
description = "the ID of the virtual machine for the port
forwarding rule")
private Long virtualMachineId;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,). This parameter is deprecated. Do not use.")
- private List<String> cidrlist;
+ @Parameter(name = ApiConstants.CIDR_LIST,
Review Comment:
I suggest we use SOURCE_CIDR_LIST
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java:
##########
@@ -107,8 +108,13 @@ public class CreatePortForwardingRuleCmd extends
BaseAsyncCreateCmd implements P
description = "the ID of the virtual machine for the port
forwarding rule")
private Long virtualMachineId;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,). This parameter is deprecated. Do not use.")
- private List<String> cidrlist;
+ @Parameter(name = ApiConstants.CIDR_LIST,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "the CIDR list to allow traffic, all other CIDRs
will be blocked. " +
+ "Multiple entries must be separated by a single comma
character (,). This param will be used only for VPC's networks. By default, all
CIDRs are allowed.")
Review Comment:
I remember there are some changes for source cidr of load balancing rules.
Does it work in isolated networks? If yes, this could be extended to support
isolated networks as well.
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java:
##########
@@ -107,8 +108,13 @@ public class CreatePortForwardingRuleCmd extends
BaseAsyncCreateCmd implements P
description = "the ID of the virtual machine for the port
forwarding rule")
private Long virtualMachineId;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,). This parameter is deprecated. Do not use.")
- private List<String> cidrlist;
+ @Parameter(name = ApiConstants.CIDR_LIST,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "the CIDR list to allow traffic, all other CIDRs
will be blocked. " +
+ "Multiple entries must be separated by a single comma
character (,). This param will be used only for VPC's networks. By default, all
CIDRs are allowed.")
+ private List<String> cidrList;
Review Comment:
Also sourceCidrList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
