winterhazel commented on code in PR #7081:
URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1811010176
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java:
##########
@@ -107,8 +108,13 @@ public class CreatePortForwardingRuleCmd extends
BaseAsyncCreateCmd implements P
description = "the ID of the virtual machine for the port
forwarding rule")
private Long virtualMachineId;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,). This parameter is deprecated. Do not use.")
- private List<String> cidrlist;
+ @Parameter(name = ApiConstants.CIDR_LIST,
Review Comment:
I'm keeping the param as `cidrlist` for now so that it matches the
`createLoadBalancerRule` API and so that we don't add another parameter or
change an existing param's name while we don't have a well-defined protocol to
introduce breaking changes. However, I'll address it as "source CIDR list" in
the UI and change its description to provide a better idea on what the
parameter represents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
