Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-19 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2668494398 [SF] Trillian test result (tid-12467) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 74470 seconds Marvin logs: https://github.com/

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-19 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2668035097 [SF] Trillian test result (tid-12466) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63561 seconds Marvin logs: https://github.

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-19 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2667879069 [SF] Trillian test result (tid-12464) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 59355 seconds Marvin logs: https://github.com/

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-18 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2667692883 [SF] Trillian test result (tid-12465) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 55625 seconds Marvin logs: https://github

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-18 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2665983866 @Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tes

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-18 Thread via GitHub
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2665981478 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-15 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2660946876 [SF] Trillian Build Failed (tid-12427) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-15 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2660946037 [SF] Trillian Build Failed (tid-12428) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-15 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2660946035 [SF] Trillian Build Failed (tid-12426) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-15 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2660944468 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-15 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2660944012 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659881770 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659702574 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659700030 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659699832 I've targeted this against 4.20. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659697237 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659653706 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659475276 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2025-02-14 Thread via GitHub
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2659469489 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-26 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2500266123 after a short backtalk with @shwstppr and @weizhouapache , I think we can merge this PR given issue #9975 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-25 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2497691371 well, I'm not against fixing after merging but think we should not release with this change and then try to fix in a next release. -- This is an automated message from the Apac

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-25 Thread via GitHub
shwstppr commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2497676795 @weizhouapache @DaanHoogland cc @BartJM I'm not against with the change as such. I agree that it is just structural change. Maybe we can create an improvement issue for tracking and c

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-25 Thread via GitHub
weizhouapache commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2497665504 > > Not sure if we have been already using the user_vm_details table for storing the details of the system VMs but it doesn't sound right to me . > > @shwstppr , I share yo

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-25 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2497501071 > Not sure if we have been already using the user_vm_details table for storing the details of the system VMs but it doesn't sound right to me . @shwstppr , I share your conc

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-11-23 Thread via GitHub
shwstppr commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2495662440 Not sure if we have been already using the user_vm_details table for storing the details of the system VMs but it doesn't sound right to me . -- This is an automated message from th

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-28 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2380465387 [SF] Trillian test result (tid-11565) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 66133 seconds Marvin logs: https://github.com/

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2379106943 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2379103558 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2379012270 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
BartJM commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2378881962 With the new changes also tested the following on mbx centos8 kvm for user vms. All changes were reflected in the database as expected. * Create a vm with ssh key, * Create passwo

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2378873254 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
BartJM commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1778333910 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-27 Thread via GitHub
DaanHoogland commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2378871432 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-25 Thread via GitHub
DaanHoogland commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1774812867 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsDa

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
BartJM commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1773292202 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
DaanHoogland commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1772967440 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsDa

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370655460 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370449731 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
weizhouapache commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370446634 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-24 Thread via GitHub
weizhouapache commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1772801880 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsD

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
codecov[bot] commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2368431361 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9721?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
DaanHoogland commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1771534949 ## engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java: ## @@ -22,13 +22,45 @@ import org.apache.cloudstack.resourcedetail.ResourceDetailsDa

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
BartJM commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1771526615 ## engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java: ## @@ -331,4 +338,27 @@ public List listByLastHostId(long hostId) { sc.setParameter

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
weizhouapache commented on code in PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1771220015 ## engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java: ## @@ -331,4 +338,27 @@ public List listByLastHostId(long hostId) { sc.setPa

Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
boring-cyborg[bot] commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2367764317 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribut

[PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]

2024-09-23 Thread via GitHub
BartJM opened a new pull request, #9721: URL: https://github.com/apache/cloudstack/pull/9721 ### Description This PR adds saving systemvm template settings to the user_vm_details table. Allows systemvms to start with details specified in the systemvm template settings.