weizhouapache commented on code in PR #9721:
URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1771220015
##########
engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java:
##########
@@ -331,4 +338,27 @@ public List<ConsoleProxyVO> listByLastHostId(long hostId) {
sc.setParameters("state", State.Stopped);
return listBy(sc);
}
+
+ @Override
+ public void saveDetails(ConsoleProxyVO vm) {
+ saveDetails(vm, new ArrayList<String>());
+ }
+
+ @Override
+ public void saveDetails(ConsoleProxyVO vm, List<String> hiddenDetails) {
Review Comment:
you can define a method in UserVmDetailsDaoImpl
```
public void saveDetails(VMInstanceVO vm) {
public void saveDetails(VMInstanceVO vm, List<String> hiddenDetails) {
```
##########
engine/schema/src/main/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java:
##########
@@ -331,4 +338,27 @@ public List<ConsoleProxyVO> listByLastHostId(long hostId) {
sc.setParameters("state", State.Stopped);
return listBy(sc);
}
+
+ @Override
+ public void saveDetails(ConsoleProxyVO vm) {
+ saveDetails(vm, new ArrayList<String>());
+ }
+
+ @Override
+ public void saveDetails(ConsoleProxyVO vm, List<String> hiddenDetails) {
Review Comment:
you can define two methods in UserVmDetailsDaoImpl
```
public void saveDetails(VMInstanceVO vm) {
public void saveDetails(VMInstanceVO vm, List<String> hiddenDetails) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
