weizhouapache commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2497665504
> > Not sure if we have been already using the user_vm_details table for storing the details of the system VMs but it doesn't sound right to me . > > @shwstppr , I share your concern but can you expand on your concerns? > > I do agree somewhat and the systems are not user_vms thus their details should maybe be in another table, so an alternative could be creating another details table...? I think we should have a quick discuss about this. or rename the table to `vm_instance_details` for example ? it requires some sql/java changes I think it is a minor issue, we can test/merge this PR and improve it afterwards. what do you think @shwstppr @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org