Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-07-11 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2224801426 > Hey @mlsorensen, @weizhouapache, @rohityadavcloud, @borisstoyanov, @DaanHoogland > > I've pushed the new change, now we keep the VM as linked clone if we are going from/

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-07-11 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2223753975 Hey @mlsorensen, @weizhouapache, @rohityadavcloud, @borisstoyanov, @DaanHoogland I've pushed the new change, now we keep the VM as linked clone if we are going from/to NFS/S

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-07-10 Thread via GitHub
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2219715459 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-07-02 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2194701897 Hey @mlsorensen, @weizhouapache, @rohityadavcloud, @borisstoyanov After reading all your comments, doing more testing and pondering on the question a bit more, you changed my

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-24 Thread via GitHub
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2185788557 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-18 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2175551121 > > > > @JoaoJandre The current behavior has been proved to be working well in most cases. Of course there are some issues, but I think it can be fixed. > > The cur

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-17 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2174334027 > > > > @weizhouapache , I don't think I got your point, could you explain it? > > > > > > > > > @JoaoJandre As you described in the description `Currently, when a volume

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-14 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2168619354 > > > @weizhouapache , I don't think I got your point, could you explain it? > > > > @JoaoJandre As you described in the description `Currently, when a volume that was crea

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-14 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2168571595 > > @weizhouapache , I don't think I got your point, could you explain it? > > @JoaoJandre As you described in the description `Currently, when a volume that was created with

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-14 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2168564907 > @weizhouapache , I don't think I got your point, could you explain it? @JoaoJandre As you described in the description `Currently, when a volume that was created w

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-14 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2168533009 @weizhouapache , I don't think I got your point, could you explain it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165779806 > Hi, @rohityadavcloud , @borisstoyanov , @weizhouapache > > > My 2-cents - we shouldn't break the design; migration to any storage shouldn't break linked-clone VMs. Nor a

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165706362 Hi, @rohityadavcloud , @borisstoyanov , @weizhouapache > My 2-cents - we shouldn't break the design; migration to any storage shouldn't break linked-clone VMs. Nor any templa

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165254429 I agree with @borisstoyanov full clone will not save space, especially there are many vms having the same base image. this is probably why vms are deployed with linked clone,

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
borisstoyanov commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165086428 Thanks @JoaoJandre, I got your point. I'm not sure about the space saving part, but I do believe the default behaviour should remain a proper link clone implementation, further a

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165029016 My 2-cents - we shouldn't break the design; migration to any storage shouldn't break linked-clone VMs. Nor any templates should be allowed to be removed which has any VMs (or V

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162925420 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9898 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162865871 > Hi @JoaoJandre, thanks for this suggestion. > > if we consolidate all link clone created VMs after migration, wouldn't that create a massive overhead in storage as they will

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162807531 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162804829 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162804001 > @JoaoJandre The constructor and `Type` enum of `MigrationOptions`, and `StorageSystemDataMotionStrategy.createLinkedCloneMigrationOptions` are now dead code. > > `StorageSy

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162798451 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2125896959 [SF] Trillian test result (tid-10247) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48880 seconds Marvin logs: https://github.co

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2124200231 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-22 Thread via GitHub
DaanHoogland commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2124196179 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-21 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2122424322 @DaanHoogland @sureshanaparti could we try again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-20 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2120403579 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9640 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-20 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2120286097 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-20 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2120283255 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-18 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2118677701 [SF] Trillian Build Failed (tid-10207) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-18 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2118671848 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-18 Thread via GitHub
DaanHoogland commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2118671602 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-16 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2115814380 @DaanHoogland @sureshanaparti could we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-07 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2097677842 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9557 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-06 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2096122919 Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9547 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-06 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2095984785 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-06 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2095980670 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-05 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2094904869 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9536 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-05 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2094898442 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-05-05 Thread via GitHub
DaanHoogland commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2094897989 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2082309367 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-17 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2062825827 [SF] Trillian test result (tid-9884) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45095 seconds Marvin logs: https://github.com

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-17 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2060977601 [SF] Trillian Build Failed (tid-9873) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-17 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2060632345 [SF] Trillian Build Failed (tid-9870) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-17 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2060567229 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-17 Thread via GitHub
DaanHoogland commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2060565561 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-16 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2059577528 @sureshanaparti could we run de CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056789514 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9262 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056637524 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056636223 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2056202812 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9256 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2055804326 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9252 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2055715933 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-15 Thread via GitHub
sureshanaparti commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2055712829 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-12 Thread via GitHub
codecov-commenter commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2052448953 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8911?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-04-12 Thread via GitHub
JoaoJandre opened a new pull request, #8911: URL: https://github.com/apache/cloudstack/pull/8911 ### Description Currently, when a volume that was created with linked clone is live migrated from an NFS storage to another NFS storage in KVM, it continues to have the template as a back