JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2174334027
> > > > @weizhouapache , I don't think I got your point, could you explain it? > > > > > > > > > @JoaoJandre As you described in the description `Currently, when a volume that was created with linked clone is live migrated from an NFS storage to another NFS storage in KVM, it continues to have the template as a backing file on the destination storage.` > > > If it is correct, please ensure it is not changed. (migration between nfs/local are same I think) > > > > > > @weizhouapache And for what reasons should we keep this behavior? considering that it is the opposite in all other cases? Is there any real reason to do so? > > To me this is an exception that should not exist, CloudStack should have consistent behaviors. > > @JoaoJandre The current behavior has been proved to be working well in most cases. Of course there are some issues, but I think it can be fixed. The current behavior of consolidating the volume has been proved to work well in all cases seen so far, it is already working for: NFS to SMP; SMP to NFS; Local to NFS; NFS to Local, etc. I prefer a solution that is simpler and works on every case rather than a solution that needs +500 LOC and does not work on every case. > You said it will save space, do you have data to prove it? The quote I posted earlier was directly taken from the qemu-img documentation, here's the quote again, but with more context: "Image conversion is also useful to get smaller image when using a growable format such as qcow: the empty sectors are detected and suppressed from the destination image." (see https://qemu-project.gitlab.io/qemu/tools/qemu-img.html). This seems like the best source for this, as its directly from the tool documentation. > My another concern is the migration time, it would be good to test both methods. Has anyone reported relevant differences in migration between Shared Mount Point to NFS and NFS to NFS? We already have both methods in place; they have been tested for quite some time, and consolidating the volume on migration has never been an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
