JoaoJandre opened a new pull request, #8911:
URL: https://github.com/apache/cloudstack/pull/8911

   ### Description
   
   Currently, when a volume that was created with linked clone is live migrated 
from an NFS storage to another NFS storage in KVM, it continues to have the 
template as a backing file on the destination storage. In all other cases, such 
as NFS to SharedMountPoint, the volume is consolidated with its backing file 
during migration.
   
   This special case adds unnecessary complexity to ACS; In most cases, 
performing the migration without consolidating the volume does not 
significantly optimize resource usage. On the other hand, when consolidating 
the volume with its backing file, the hypervisor detects empty sectors and 
removes them from the final volume, therefore, consolidating the volume can 
reduce storage usage.
   
   This PR fixes the problem explained in #7615 and #8834, but without 
corrupting the volume.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   Before applying the changes, a VM was created using linked clone on an NFS 
storage, when migrating it to another NFS storage, the template was copied to 
the destination storage and it continued to be used by the VM as a backing file.
   
   After applying the changes, a new VM was created under the same conditions 
as the old one (except for the template being different), when migrating the VM 
from one NFS storage to another, the VM template was not copied to the new 
storage and the VM volume was consolidated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to