RE: Review Request: Added unit test cases for api/commands

2013-02-11 Thread Animesh Chaturvedi
M > To: Chip Childers; Prasanna Santhanam; Alex Huang; Chiradeep Vittal > Cc: Meghna Kale; Rohit Yadav; cloudstack > Subject: Re: Review Request: Added unit test cases for api/commands > > > --- > This is an automatically

Re: Review Request: Added unit test cases for api/commands

2013-01-08 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review15170 --- Heads up, going to merge api_refactoring soon so you can get started,

Re: Review Request: Added unit test cases for api/commands

2012-12-20 Thread Meghna Kale
> On Dec. 19, 2012, 7:15 p.m., Rohit Yadav wrote: > > Meghna and anyone who would submit patches that affect api layer; I did not > > mean to hint that one has to wait before we would merge api_refactoring to > > master, just that you should submit patches for api_refactoring branch > > itself

Re: Review Request: Added unit test cases for api/commands

2012-12-19 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14730 --- Meghna and anyone who would submit patches that affect api layer; I d

Re: Review Request: Added unit test cases for api/commands

2012-12-19 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14718 --- Meghna, After Rohit merges the api refactoring branch into master, I

Re: Review Request: Added unit test cases for api/commands

2012-12-18 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14712 --- For this review request and the other one, changes to Cmd classes are

Re: Review Request: Added unit test cases for api/commands

2012-12-17 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14634 --- When combined, both patches end up looking good. I'd like someone mo

Re: Review Request: Added unit test cases for api/commands

2012-12-13 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14427 --- The attached patch doesn't apply: git apply ~/Downloads/0001-Review

Re: Review Request: Added unit test cases for api/commands

2012-12-06 Thread Meghna Kale
> On Dec. 5, 2012, 1:57 p.m., mice xia wrote: > > Suppose they should follow the same flavor, so I only took a look at > > AddTrafficTypeCmdTest.java > > 1) indent: should be 4 spaces > > 2) naming: method testCreateSuccess actually tests a failure scenario, and > > testCreateFailure actually t

Re: Review Request: Added unit test cases for api/commands

2012-12-06 Thread Meghna Kale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/ --- (Updated Dec. 6, 2012, 10:25 a.m.) Review request for cloudstack, Chip Childers,

Re: Review Request: Added unit test cases for api/commands

2012-12-05 Thread mice xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14047 --- Suppose they should follow the same flavor, so I only took a look at

Review Request: Added unit test cases for api/commands

2012-12-05 Thread Meghna Kale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/ --- Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vitta