> On Dec. 19, 2012, 7:15 p.m., Rohit Yadav wrote: > > Meghna and anyone who would submit patches that affect api layer; I did not > > mean to hint that one has to wait before we would merge api_refactoring to > > master, just that you should submit patches for api_refactoring branch > > itself, that way not only we avoid merge conflicts but speed up > > refactoring+test-writing work, both of which will eventually end up in > > master. Lastly, pl. fix your editor so your patches don't have evil > > newlines (correct autocrlf), tabs and trailing whitespaces at least. > > > > Regards.
I'll set my editor's formatter as mentioned for trailing whitespaces, tabs and newlines and update the patch. - Meghna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14730 ----------------------------------------------------------- On Dec. 6, 2012, 10:25 a.m., Meghna Kale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8355/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 10:25 a.m.) > > > Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep > Vittal, and Alex Huang. > > > Description > ------- > > Added unit test cases for api/commands > > > Diffs > ----- > > api/src/com/cloud/api/commands/AssignToLoadBalancerRuleCmd.java 2a88e87 > api/src/com/cloud/api/commands/AssignVMCmd.java be28cc0 > api/src/com/cloud/api/commands/AssociateIPAddrCmd.java 7aaa5b5 > api/src/com/cloud/api/commands/AuthorizeSecurityGroupEgressCmd.java a6088d0 > api/src/com/cloud/api/commands/AuthorizeSecurityGroupIngressCmd.java > e8f8b98 > api/src/com/cloud/api/commands/CreateAutoScalePolicyCmd.java 4d93747 > api/src/com/cloud/api/commands/CreateAutoScaleVmGroupCmd.java 83d7607 > api/src/com/cloud/api/commands/CreateAutoScaleVmProfileCmd.java 68c85d0 > api/src/com/cloud/api/commands/CreateConditionCmd.java eafd8a0 > api/test/src/com/cloud/api/commands/test/AddTrafficTypeCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AssignToLoadBalancerRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/AssignVMCmdTest.java PRE-CREATION > api/test/src/com/cloud/api/commands/test/AttachIsoCmdTest.java PRE-CREATION > api/test/src/com/cloud/api/commands/test/AttachVolumeCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupEgressCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupIngressCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CancelMaintenanceCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CancelPrimaryStorageMaintenanceCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateAutoScalePolicyCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmGroupCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmProfileCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateConditionCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateCounterCmdTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8355/diff/ > > > Testing > ------- > > > Thanks, > > Meghna Kale > >
