----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8355/#review14718 -----------------------------------------------------------
Meghna, After Rohit merges the api refactoring branch into master, I'd be willing to take these patch files (which did apply cleanly for me, assuming you do the one under review and then the attachment) and work to get the tests committed. If the refactoring work has helped to make the command classes more easily tested, then I think it won't be all that difficult. On the other hand, if you want to take a crack at getting just the unit tests into reasonable shape AFTER the refactoring branch merge into master, that's fine too. Let's leave this review open until we can get the tests integrated. -chip - Chip Childers On Dec. 6, 2012, 10:25 a.m., Meghna Kale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8355/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 10:25 a.m.) > > > Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep > Vittal, and Alex Huang. > > > Description > ------- > > Added unit test cases for api/commands > > > Diffs > ----- > > api/src/com/cloud/api/commands/AssignToLoadBalancerRuleCmd.java 2a88e87 > api/src/com/cloud/api/commands/AssignVMCmd.java be28cc0 > api/src/com/cloud/api/commands/AssociateIPAddrCmd.java 7aaa5b5 > api/src/com/cloud/api/commands/AuthorizeSecurityGroupEgressCmd.java a6088d0 > api/src/com/cloud/api/commands/AuthorizeSecurityGroupIngressCmd.java > e8f8b98 > api/src/com/cloud/api/commands/CreateAutoScalePolicyCmd.java 4d93747 > api/src/com/cloud/api/commands/CreateAutoScaleVmGroupCmd.java 83d7607 > api/src/com/cloud/api/commands/CreateAutoScaleVmProfileCmd.java 68c85d0 > api/src/com/cloud/api/commands/CreateConditionCmd.java eafd8a0 > api/test/src/com/cloud/api/commands/test/AddTrafficTypeCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AssignToLoadBalancerRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/AssignVMCmdTest.java PRE-CREATION > api/test/src/com/cloud/api/commands/test/AttachIsoCmdTest.java PRE-CREATION > api/test/src/com/cloud/api/commands/test/AttachVolumeCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupEgressCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupIngressCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CancelMaintenanceCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CancelPrimaryStorageMaintenanceCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateAutoScalePolicyCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmGroupCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmProfileCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateConditionCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateCounterCmdTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8355/diff/ > > > Testing > ------- > > > Thanks, > > Meghna Kale > >
