Re: unit tests guidelines...

2013-03-14 Thread Chip Childers
On Tue, Mar 05, 2013 at 05:42:55PM -0800, Alex Huang wrote: > With the discussion in the BVT thread and other evidence from the check-ins, > I think there are some confusion on when to and what to write in a unit test. > > Unit tests are a philosophy thing and I usually stay away from things like

Re: unit tests guidelines...

2013-03-06 Thread Prasanna Santhanam
On Wed, Mar 06, 2013 at 07:12:55AM +0530, Alex Huang wrote: > With the discussion in the BVT thread and other evidence from the > check-ins, I think there are some confusion on when to and what to > write in a unit test. > Not just unit-tests alone, most testing in general. There was an insightfu

Re: unit tests guidelines...

2013-03-06 Thread Wido den Hollander
On 03/06/2013 02:42 AM, Alex Huang wrote: With the discussion in the BVT thread and other evidence from the check-ins, I think there are some confusion on when to and what to write in a unit test. Unit tests are a philosophy thing and I usually stay away from things like that. If you are inte

Re: unit tests guidelines...

2013-03-05 Thread Ahmad Emneina
+1 to fostering guruism. On Tue, Mar 5, 2013 at 5:42 PM, Alex Huang wrote: > With the discussion in the BVT thread and other evidence from the > check-ins, I think there are some confusion on when to and what to write in > a unit test. > > Unit tests are a philosophy thing and I usually stay aw

RE: Unit Tests for LoadBalancer functionality in ASF Master

2013-01-29 Thread Rajesh Battala
> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Tuesday, January 29, 2013 10:35 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Unit Tests for LoadBalancer functionality in ASF Master > > On Tue, Jan 29, 2013 at 11:

Re: Unit Tests for LoadBalancer functionality in ASF Master

2013-01-29 Thread Chip Childers
On Tue, Jan 29, 2013 at 11:20 AM, Rajesh Battala wrote: > Hi All, > > I have almost done with my feature (AWS Style healthchecks for NetScaler). > I have got paused, how to write unit tests for healthchecks. > > Under cloud-server/test I didn't find any tests for LoadBalancer. There are > not un

Re: Unit tests

2012-11-20 Thread Chip Childers
oard, once it is reviewed and committed the >>> structure will be set and all the units already written are in the new >>> structure. >>> >>> Mani >>> >>> -Original Message- >>> From: Alex Huang [mailto:alex.hu...@citrix.com] &g

Re: Unit tests

2012-11-12 Thread Chip Childers
On Fri, Nov 9, 2012 at 3:24 PM, Alex Huang wrote: > > >> -Original Message- >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> Sent: Friday, November 09, 2012 12:19 PM >> To: cloudstack-dev@incubator.apache.org >> Subject: RE: Unit tests >> &g

RE: Unit tests

2012-11-12 Thread Hugo Trippaers
> -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, November 09, 2012 9:19 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > > >> 2 - Do we want to get stricter about what exactly is considered t

RE: Unit tests

2012-11-12 Thread Hugo Trippaers
> -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, November 09, 2012 10:34 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Unit tests > > On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang wrote: > > +1 the more tests

Re: Unit tests

2012-11-11 Thread Satoshi Kobayashi
x.hu...@citrix.com] > Sent: Friday, November 09, 2012 12:24 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > > >> -Original Message- >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> Sent: Friday, November 09, 2012 12:19 PM >>

Re: Unit tests

2012-11-10 Thread prasanna
On 10 November 2012 03:03, David Nalley wrote: > On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang wrote: >> +1 the more tests the merrier. >> >> I have noticed that in master doing mvn install actually runs some unit >> tests. I don't like that because it slows down compilation. I haven't >> track

Re: Unit tests

2012-11-10 Thread prasanna
On 10 November 2012 03:03, David Nalley wrote: > On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang wrote: >> +1 the more tests the merrier. >> >> I have noticed that in master doing mvn install actually runs some unit >> tests. I don't like that because it slows down compilation. I haven't >> track

Re: Unit tests

2012-11-09 Thread David Nalley
On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang wrote: > +1 the more tests the merrier. > > I have noticed that in master doing mvn install actually runs some unit > tests. I don't like that because it slows down compilation. I haven't track > down exactly what it is but I think it's in the nicira

RE: Unit tests

2012-11-09 Thread Sudha Ponnaganti
: cloudstack-dev@incubator.apache.org Subject: RE: Unit tests > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, November 09, 2012 12:19 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > > >>

RE: Unit tests

2012-11-09 Thread Alex Huang
> -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, November 09, 2012 12:19 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > > >> 2 - Do we want to get stricter about what exactly is considered t

RE: Unit tests

2012-11-09 Thread Alex Huang
> >> 2 - Do we want to get stricter about what exactly is considered to be > >> a unit test (vs an automated test that may or may not be based on the > >> junit framework)? > > > > I actually consider db tests to be unit tests as long as the db is setup and > cleaned up by the unit test itself. >

Re: Unit tests

2012-11-09 Thread Chip Childers
On Fri, Nov 9, 2012 at 2:46 PM, Alex Huang wrote: >> >> 1 - Do we want tests to run each time mvn install is run? > > No. I like to have choices. > >> >> 2 - Do we want to get stricter about what exactly is considered to be >> a unit test (vs an automated test that may or may not be based on the

RE: Unit tests

2012-11-09 Thread Alex Huang
> > 1 - Do we want tests to run each time mvn install is run? No. I like to have choices. > > 2 - Do we want to get stricter about what exactly is considered to be > a unit test (vs an automated test that may or may not be based on the > junit framework)? I actually consider db tests to be un

Re: Unit tests

2012-11-09 Thread Chip Childers
Sent: Friday, November 09, 2012 11:21 AM >> To: cloudstack-dev@incubator.apache.org >> Subject: Re: Unit tests >> >> I'd like to drop this branch (after moving completed tests over to >> master). The reason that I created it was to specifically avoid >>

RE: Unit tests

2012-11-09 Thread Alex Huang
- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, November 09, 2012 11:21 AM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Unit tests > > I'd like to drop this branch (after moving completed tests over to > master). The reason

Re: Unit tests

2012-11-09 Thread David Nalley
On Fri, Nov 9, 2012 at 2:21 PM, Chip Childers wrote: > I'd like to drop this branch (after moving completed tests over to > master). The reason that I created it was to specifically avoid > messing up the 4.0 work. Since we've moved on already, any issues > integrating the new tests into master?

Re: Unit tests

2012-11-09 Thread Chip Childers
e- >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> Sent: Tuesday, October 30, 2012 9:31 PM >> To: cloudstack-dev@incubator.apache.org >> Subject: RE: Unit tests >> >> Matthew, >> >> Are you looking to write unit tests for which set of APIs? I

Re: Unit tests

2012-10-30 Thread Matthew Morrissey
October 30, 2012 9:31 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > Matthew, > > Are you looking to write unit tests for which set of APIs? Is it the > management server APIs, plugin APIs, or resource APIs? > > Yup. Hugo's path is the corr

RE: Unit tests

2012-10-30 Thread Manikanta Kattamuri
Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, October 30, 2012 9:31 PM To: cloudstack-dev@incubator.apache.org Subject: RE: Unit tests Matthew, Are you looking to write unit tests for which set of APIs? Is it the management server APIs, plugin APIs, or resource APIs

RE: Unit tests

2012-10-30 Thread Alex Huang
Sent: Tuesday, October 30, 2012 8:02 AM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > Hey Matthew, > > Go go go ! > > Put please put the tests in /test/com/cloud/ That > would keep it compatible with the existing location for unit tests

Re: Unit tests

2012-10-30 Thread Matthew Morrissey
Done and done. I'll start work ASAP :) On Tue, Oct 30, 2012 at 11:02 AM, Hugo Trippaers < htrippa...@schubergphilis.com> wrote: > Hey Matthew, > > Go go go ! > > Put please put the tests in /test/com/cloud/ That > would keep it compatible with the existing location for unit tests and make > i

RE: Unit tests

2012-10-30 Thread Hugo Trippaers
Hey Matthew, Go go go ! Put please put the tests in /test/com/cloud/ That would keep it compatible with the existing location for unit tests and make it work with maven right away :-) Cheers, HUgo > -Original Message- > From: Matthew Morrissey [mailto:matthew.morris...@sungard.co

Re: unit tests for api/src/com/cloud/agent/api

2012-09-20 Thread Prasanna Santhanam
> > We can speed up the tests. Just never got to have marvin drive > > everything asynchronously.It's been on my TODO list forever now as > > have the API tests. I for one would be extremely happy to see some. > > I am gonna look into the speed up. Where you thinking of threading > it or using nos

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread Sebastien Goasguen
On Sep 18, 2012, at 6:53 PM, prasanna wrote: > On 18 September 2012 18:20, David Nalley wrote: >> On Mon, Sep 17, 2012 at 7:24 PM, Edison Su wrote: >>> First, thanks for working on test stuff, we really need more automate test >>> cases. >>> If you plan to work on the API test, we have a pyth

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread Yichi Lu
Prasanna: It is my fault. I installed the wrong marvin package. Yichi On Tue, Sep 18, 2012 at 11:55 AM, prasanna wrote: > Sorry jclouds has a cloudstack suite for advanced zone as well. Not > just ec2. cloudstack-ec2 is to test the ec2 shim of cloudstack. > > On 18 September 2012 22:23, prasan

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread prasanna
Sorry jclouds has a cloudstack suite for advanced zone as well. Not just ec2. cloudstack-ec2 is to test the ec2 shim of cloudstack. On 18 September 2012 22:23, prasanna wrote: > On 18 September 2012 18:20, David Nalley wrote: >> On Mon, Sep 17, 2012 at 7:24 PM, Edison Su wrote: >>> First, thank

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread prasanna
On 18 September 2012 18:20, David Nalley wrote: > On Mon, Sep 17, 2012 at 7:24 PM, Edison Su wrote: >> First, thanks for working on test stuff, we really need more automate test >> cases. >> If you plan to work on the API test, we have a python test framework: >> https://cwiki.apache.org/CLOUDS

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread prasanna
Yichi - I think you've got a completely different marvin from the cheeseshop here: http://pypi.python.org/pypi/marvin/0.6.2 What you need is this: http://jenkins.cloudstack.org/job/build-marvin-master/ DId the documentation mislead you somehwere? On 18 September 2012 21:57, Yichi Lu wrote: > S

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread Yichi Lu
I think so. JUnit probably is a better way at this point. Yichi On Tue, Sep 18, 2012 at 11:32 AM, Chip Childers wrote: > Yichi, > > Would more traditional unit tests (using JUnit and moc'ed > dependencies) perhaps be a better way to get to unit test coverage? > (As opposed to other automated tes

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread Chip Childers
Yichi, Would more traditional unit tests (using JUnit and moc'ed dependencies) perhaps be a better way to get to unit test coverage? (As opposed to other automated test types) -chip On Tue, Sep 18, 2012 at 12:27 PM, Yichi Lu wrote: > So I folllowed the doc: > https://cwiki.apache.org/CLOUDSTACK

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread Yichi Lu
So I folllowed the doc: https://cwiki.apache.org/CLOUDSTACK/testing-with-python.html, and tried to install marvin to my 64 bit MacBook, OS: Lion. I installed marvin.0.6.2, and also biopython-1.59 because: >>> import marvin Traceback (most recent call last): File "", line 1, in File "/usr/local

Re: unit tests for api/src/com/cloud/agent/api

2012-09-18 Thread David Nalley
On Mon, Sep 17, 2012 at 7:24 PM, Edison Su wrote: > First, thanks for working on test stuff, we really need more automate test > cases. > If you plan to work on the API test, we have a python test framework: > https://cwiki.apache.org/CLOUDSTACK/testing-with-python.html. The most > compelling f

RE: unit tests for api/src/com/cloud/agent/api

2012-09-17 Thread Edison Su
First, thanks for working on test stuff, we really need more automate test cases. If you plan to work on the API test, we have a python test framework: https://cwiki.apache.org/CLOUDSTACK/testing-with-python.html. The most compelling feature is that it supports code completion for cloudstack API

RE: unit tests for api/src/com/cloud/agent/api

2012-09-17 Thread Sudha Ponnaganti
+1 Awesome indeed!! Looking forward for it -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Monday, September 17, 2012 3:08 PM To: cloudstack-dev@incubator.apache.org Subject: Re: unit tests for api/src/com/cloud/agent/api On Mon, Sep 17, 2012 at 5:56 PM, Yichi Lu

Re: unit tests for api/src/com/cloud/agent/api

2012-09-17 Thread David Nalley
On Mon, Sep 17, 2012 at 5:56 PM, Yichi Lu wrote: > I'd start to write unit tests for classes in api/src/com/cloud/agent/api in > alphabetical order. > > Let me know if you have any suggestions. > > Yichi Lu AWESOME - terribly excited to see this! --David

RE: Unit tests

2012-08-16 Thread Alex Huang
> -Original Message- > From: Alex Huang > Sent: Thursday, August 16, 2012 4:48 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > > > -Original Message- > > From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] >

RE: Unit tests

2012-08-16 Thread Alex Huang
> -Original Message- > From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] > Sent: Thursday, August 16, 2012 4:27 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Unit tests > > +1 > It would be good if patch reviewers can ask for unit tests

RE: Unit tests

2012-08-16 Thread Sudha Ponnaganti
Sent: 16 August 2012 13:05 > To: CloudStack DeveloperList > Subject: Re: Unit tests > > Fixed. One of them was obsolete, the other (NetUtils) actually caught > a valid failure. > > On 8/10/12 4:36 PM, "Ewan Mellor" wrote: > > >http://jenkins.cloud

RE: Unit tests

2012-08-16 Thread Ewan Mellor
16 August 2012 13:05 > To: CloudStack DeveloperList > Subject: Re: Unit tests > > Fixed. One of them was obsolete, the other (NetUtils) actually caught a valid > failure. > > On 8/10/12 4:36 PM, "Ewan Mellor" wrote: > > >http://jenkins.cloudstack.org/job

Re: Unit tests

2012-08-16 Thread David Nalley
Yes, I just noticed this that jenkins is reporting zero unit test failures. That's awesome! --David On Thu, Aug 16, 2012 at 4:05 PM, Chiradeep Vittal wrote: > Fixed. One of them was obsolete, the other (NetUtils) actually caught a > valid failure. > > On 8/10/12 4:36 PM, "Ewan Mellor" wrote: >

Re: Unit tests

2012-08-16 Thread Chiradeep Vittal
Fixed. One of them was obsolete, the other (NetUtils) actually caught a valid failure. On 8/10/12 4:36 PM, "Ewan Mellor" wrote: >http://jenkins.cloudstack.org/job/test-junit, by the way. > >Ewan. > >From: Ewan Mellor >Sent: 10 August 2012 16:36 >To: cloudstack-dev@incubator.apache.org >Subject:

RE: Unit tests

2012-08-10 Thread Ewan Mellor
http://jenkins.cloudstack.org/job/test-junit, by the way. Ewan. From: Ewan Mellor Sent: 10 August 2012 16:36 To: cloudstack-dev@incubator.apache.org Subject: Unit tests We are down to the last two unit test failures (thanks to Mice for his recent patch which dealt with two others). The failure