Yes, I just noticed this that jenkins is reporting zero unit test failures. That's awesome!
--David On Thu, Aug 16, 2012 at 4:05 PM, Chiradeep Vittal <chiradeep.vit...@citrix.com> wrote: > Fixed. One of them was obsolete, the other (NetUtils) actually caught a > valid failure. > > On 8/10/12 4:36 PM, "Ewan Mellor" <ewan.mel...@eu.citrix.com> wrote: > >>http://jenkins.cloudstack.org/job/test-junit, by the way. >> >>Ewan. >> >>From: Ewan Mellor >>Sent: 10 August 2012 16:36 >>To: cloudstack-dev@incubator.apache.org >>Subject: Unit tests >> >>We are down to the last two unit test failures (thanks to Mice for his >>recent patch which dealt with two others). >> >>The failures are: >>com.cloud.agent.manager.ResourceManagerTest.testDeploy100Hosts (reliable) >>and >>com.cloud.utils.net.NetUtilsTest.testGetRandomIpFromCidr (50% >>intermittent) >> >>Full error messages are below. Can someone please take a look? Mice >>asked for help from the core team on these ones, so I'm likely looking >>for someone from Citrix. >> >>Thanks, >> >>Ewan. >> >> [junit] com.cloud.utils.exception.CloudRuntimeException: Unable to >>find DAO com.cloud.storage.dao.VMTemplateDetailsDao >> [junit] at >>com.cloud.utils.component.ComponentLocator.getDao(ComponentLocator.java:39 >>9) >> [junit] at >>com.cloud.utils.component.ComponentLocator.getDao(ComponentLocator.java:42 >>2) >> [junit] at >>com.cloud.utils.component.ComponentLocator.inject(ComponentLocator.java:49 >>6) >> [junit] at >>com.cloud.utils.component.ComponentLocator.createInstance(ComponentLocator >>.java:382) >> [junit] at >>com.cloud.utils.component.ComponentLocator.startDaos(ComponentLocator.java >>:290) >> [junit] at >>com.cloud.utils.component.ComponentLocator.parse(ComponentLocator.java:246 >>) >> [junit] at >>com.cloud.utils.component.MockComponentLocator.makeActive(MockComponentLoc >>ator.java:91) >> [junit] at >>com.cloud.agent.manager.ResourceManagerTest.setUp(ResourceManagerTest.java >>:319) >> [junit] at junit.framework.TestCase.runBare(TestCase.java:132) >> [junit] at >>junit.framework.TestResult$1.protect(TestResult.java:110) >> [junit] at >>junit.framework.TestResult.runProtected(TestResult.java:128) >> [junit] at junit.framework.TestResult.run(TestResult.java:113) >> [junit] at junit.framework.TestCase.run(TestCase.java:124) >> [junit] at junit.framework.TestSuite.runTest(TestSuite.java:232) >> [junit] at junit.framework.TestSuite.run(TestSuite.java:227) >> [junit] at >>org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTest >>Runner.java:518) >> [junit] at >>org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitT >>estRunner.java:1052) >> [junit] at >>org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTes >>tRunner.java:906) >> [junit] Running com.cloud.agent.manager.ResourceManagerTest >> >> >> >>junit.framework.AssertionFailedError: This should be -1 because we ran >>out of ip addresses: 3232267268 expected:<3232267268> but was:<-1> >> >> at >>com.cloud.utils.net.NetUtilsTest.testGetRandomIpFromCidr(NetUtilsTest.java >>:53) >> >
