On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang <alex.hu...@citrix.com> wrote: > +1 the more tests the merrier. > > I have noticed that in master doing mvn install actually runs some unit > tests. I don't like that because it slows down compilation. I haven't track > down exactly what it is but I think it's in the nicira plugin.
I think tests are running for everything, and some of them are not actually unit tests. Anything that requires something like a DB isn't a true unit test IMO. I think there are 2 questions to answer here: 1 - Do we want tests to run each time mvn install is run? 2 - Do we want to get stricter about what exactly is considered to be a unit test (vs an automated test that may or may not be based on the junit framework)? > --Alex > >> -----Original Message----- >> From: Chip Childers [mailto:chip.child...@sungard.com] >> Sent: Friday, November 09, 2012 11:21 AM >> To: cloudstack-dev@incubator.apache.org >> Subject: Re: Unit tests >> >> I'd like to drop this branch (after moving completed tests over to >> master). The reason that I created it was to specifically avoid >> messing up the 4.0 work. Since we've moved on already, any issues >> integrating the new tests into master? >> >> -chip >> >> On Tue, Oct 30, 2012 at 3:34 PM, Matthew Morrissey >> <matthew.morris...@sungard.com> wrote: >> > I would be working on everything in api/src/com/cloud/api/ >> > >> > On Tue, Oct 30, 2012 at 1:52 PM, Manikanta Kattamuri < >> > manikanta.kattam...@sungard.com> wrote: >> > >> >> Hi All, >> >> >> >> Chip has created a branch for junit-tests. >> >> There are some issues with folder structure in it, I sent a patch for >> >> review 7776 on request board, once it is reviewed and committed the >> >> structure will be set and all the units already written are in the new >> >> structure. >> >> >> >> Mani >> >> >> >> -----Original Message----- >> >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> >> Sent: Tuesday, October 30, 2012 9:31 PM >> >> To: cloudstack-dev@incubator.apache.org >> >> Subject: RE: Unit tests >> >> >> >> Matthew, >> >> >> >> Are you looking to write unit tests for which set of APIs? Is it the >> >> management server APIs, plugin APIs, or resource APIs? >> >> >> >> Yup. Hugo's path is the correct one. >> >> >> >> --Alex >> >> >> >> > -----Original Message----- >> >> > From: Hugo Trippaers [mailto:htrippa...@schubergphilis.com] >> >> > Sent: Tuesday, October 30, 2012 8:02 AM >> >> > To: cloudstack-dev@incubator.apache.org >> >> > Subject: RE: Unit tests >> >> > >> >> > Hey Matthew, >> >> > >> >> > Go go go ! >> >> > >> >> > Put please put the tests in <sub_project_folder>/test/com/cloud/.... >> >> > That would keep it compatible with the existing location for unit >> >> > tests and make it work with maven right away :-) >> >> > >> >> > Cheers, >> >> > >> >> > HUgo >> >> > >> >> > > -----Original Message----- >> >> > > From: Matthew Morrissey [mailto:matthew.morris...@sungard.com] >> >> > > Sent: Tuesday, October 30, 2012 3:35 PM >> >> > > To: cloudstack-dev@incubator.apache.org >> >> > > Subject: Unit tests >> >> > > >> >> > > Hello all, >> >> > > >> >> > > I would like to begin writing unit tests for api/src/com/cloud/api >> >> > > and I wanted to make sure that 1) it's an acceptable idea to >> >> > > everyone and >> >> > > 2) I get the directory structure correct. I have seen a few emails >> >> > > about the possible structure but no concrete "this is the way to go" >> >> > > type >> >> > statements. >> >> > > My thought is that these tests would be in >> >> > > api/src/test/java/com/cloud/api/*.java. Is this the right line of >> >> thought? >> >> > > Please let me know and I'll get the ball rolling. I've got a long >> >> > > way to go if I want to catch up to Yichi :) >> >> > > >> >> > > -- >> >> > > Matthew Morrissey >> >> > > Software Engineer - SunGard Availability Services - 401 N. Broad >> >> > > Street, Philadelphia, PA 19108 >> >> > > o: 215-446-2713 - e: matthew.morris...@sungard.com >> >> >> >> >> > >> > >> > -- >> > Matthew Morrissey >> > Software Engineer I - SunGard Availability Services - 401 N. Broad Street, >> > Philadelphia, PA 19108 >> > o: 215-446-2713 - e: matthew.morris...@sungard.com >
