Re: Review Request: STT isolation support for KVM

2012-09-19 Thread Tomoe Sugihara
tps://reviews.apache.org/r/7165/#comment25272> I would put this change in a separate patch since it's not related. - Tomoe Sugihara On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically

Re: Review Request: STT isolation support for KVM

2012-09-19 Thread Tomoe Sugihara
want to use OVS on guest network along with linux bridge for the other networks, though. - Tomoe Sugihara On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-31 Thread Tomoe Sugihara
one in > the same way, so it will be easy for users to implement either one of them. > > Cheers, > > Hugo > > -Original Message- > From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf Of Tomoe > Sugihara > Sent: Wednesday, August 08, 2012 5:34 PM > To:

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-21 Thread Tomoe Sugihara
view10213 --- On Aug. 9, 2012, 9:10 a.m., Tomoe Sugihara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request: Introduce Vif Driver in KVM

2012-08-21 Thread Tomoe Sugihara
5/#review10141 --- On Aug. 6, 2012, 1:39 a.m., Tomoe Sugihara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: [RFC] CloudStack Architectural Refactor

2012-08-10 Thread Tomoe Sugihara
Hi, Sorry for commenting to this thread during the busiest time right before the release, But I'd like to add my thoughts especially on networking part while my memory is fresh since I started working on integration our networking technology from Midokura to CS a couple of weeks ago. I'm still new

Review Request: Fix the path for the API server endpoint.

2012-08-10 Thread Tomoe Sugihara
server endpoint. Signed-off-by: Tomoe Sugihara Diffs - cloud-cli/cloudapis/cloud.py 34b3413ce5e109288db32c9131687995902cadcd Diff: https://reviews.apache.org/r/6513/diff/ Testing --- manually tested with cloud-tool commmand Thanks, Tomoe Sugihara

Re: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-08-09 Thread Tomoe Sugihara
On Fri, Aug 10, 2012 at 7:56 AM, Ewan Mellor wrote: >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> >> [Snip] >> >> The thread started because the current system isn't really a system, >> it's just a folder full of binary jars which we were advised against >> (and saw

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-09 Thread Tomoe Sugihara
--- changed names for the sake of consistency. Description --- Add skeletons and build.xml for Midokura Midonet We will provide more once integration is done. Signed-off-by: Tomoe Sugihara Add Provider and NetworkDevice for Midokura MidoNet Signed-off-by: Tomoe Sugihara Diffs

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-08 Thread Tomoe Sugihara
On Wed, Aug 8, 2012 at 11:05 PM, Murali Reddy wrote: > On 08/08/12 1:16 PM, "Tomoe Sugihara" wrote: > >> >>--- >>This is an automatically generated e-mail. To reply, visit: &

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-08 Thread Tomoe Sugihara
--- Add skeletons for Midonet integration. Description (updated) --- Add skeletons and build.xml for Midokura Midonet We will provide more once integration is done. Signed-off-by: Tomoe Sugihara Add Provider and NetworkDevice for Midokura MidoNet Signed-off-by: Tomoe Sugihara Diffs

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-08 Thread Tomoe Sugihara
On Wed, Aug 8, 2012 at 11:21 PM, Tomoe Sugihara wrote: > On Wed, Aug 8, 2012 at 11:05 PM, Murali Reddy wrote: >> On 08/08/12 1:16 PM, "Tomoe Sugihara" wrote: >> >>> >>>--- >>>This i

Re: Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-08 Thread Tomoe Sugihara
On Wed, Aug 8, 2012 at 11:05 PM, Murali Reddy wrote: > On 08/08/12 1:16 PM, "Tomoe Sugihara" wrote: > >> >>--- >>This is an automatically generated e-mail. To reply, visit: &

Review Request: Add Provider and NetworkDevice for Midokura MidoNet

2012-08-08 Thread Tomoe Sugihara
== Add Provider and NetworkDevice for Midokura MidoNet Signed-off-by: Tomoe Sugihara Thanks, Tomoe Diffs - api/src/com/cloud/network/Network.java 459b05bc6abe61765974804e43fc4dbae819e20f server/src/com/cloud/networ

Re: Review Request: Introduce Vif Driver in KVM

2012-08-07 Thread Tomoe Sugihara
this in for 4.0. Thanks! - Tomoe Sugihara On Aug. 6, 2012, 1:39 a.m., Tomoe Sugihara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: making VM startup more fine-grained

2012-08-07 Thread Tomoe Sugihara
On Tue, Aug 7, 2012 at 4:30 PM, Murali Reddy wrote: > On 07/08/12 12:11 PM, "Tomoe Sugihara" wrote: > >>On Tue, Aug 7, 2012 at 3:34 PM, Alex Huang wrote: >>>> I have looked at the code more in detail and found a bit tricky thing. >>>> >>>&g

Re: making VM startup more fine-grained

2012-08-06 Thread Tomoe Sugihara
On Tue, Aug 7, 2012 at 3:34 PM, Alex Huang wrote: >> I have looked at the code more in detail and found a bit tricky thing. >> >> Inside the createVif() method, it calls getNetwork(conn, nic) to set >> vifr.network record. And inside getNetwork(), it differentiates by >> BroadcastDomainType. >> >>

Re: making VM startup more fine-grained

2012-08-06 Thread Tomoe Sugihara
On Mon, Aug 6, 2012 at 6:18 PM, Tomoe Sugihara wrote: > On Fri, Jul 27, 2012 at 10:13 AM, Chiradeep Vittal > wrote: >> >> >> On 7/25/12 10:52 PM, "Ishimoto, Ryu" wrote: >> >>>On Mon, Jun 4, 2012 at 3:02 PM, Chiradeep Vittal < >>>chi

Re: Review Request: Introduce Vif Driver in KVM

2012-08-06 Thread Tomoe Sugihara
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9882 ------- On Aug. 6, 2012, 1:39 a.m., Tomoe Sugihara wrote: > > --- > This

Re: making VM startup more fine-grained

2012-08-06 Thread Tomoe Sugihara
On Fri, Jul 27, 2012 at 10:13 AM, Chiradeep Vittal wrote: > > > On 7/25/12 10:52 PM, "Ishimoto, Ryu" wrote: > >>On Mon, Jun 4, 2012 at 3:02 PM, Chiradeep Vittal < >>chiradeep.vit...@citrix.com> wrote: >> >>> >>> Also note that in order to support hotplug and hot-detach of nics, we >>>need >>> com

Re: Review Request: Introduce Vif Driver in KVM

2012-08-05 Thread Tomoe Sugihara
ource/VifDriver.java PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java PRE-CREATION Diff: https://reviews.apache.org/r/6285/diff/ Testing --- Manually tested launching VM on all-in-one KVM box with Advanced networking. Thanks, Tomoe Sugihara

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-05 Thread Tomoe Sugihara
ad of requiring the nicModel in the API definition, you can > > configure this subclass with a reference to LibVirtComputingResource. The > > plug API then looks like > > plug(NicTO nic, String guestOsType). The implementation of plug can ask > > LibVirtComputingResou

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-05 Thread Tomoe Sugihara
ld > > have an abstract configure() method that throws a ConfigurationException > > Tomoe Sugihara wrote: > Thanks for the review. Sure, I can do that. > Note that VifDriver will be hypervisor specific (signature differes), so > maybe I should create a interface com

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
rs/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java, > > line 781 > > <https://reviews.apache.org/r/6285/diff/3/?file=133629#file133629line781> > > > > Should not printStackTrace, use logger.error() instead Will fix. - Tomoe --- This is

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
.hypervisor.xen.VifDriver for Xen. What do you think? - Tomoe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9837 ----

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-02 Thread Tomoe Sugihara
Chiradeep Vittal. Changes --- fix typo in commit log Summary (updated) - Introduce pluggable vif driver support on KVM Description (updated) --- Remove methods that are no longer needed in LibvirtComputingResource.java Signed-off-by: Tomoe Sugihara Add unplug

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-02 Thread Tomoe Sugihara
) --- Remove methods that are no longer needed in LibvirtComputingResource.java Signed-off-by: Tomoe Sugihara Add unpug() hook Signed-off-by: Tomoe Sugihara Add vif driver support - define abstract class named LibvirtVifDriver - add LibvirtBridgeVifDriver to support current network implementation

Re: Review Request: POC VIF plugin implementation

2012-08-01 Thread Tomoe Sugihara
ches. - Tomoe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9714 --- On Aug. 1, 2012, 4:42 p.m., Tomoe

Re: making VM startup more fine-grained

2012-08-01 Thread Tomoe Sugihara
On Fri, Jul 27, 2012 at 10:13 AM, Chiradeep Vittal wrote: > > > On 7/25/12 10:52 PM, "Ishimoto, Ryu" wrote: > >>On Mon, Jun 4, 2012 at 3:02 PM, Chiradeep Vittal < >>chiradeep.vit...@citrix.com> wrote: >> >>> >>> Also note that in order to support hotplug and hot-detach of nics, we >>>need >>> com

Review Request: POC VIF plugin implementation

2012-08-01 Thread Tomoe Sugihara
irtComputingResource.java ea12b986b0a771c028354637a657b100fc3cfa27 Diff: https://reviews.apache.org/r/6285/diff/ Testing --- Thanks, Tomoe Sugihara

Review Request: Another clean up for unnecessary parameter conn Clean up unused parameter conn. Add test for LibvirtVMDef Add support for ethernet type

2012-08-01 Thread Tomoe Sugihara
unnecessary parameter conn Signed-off-by: Tomoe Sugihara Clean up unused parameter conn. Signed-off-by: Tomoe Sugihara Add test for LibvirtVMDef Signed-off-by: Tomoe Sugihara Add support for ethernet type Signed-off-by: Tomoe Sugihara Diffs - plugins/hypervisors/kvm/src/com/cloud

Re: non-committer workflow

2012-08-01 Thread Tomoe Sugihara
On Wed, Aug 1, 2012 at 9:56 PM, Prasanna Santhanam wrote: > On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote: >> >> On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote: >> >> > On 08/01/2012 04:50 AM, Alex Huang wrote: >> >>> So currently, there are three ways for a patch to be receiv

Re: Review Request: Fix the agent path according to 7a0a9231c355fee42c67799abe111edcd79998bb

2012-08-01 Thread Tomoe Sugihara
> On July 31, 2012, 9:27 a.m., Prasanna Santhanam wrote: > > Bug Report: http://bugs.cloudstack.org/browse/CS-15776 > > > > Saw quite a few whitespace changes as well. Ran a pychecker on the patch > > and it looks fine. > > > > > > Tomoe Sugi

Re: Review Request: Fix the agent path according to 7a0a9231c355fee42c67799abe111edcd79998bb

2012-07-31 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6227/#review9632 --- On July 31, 2012, 8:29 a.m., Tomoe Sugihara wrote: > > --

Review Request: Fix the agent path according to 7a0a9231c355fee42c67799abe111edcd79998bb

2012-07-31 Thread Tomoe Sugihara
path according to 7a0a9231c355fee42c67799abe111edcd79998bb Signed-off-by: Tomoe Sugihara Diffs - python/lib/cloudutils/serviceConfig.py 539e26ae7322934de08576918a376c0487157d97 Diff: https://reviews.apache.org/r/6227/diff/ Testing --- Thanks, Tomoe Sugihara

Re: Review Request: Fix typo

2012-07-31 Thread Tomoe Sugihara
-mail. To reply, visit: https://reviews.apache.org/r/6200/#review9592 --- On July 30, 2012, 6:53 a.m., Tomoe Sugihara wrote: > > --- > This is an automatically generated e-mai

Re: making VM startup more fine-grained

2012-07-30 Thread Tomoe Sugihara
On Fri, Jul 27, 2012 at 10:13 AM, Chiradeep Vittal wrote: > > > On 7/25/12 10:52 PM, "Ishimoto, Ryu" wrote: > >>On Mon, Jun 4, 2012 at 3:02 PM, Chiradeep Vittal < >>chiradeep.vit...@citrix.com> wrote: >> >>> >>> Also note that in order to support hotplug and hot-detach of nics, we >>>need >>> com

Re: KVM code will be moved to plugin folder

2012-07-30 Thread Tomoe Sugihara
Thanks, now working fine. On Tue, Jul 31, 2012 at 8:01 AM, Edison Su wrote: > Sorry, forget to check in some files. > Checkout out the latest master, will be fixed. > >> -Original Message- >> From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf Of Tomo

Re: KVM code will be moved to plugin folder

2012-07-30 Thread Tomoe Sugihara
Hi Edison, You may already know this but, now compile-server is broken: On Tue, Jul 31, 2012 at 7:03 AM, Edisocompile-server: [mkdir] Created dir: /home/tomoe/code/incubator-cloudstack/target/classes/cloud-server.jar [echo] Compiling /home/tomoe/code/incubator-cloudstack/server/src

Review Request: Fix typo

2012-07-29 Thread Tomoe Sugihara
to run correctly as com.cloud.utils.script.Script#findScript looks for "paths.script" instead of "paths.scripts". Signed-off-by: Tomoe Sugihara Diffs - agent/conf/environment.properties.in 7fcf570538fdc7de0e9b180ba1d35897c2001f3f Diff: https://reviews.apache.org/r/

Re: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-07-20 Thread Tomoe Sugihara
On Jul 21, 2012, at 4:13 AM, David Nalley wrote: > In one of the OSCON discussions, I noted the recent polite discussion > re binary jars in source releases on general@incubator. While this is > apparently tolerated (if you don't mind wearing Nomex), it's > considered a Bad Thing (TM) generally s

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-12 Thread Tomoe Sugihara
evCloud. I found an workaround by running the following command: VBoxManage modifyvm DevCloud --natdnshostresolver1 on Thanks, Tomoe On Wed, Jul 11, 2012 at 9:02 AM, Edison Su wrote: > > >> -Original Message- >> From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf

Re: [PATCH] Add trust="yes" option to ssh tasks

2012-07-10 Thread Tomoe Sugihara
-review command to post the patch, but I couldn't get past the authentication. Is web API disabled? Thanks, Tomoe > >> -Original Message- >> From: Tomoe Sugihara [mailto:to...@midokura.jp] On Behalf Of Tomoe >> Sugihara >> Sent: Monday, July 09, 2012 4:52

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-10 Thread Tomoe Sugihara
On Wed, Jul 11, 2012 at 2:33 AM, Edison Su wrote: > > >> -Original Message- >> From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf Of Tomoe >> Sugihara >> Sent: Tuesday, July 10, 2012 1:22 AM >> To: cloudstack-dev@incubator.apache.org >>

Review Request: Add trust="yes" option to ssh tasks

2012-07-10 Thread Tomoe Sugihara
="yes" option to ssh tasks ant r* targets would error out if you haven't added a host entry for devcloud. This fixes the problem by trusting it. Signed-off-by: Tomoe Sugihara Diffs - build/build-devcloud.xml b65e9e4 Diff: https://reviews.apache.org/r/5897/

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-10 Thread Tomoe Sugihara
On Tue, Jul 10, 2012 at 3:32 AM, Edison Su wrote: > > > > Not rdeploydb, but successfully ran "rdebug". > > However, I still can't find ListTemplate even in /var/log/cloud/ > > Better to fix rdeploydb at first, right now, your system is in a good shape. > If you had taken a snapshot for devcloud

[PATCH] Add trust="yes" option to ssh tasks

2012-07-09 Thread Tomoe Sugihara
ant r* targets would error out if you haven't added a host entry for devcloud. This fixes the problem by trusting it. Signed-off-by: Tomoe Sugihara --- build/build-devcloud.xml | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/build/

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-09 Thread Tomoe Sugihara
On Mon, Jul 9, 2012 at 4:25 PM, Edison Su wrote: > > > Sent from my iPhone > > On Jul 8, 2012, at 11:31 PM, "Tomoe Sugihara" wrote: > > > On Mon, Jul 9, 2012 at 9:20 AM, Edison Su wrote: > > > >> > >> > >> Sent from my iP

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-08 Thread Tomoe Sugihara
On Mon, Jul 9, 2012 at 11:23 AM, David Nalley wrote: > On Sun, Jul 8, 2012 at 8:20 PM, Edison Su wrote: > > > > > > Sent from my iPhone > > > > On Jul 7, 2012, at 9:19 AM, "Tomoe Sugihara" to...@midokura.com>> wrote: > > > >

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-08 Thread Tomoe Sugihara
On Mon, Jul 9, 2012 at 9:20 AM, Edison Su wrote: > > > Sent from my iPhone > > On Jul 7, 2012, at 9:19 AM, "Tomoe Sugihara" to...@midokura.com>> wrote: > > Hi Edison, > > This is very helpful for newbies like me. > However, I tried this accor

Re: [RFC] DevCloud, an all-in-one-box CloudStack development environment

2012-07-07 Thread Tomoe Sugihara
Hi Edison, This is very helpful for newbies like me. However, I tried this according to the wiki page, but found some problems listed below. I managed to add a host, but couldn't even launch a VM due to the issue 3. I hope this would help improve DevCloud. 1. ssh com

Re: Fix for the issue CS-15143?

2012-07-04 Thread Tomoe Sugihara
the cloud-early-config init script inside SSVM. Tomoe > -Original Message- > From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf Of Tomoe > Sugihara > Sent: Tuesday, June 26, 2012 12:53 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Fix for the is

Re: [PATCH] Fix broken debian packaging

2012-06-26 Thread Tomoe Sugihara
On Tue, Jun 26, 2012 at 6:07 PM, Wido den Hollander wrote: > On 06/26/2012 10:59 AM, Tomoe Sugihara wrote: > >> Signed-off-by: Tomoe Sugihara >> --- >> debian/cloud-deps.install |2 +- >> debian/cloud-server.install |4 >> debian/cloud-utils.

Re: building debian packages from master branch

2012-06-26 Thread Tomoe Sugihara
den Hollander wrote: > >> On 06/26/2012 03:11 AM, Tomoe Sugihara wrote: >> >>> Hi, >>> >>> I just tried to build debian packages from master branch of ASF repo, but >>> it was failing because of >>> obsolete files under "debian" d

[PATCH] Fix broken debian packaging

2012-06-26 Thread Tomoe Sugihara
Signed-off-by: Tomoe Sugihara --- debian/cloud-deps.install |2 +- debian/cloud-server.install |4 debian/cloud-utils.install |1 - debian/control | 21 - 4 files changed, 5 insertions(+), 23 deletions(-) diff --git a/debian/cloud

Re: Fix for the issue CS-15143?

2012-06-26 Thread Tomoe Sugihara
mounts the secondary storage nfs export. So I'm wondering if SSVM should have gotten the newly built jar. I'm thinking to replace /usr/local/cloud/systemvm/cloud-core.jar manually by using scp to work around the issue for now. Thanks, Tomoe On Tue, Jun 26, 2012 at 8:39 AM, Tomoe Sugih

building debian packages from master branch

2012-06-25 Thread Tomoe Sugihara
Hi, I just tried to build debian packages from master branch of ASF repo, but it was failing because of obsolete files under "debian" directory. I was able to build with the patch below. Could someone review this and hopefully apply it to the master? Cheers, Tomoe -- diff --git

Re: Fix for the issue CS-15143?

2012-06-25 Thread Tomoe Sugihara
; > > I had verified this got fixed . Will verify whether this commit is > available on > > the apache repo and let you know. > > > > > -Original Message- > > > From: to...@midokura.jp [mailto:to...@midokura.jp] On Behalf Of > > Tomoe > > > Sugihara >

Fix for the issue CS-15143?

2012-06-24 Thread Tomoe Sugihara
Hi, I'm trying to set up a dev environment using ASF git repo (3.0.x branch), but I'm hitting this issue :http://bugs.cloudstack.org/browse/CS-15143 Is there any way that I could get the patch for this issue? I don't have an access to the repo described on the JIRA page). And, I looked at the git