----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/ -----------------------------------------------------------
(Updated Aug. 6, 2012, 1:39 a.m.) Review request for cloudstack, edison su and Chiradeep Vittal. Changes ------- Incorporate Chiradeep's comments. Summary (updated) ----------------- Introduce Vif Driver in KVM Description (updated) ------- Add BridgeVifDriver and move current vif implementation to it. - remove dependency on VirtualRoutingResource. - factor out some of the networking code in LibvirtComputingResource to BridgeVifDriver. Add base class for KVM VifDriver. Add VifDriver Interface for KVM. Diffs (updated) ----- core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 33e297187fd7deaa6f6f975a115ff3c4c80f6794 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 73101a9896c4863bc75502ff8b0b6daceff52dc4 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriver.java PRE-CREATION plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java PRE-CREATION Diff: https://reviews.apache.org/r/6285/diff/ Testing ------- Manually tested launching VM on all-in-one KVM box with Advanced networking. Thanks, Tomoe Sugihara
