Re: RFR: 8286172: Create an automated test for JDK-4516019 [v3]

2022-06-09 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) > > Clicking on the increment/decrement buttons of the spinner does not install > focus on the spinner or one of its focusable children. > > The test validates the same. > > This review is for migr

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v4]

2022-06-09 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) > > Clicking on the increment/decrement buttons of the spinner does not install > focus on the spinner or one of its focusable children. > > The test validates the same. > > This review is for migr

client-libs-dev@openjdk.java.net

2022-06-09 Thread Tejesh R
On Mon, 23 May 2022 07:03:03 GMT, Tejesh R wrote: > _Header_ object not initialized/set when paint() method of > `WindowTableHeaderUI` class is executed. The paint() event is executed > through explicit call of `JTable.updateUI()` in the regression test. In order > to set the _header_ to the _

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v2]

2022-06-09 Thread Srinivas Mandalika
On Mon, 23 May 2022 17:20:38 GMT, Alisen Chung wrote: >> Srinivas Mandalika has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Review comments fixed: Fixed file path, removed redundant sleep call etc. >> - Review comments fixed: Removed

Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-06-09 Thread Alexey Ivanov
On Mon, 6 Jun 2022 22:53:11 GMT, Alexander Zuev wrote: > Here, in the name of resolving this issue finally i have reverted the > ImageIcon changes, instead i added some code that creates the properly scaled > version of icon when requested variant is not available. This looks good! > I am not

Re: RFR: 8282526: Default icon is not painted properly [v6]

2022-06-09 Thread Alexey Ivanov
On Mon, 6 Jun 2022 23:47:15 GMT, Alexander Zuev wrote: >> Detect the situation where we do need to perform interpolation during >> ImageIcon >> painting and set a hint to the rendering to perform bicubic approximation so >> image details are preserved during transition. > > Alexander Zuev has up

Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-06-09 Thread Alexey Ivanov
On Thu, 2 Jun 2022 17:24:10 GMT, Alexander Zuev wrote: > > Do we need to update the size value and take into account the low/hi sizes? > > Not exactly, the issue is that for some files (but just for some of them) > this call ignores the high icon size parameter and always returns the set of >

Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-06-09 Thread Alexey Ivanov
On Fri, 3 Jun 2022 21:48:46 GMT, Sergey Bylokhov wrote: >>> Because for some files - and we can not predict which files these are - >>> function will always return set of 16x16 and 32x32 icons - no matter what >>> we request. For the icons that return proper sizes we do request exact >>> sizes

Re: RFR: 8282526: Default icon is not painted properly [v6]

2022-06-09 Thread Alexey Ivanov
On Mon, 6 Jun 2022 23:47:15 GMT, Alexander Zuev wrote: >> Detect the situation where we do need to perform interpolation during >> ImageIcon >> painting and set a hint to the rendering to perform bicubic approximation so >> image details are preserved during transition. > > Alexander Zuev has up

RFR: JDK-8288094: cleanup old _MSC_VER handling

2022-06-09 Thread Matthias Baesken
We still handle at a number of places ancient historic _MSC_VER versions of Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). This should be cleaned up, as long as it is not 3rd party code that we don't want to adjust. Currently still supported ("valid") VS version are 2017+, se

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v4]

2022-06-09 Thread Srinivas Mandalika
On Mon, 23 May 2022 17:11:24 GMT, Alexander Zuev wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Fixed File location path. > > test/jdk/javax/accessibility/JFileChooserAccessibleDescrip

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-06-09 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:38:49 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> BoundedRangeModel.getMaximum() from getMaximumAcce

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-06-09 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:37:03 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of the following components: >> >> java.a

Re: RFR: 8282526: Default icon is not painted properly [v6]

2022-06-09 Thread Alexey Ivanov
On Thu, 9 Jun 2022 10:50:37 GMT, Alexey Ivanov wrote: > Since `test.not` is for this test only, would > `WindowsDefaultIconSizeTest.test.not` be a better name for the test file? Better yet is to create the file dynamically in the test code? - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-06-09 Thread Alisen Chung
On Wed, 18 May 2022 08:37:03 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of the following components: >> >> java.a

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated [v13]

2022-06-09 Thread Damon Nguyen
> Updated Parser class doc by appending to the doc regarding lack of support > for HTML script tags. Adding this information to the "parse" function did not > seem as consistent for formatting as adding it to the Parser class doc. Damon Nguyen has updated the pull request incrementally with one

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v24]

2022-06-09 Thread Phil Race
On Wed, 8 Jun 2022 21:30:28 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed declarations > > test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java line 44: > >> 42: * @bug

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v25]

2022-06-09 Thread Phil Race
On Wed, 8 Jun 2022 22:41:55 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed rendering hints, changed condition to reapply old transform > > src/java.desktop/share/classes/javax/swing/bord

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated [v13]

2022-06-09 Thread Phil Race
On Thu, 9 Jun 2022 18:15:03 GMT, Damon Nguyen wrote: >> Updated Parser class doc by appending to the doc regarding lack of support >> for HTML script tags. Adding this information to the "parse" function did >> not seem as consistent for formatting as adding it to the Parser class doc. > > Damo

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v4]

2022-06-09 Thread Alisen Chung
On Thu, 9 Jun 2022 07:32:29 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) >> >> Clicking on the increment/decrement buttons of the spinner does not install >> focus on the spinner or one of its focusable child

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v24]

2022-06-09 Thread Alexey Ivanov
On Thu, 9 Jun 2022 18:44:53 GMT, Phil Race wrote: >> test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java line 44: >> >>> 42: * @bug 8279614 >>> 43: * @summary The left line of the TitledBorder is not painted on 150 >>> scale factor >>> 44: * @requires (os.family == "windows"

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-09 Thread Alexey Ivanov
On Tue, 7 Jun 2022 09:00:30 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 147: >> >>> 145: MultiResolutionImage img = >>> robot.createMultiResolutionScreenCapture(rect); >>> 146: return (BufferedImage)img.getResolutionVariant

Withdrawn: 8274082 : Wrong test case name specified in jtreg run tag for java/awt/print/PrinterJob/SwingUIText.java

2022-06-09 Thread duke
On Thu, 24 Mar 2022 20:24:35 GMT, lawrence.andrews wrote: > Following issues were fixed in this test > 1) Fixed - Parser error due to yesno in @run main/manual=yesno > 2) Fixed Wrong test name specified in @run jtreg > @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v2]

2022-06-09 Thread Laurent Bourgès
On Thu, 9 Jun 2022 02:16:45 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original step

RFR: 8272998: ImageIO.read() throws incorrect exception type

2022-06-09 Thread Phil Race
ImageIO.read() only documents IOException for any kind of decoding problem and since it is a convenience API we don't want to start requiring applications to handle other RuntimeExceptions. So in the unlikely case of some problem decoding using this API, wrap any RuntimeException in an IIOExcept

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v3]

2022-06-09 Thread Jeremy
> Previously when you drew a line that moved exactly (+0, +0) with a miter > stroke the Stroker class acted like a horizontal miter was appropriate. Now > we abort instead, so no miter is applied. > > The new unit test tests the original steps plus several variations. > > I'm a little nervous a

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v3]

2022-06-09 Thread Jeremy
On Fri, 10 Jun 2022 00:30:17 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original ste

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

2022-06-09 Thread Jeremy
> Previously when you drew a line that moved exactly (+0, +0) with a miter > stroke the Stroker class acted like a horizontal miter was appropriate. Now > we abort instead, so no miter is applied. > > The new unit test tests the original steps plus several variations. > > I'm a little nervous a

RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-09 Thread Tejesh R
Fix history - #7422. The test is automatic and check if the last row is painted (Which was not happening before the fix, the last row appeared only after MouseClick operation) by capturing the last row before and after MouseClick Operation.If the both the captured images are same, then the test

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-09 Thread Sergey Bylokhov
On Thu, 9 Jun 2022 20:22:47 GMT, Alexey Ivanov wrote: >> Maybe it's different in iMac systems..I dont have access to this system to >> analyse further nor do I have much knowledge on this 2D/awt multiresolution >> image side of things.. > > If I remember correctly, MRI will contain only one ima

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

2022-06-09 Thread Laurent Bourgès
On Fri, 10 Jun 2022 01:24:48 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original ste

Re: RFR: 8282526: Default icon is not painted properly [v6]

2022-06-09 Thread Sergey Bylokhov
On Mon, 6 Jun 2022 23:47:15 GMT, Alexander Zuev wrote: >> Detect the situation where we do need to perform interpolation during >> ImageIcon >> painting and set a hint to the rendering to perform bicubic approximation so >> image details are preserved during transition. > > Alexander Zuev has up

Re: RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.

2022-06-09 Thread Harshitha Onkar
On Fri, 10 Jun 2022 05:55:35 GMT, Harshitha Onkar wrote: > Due to incorrect AWT Frame inset values being returned from native code, few > of the components in the frame were not being shown completely on Windows. > With the proposed fix, correct insets are obtained which in turn sizes and > di

RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.

2022-06-09 Thread Harshitha Onkar
Due to incorrect AWT Frame inset values being returned from native code, few of the components in the frame were not being shown completely on Windows. With the proposed fix, correct insets are obtained which in turn sizes and displays the frame correctly. The default insets obtained from the W