On Mon, 23 May 2022 17:20:38 GMT, Alisen Chung <[email protected]> wrote:
>> Srinivas Mandalika has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Review comments fixed: Fixed file path, removed redundant sleep call etc.
>> - Review comments fixed: Removed file under the 'bug id' folder structure
>
> test/jdk/javax/swing/JSpinner/JSpinnerFocusTest.java line 69:
>
>> 67: try {
>> 68: SwingUtilities.invokeAndWait(() -> createGUI());
>> 69: Thread.sleep(1000);
>
> Would it be better to make robot a global variable and use
> Robot.waitForIdle() here? Sleeping might slow down the test unnecessarily
Fixed as suggested.
> test/jdk/javax/swing/JSpinner/JSpinnerFocusTest.java line 71:
>
>> 69: Thread.sleep(1000);
>> 70: runTest();
>> 71: Thread.sleep(1000);
>
> same here
Fixed as suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8546
