Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-10 Thread Calin A. Culianu
On Thu, 10 Mar 2005, Andy Fiddaman wrote: Not entirely, I just felt that since I made the point about portability and setenv I should at least bother to read the patch!.. although, I do use ClamAV on Solaris so I have an interest... :) ; Please advice what to do about m*alloc() considering it's ca

Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-10 Thread Andy Fiddaman
Calin A. Culianu wrote: ; Ah. So you are simply a keen programmer that wants to make sure no broken ; code gets into clamav? :) Not entirely, I just felt that since I made the point about portability and setenv I should at least bother to read the patch!.. although, I do use ClamAV on Solaris so

Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-10 Thread Calin A. Culianu
On Thu, 10 Mar 2005, Andy Fiddaman wrote: ; ; Hmm. Well, why do other parts of the clamd program then call mcalloc() (which ; is just a wrapper to malloc)? I would use cli_malloc but I am not even sure ; that header is visible to clamd (it's libclamav/others.h). ; ; Also, if I fix my code, the p

Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-10 Thread Andy Fiddaman
On Wed, 9 Mar 2005, Calin A. Culianu wrote: ; ; ; On Wed, 9 Mar 2005, Andy Fiddaman wrote: ; ; > This is looking good, just one problem and one comment. ; > ; > mcalloc() is unfortunately not portable, it's probably best that you use the ; > ClamAV library function cli_malloc() for consistency. ;

Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-09 Thread Calin A. Culianu
On Wed, 9 Mar 2005, Andy Fiddaman wrote: This is looking good, just one problem and one comment. mcalloc() is unfortunately not portable, it's probably best that you use the ClamAV library function cli_malloc() for consistency. Hmm. Well, why do other parts of the clamd program then call mcalloc(

Re: [Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-09 Thread Andy Fiddaman
On Wed, 9 Mar 2005, Calin A. Culianu wrote: ; Argh, my last two patches are bad. This one should work fine. Tomasz: Please ; use this one and disregard the last two I sent. This one is 100% correct -- ; the other one had a problem with its use of putenv(). ; ; Sheesh putenv() is a retarded funct

[Clamav-devel] UPDATED Patch for environment variable addition to virusaction

2005-03-09 Thread Calin A. Culianu
Argh, my last two patches are bad. This one should work fine. Tomasz: Please use this one and disregard the last two I sent. This one is 100% correct -- the other one had a problem with its use of putenv(). Sheesh putenv() is a retarded function! :) diff -ur clamav-devel/clamd/clamuko.c clama