On Wed, 9 Mar 2005, Calin A. Culianu wrote: ; Argh, my last two patches are bad. This one should work fine. Tomasz: Please ; use this one and disregard the last two I sent. This one is 100% correct -- ; the other one had a problem with its use of putenv(). ; ; Sheesh putenv() is a retarded function! :)
Yep ;) This is looking good, just one problem and one comment. mcalloc() is unfortunately not portable, it's probably best that you use the ClamAV library function cli_malloc() for consistency. Your 'desc->buflen = len;' would be better placed inside the previous block, otherwise if you get a long variable then a short one then one in between, an unecessary memory allocation will be performed. HTH, A. _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html
