On Wed, 9 Mar 2005, Calin A. Culianu wrote: ; ; ; On Wed, 9 Mar 2005, Andy Fiddaman wrote: ; ; > This is looking good, just one problem and one comment. ; > ; > mcalloc() is unfortunately not portable, it's probably best that you use the ; > ClamAV library function cli_malloc() for consistency. ; ; Hmm. Well, why do other parts of the clamd program then call mcalloc() (which ; is just a wrapper to malloc)? I would use cli_malloc but I am not even sure ; that header is visible to clamd (it's libclamav/others.h). ; ; Also, if I fix my code, the problem still remains that other parts of clamd ; use mcalloc(). :(
Sorry, my mistake - you're right, mcalloc() is there in shared/memory.c but it is only used by the utilities, not by any file in libclamav/ so I think it's still right to change to cli_malloc(). ; Attached is my updated patch.. btw Andy, do you have CVS access to apply it or ; do I need to re-email Tomasz explicitly? No I don't, one of the developers will need to apply it. A. _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html
