[PATCH] D64321: [OpenCL] Change diagnostic for function declaration

svenvh abandoned this revision. svenvh added a comment. Abandoning after an offline discussion with @Anastasia. Overloading is not a feature of OpenCL C in the first place so adding complexity to Clang isn't really justifiable. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4106 + NewToType = Context.getAddrSpaceQualType(NewToType, + FromPteeType.getAddressSpace()); + if (ToType->is

[PATCH] D82313: [OpenCL] Reject block arguments

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. OpenCL 2.0 does not allow block arguments, primarily because it is difficult to support function pointers on the various architectures that OpenCL targets. Clang was still accepting them. Rename

[PATCH] D82313: [OpenCL] Reject block arguments

svenvh updated this revision to Diff 273253. svenvh added a comment. Add test case with a block as a parameter of another block. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/ https://reviews.llvm.org/D82313 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D82313: [OpenCL] Reject block arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd46a56474d3: [OpenCL] Reject block arguments (authored by svenvh). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007356 , @Anastasia wrote: > Originally we didn't want to include the header by default for 2 reasons: > > 1. Many vendors used their own header. > 2. It takes long time to parse the header. > > However, we might be in

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007643 , @Anastasia wrote: > > Would it not become confusing since the builtins are going to be included > > by default? Should we rename the flag at least? Also ideally it should be > > documented in https://clang.llvm

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

svenvh accepted this revision. svenvh added a comment. LGTM, but just wondering if the test actually belongs to this patch, as it doesn't demonstrate the problem without one of your other patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83325

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

svenvh created this revision. Herald added a subscriber: nhaehnle. Commit 7ac28eb0a5 / r310911 ("[OpenCL] Allow targets to select address space per type", 2017-08-15) made Basic depend on AST, introducing a circular dependency. Break this dependency by adding the OpenCLTypeKind enum in Basic and

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

svenvh added a comment. Following up on the layering violation in https://reviews.llvm.org/D40838 Repository: rL LLVM https://reviews.llvm.org/D33989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

svenvh updated this revision to Diff 125554. svenvh added a comment. Introducing ASTContext::getOpenCLTypeAddrSpace(const Type *T) as suggested. https://reviews.llvm.org/D40838 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp lib/Basic/Target

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

This revision was automatically updated to reflect the committed changes. Closed by commit rL319883: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D40838?vs=125554&id=125682#toc Repository: rL LLVM https://r

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

This revision was automatically updated to reflect the committed changes. Closed by commit rC319883: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace (authored by svenvh). Repository: rC Clang https://reviews.llvm.org/D40838 Files: include/clang/AST/ASTContext.h include/clang/Bas

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG663e47a50f50: [OpenCL] Reduce emitting candidate notes for builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d421e6e3b78: [OpenCL] Remove half scalar vload/vstore builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128434/new/ https://revi

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8e658ec9ff5: [OpenCL] Remove fast_ half geometric builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128436/new/ https://reviews.

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh updated this revision to Diff 417678. svenvh added a comment. Herald added a subscriber: Naghasan. Herald added a project: All. Rebased on latest `main`. Also takes TypeExtensions into account now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104040/new/ https://reviews.llvm.or

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Align with the `-fdeclare-opencl-built

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3419221 , @hvdijk wrote: > This was worked around by modifying tests, but I believe this is a > fundamental problem in this change and was able to reproduce the error with > plain old clang: > > $ cat test.cl > voi

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. I've submitted the fix in `4dfec37037f5`. As for testing, unfortunately I couldn't just extend the `SemaOpenCL/fdeclare-opencl-builtins.cl` test: the OpenCL 1.2 RUN lines explicitly disable the `cl_intel_subgroups` extension (which is the extension that brings in `sub_g

[PATCH] D106267: [OpenCL] Add cl_khr_extended_bit_ops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG724f0e2abb0c: [OpenCL] Add cl_khr_extended_bit_ops (authored by svenvh). Herald added subscribers: cfe-commits, ldrumm. Repository: rG LLVM Github

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

svenvh created this revision. svenvh added reviewers: Anastasia, stuart. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins defined by Section 42 "Integer dot product" in the Op

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

svenvh added a comment. LGTM, just a small question. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL10 // RUN: %clang_cc1 %s -triple "spir-un

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

svenvh accepted this revision. svenvh added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG989bedec7a6a: [OpenCL] Add cl_khr_integer_dot_product (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

svenvh added a comment. In D106785#2904619 , @Anastasia wrote: > I would like @svenvh to take a look from the clang header's design point. Looks okay to me. Comment at: clang/docs/LanguageExtensions.rst:1980 +__private T var2; //

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ee0afc6739: [OpenCL] opencl-c.h: Add const to get_image_num_samples (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122728/new/ https:

[PATCH] D119011: [clang] Cache OpenCL types

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 __

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). --

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the atomic overloads for the `global` and `local` addr

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh added a comment. In D119398#3310746 , @Anastasia wrote: > This might interfere with https://reviews.llvm.org/D119420 Yes it will conflict. Atomic doubles are not guarded properly for other builtins (outside of the `cl_ext_float_atomics` extensio

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh accepted this revision. svenvh added a comment. Thanks, LGTM! I'll try to followup with the .td changes soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 __

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f8abb9f40a: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119420?vs=407432&id=407813#toc Repository: rG LLVM

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added a comment. In D118605#3313990 , @Anastasia wrote: > In D118605#3313859 , @azabaznov > wrote: > >>> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >>> we need this check t

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:262 +- Added parsing support for optionality of device side enqueue and blocks (not + fully incomplete yet!). +- Added missing support for optionality of various builtin functions: incomplete

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

svenvh added a comment. In D119560#3322531 , @Anastasia wrote: >> also makes the header no longer "claim" the identifiers "success", >> "failure", "desired", "value" (such that you can compile with -Dvalue=... >> when including the header for example, whi

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, just suggesting a minor textual improvement that can be made at commit time. Comment at: clang/docs/UsersManual.rst:3063 -There is ongoing support for OpenCL v3.0 th

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, overloads with a 64-bit atomic type argument we

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh added a comment. In D119858#3323565 , @Anastasia wrote: > LGTM! Thanks! > > I imagine this is another change to align with `opencl-c.h`? Yes. This addresses the issue of D119398 for tablegen (although the proble

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rG477bc8e8b931: [OpenCL] Guard atomic_double with cl_khr_int64_* (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119398?vs=407506&id=409179#toc Repository: rG LLVM Github Monor

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9798b33d1dc1: [OpenCL] Guard 64-bit atomic types (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Most places already seem to use the short spelling instead of 'unsi

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins for the new OpenCL ex

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM; just a few minor suggestions that you can address at commit time. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh updated this revision to Diff 428652. svenvh added a comment. Added macro and macro test. Added reference to Extension spec section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.llvm.org/D124256 Files: clang/lib/Headers/opencl-c-base.h clang/lib

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh added a comment. In D124256#3474043 , @Anastasia wrote: > LGTM! I imagine tablegen side is being tested automatically? The TableGen definitions are tested by `clang/test/Headers/opencl-builtins.cl` > Btw do we need to set the feature macro for SP

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The vload*_half* and vstore*_half* bui

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

svenvh updated this revision to Diff 428952. svenvh added a comment. Add test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://reviews.llvm.org/D125401 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Sema/OpenCLBuiltins.td clang/test/SemaOpenCL/half.cl

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGb250cca11d59: [OpenCL] Do not guard vload/store_half builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://review

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c29a8ae053: [OpenCL] Add cl_khr_subgroup_rotate builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.l

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `err_typecheck_call_too_few_args diagnostic` takes arguments, but none were provided causing clang to crash when attempting to diagnose an enqueue_kernel cal

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

This revision was automatically updated to reflect the committed changes. Closed by commit rL370322: [OpenCL] Fix diagnosing enqueue_kernel call with too few args (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

svenvh added a comment. Shared library builds seem to be broken indeed. I tried fixing by adding `Support` and `clangAST` as dependencies for `clangInterp`, but that creates a cyclic dependency between `clangAST` <-> `clangInterp`. Which makes me wonder whether `clangInterp` should be a separ

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

svenvh updated this revision to Diff 110947. svenvh edited the summary of this revision. svenvh added a comment. Herald added a subscriber: nhaehnle. Apologies for the late followup! Rebased the patch and addressed your comments. https://reviews.llvm.org/D33989 Files: include/clang/Basic/Tar

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

svenvh marked 2 inline comments as done. svenvh added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} yaxunl wrote: > Anastasia wrote: > > bader wrote: > > > yaxunl wrote: > > > > bader wrote:

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

This revision was automatically updated to reflect the committed changes. Closed by commit rL310911: [OpenCL] Allow targets to select address space per type (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D33989?vs=110947&id=37#toc Repository: rL LLVM https://rev

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72076/new/ https://reviews.llvm.org/D72076 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

svenvh added a comment. This change seems to be causing a problem with the nightly packages from apt.llvm.org. CMake Error at /usr/lib/llvm-10/lib/cmake/llvm/LLVMExports.cmake:1357 (message): The imported target "Bye" references the file "/usr/lib/llvm-10/lib/libBye.a"

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Nice catch, LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72707/new/ https://reviews.llvm.org/D72707 _

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:267 -... +- Added `cl_khr_extended_subgroup` to clang and the internal header. + cl_khr_extended_subgroups (ends with -s)? But isn't it supposed to be `cl_khr_subgroup_extensions`? I am real

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D90766: [OpenCL] Support vec_step in C++ for OpenCL mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: dexonsmith, yaxunl. svenvh requested review of this revision. For compatibility with OpenCL C, enable the `vec_step` builtin in C++ for OpenCL mode. https://reviews.llvm.org/D90766 Files: clang/includ

[PATCH] D90766: [OpenCL] Support vec_step in C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac9bcc746b9: [OpenCL] Support vec_step in C++ for OpenCL mode (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90766/new/ https://review

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. The argument to the `vec_step` builtin is not evaluated. Hoist the diagnostic for this in `Sema::CheckUnaryExprOrTypeTraitO

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh updated this revision to Diff 305058. svenvh added a comment. Add test case for OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91348/new/ https://reviews.llvm.org/D91348 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/corou

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

svenvh created this revision. svenvh added reviewers: Anastasia, mantognini. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. opencl-c.h disables all extensions at its end, but opencl-c-base.h does not, and that causes any inclusion of onl

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c690018ad1: [OpenCL] Stop opencl-c-base.h leaking extension enabling (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

svenvh added a comment. LGTM! I'd suggest waiting a bit before committing this though, to give people time to catch up on the RFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88300/new/ https://reviews.llvm.org/D88300 ___ cfe-commits mail

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. In D92004#2413603 , @Anastasia wrote: > @svenvh I imagine the testing functionality between the two headers will be > identical? Mostly, assuming you intend to test in the conventional way of feeding a .cl file to Clang. Althoug

[PATCH] D92033: [OpenCL] Move kernel arg type tests into one file

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. Keep all kernel parameter type diagnostic tests in `invalid-kernel-parameters.cl`. Repository: rG LLVM Github Monorepo

[PATCH] D92033: [OpenCL] Move kernel arg type tests into one file

This revision was automatically updated to reflect the committed changes. Closed by commit rG633cae30599c: [OpenCL] Move kernel arg type tests into one file (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92033/new/ https://revie

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. The restriction on pointer-to-pointer kernel arguments has been relaxed in OpenCL 2.0. Apply the same address space restric

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. > I am still unclear what should we do with testing though. We probably don't want to hold up this patch until we have more thorough testing in place, since we don't even have any concrete plans for such testing at the moment. Perhaps we should just land the patch once

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh updated this revision to Diff 308075. svenvh added a comment. Recursively call `getOpenCLKernelParameterType` to check address spaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92091/new/ https://reviews.llvm.org/D92091 Files: clang/l

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8638 // array, this recursive call only happens once. return getOpenCLKernelParameterType(S, QualType(UnderlyingTy, 0)); } Anastasia wrote: > Btw I am surprised that we recurse to

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:13 kernel void no_ptrptr(global int * global *i) { } +kernel void no_ptrptrptr(global int * global * global *i) { } Anastasia wrote: > Btw this was missing in the orig

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. >> We probably don't want to hold up this patch until we have more thorough >> testing in place, since we don't even have any concrete plans for such >> testing at the moment. > > Well accepting such a significant change that implements the entire > functionality of a ne

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG523775f96742: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2 (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D92091?vs=308075&id=308607#toc Repository: rG LLVM Gi

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. These cases weren't in any of the SemaOpenCL tests yet. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec61889214d: [OpenCL] Add some more kernel argument tests (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

svenvh accepted this revision. svenvh added a comment. LGTM. I also checked that this brings `Index.h` back in sync with `bindings/python/clang/cindex.py` again. We are not exposing `CXCursor_CXXAddrspaceCastExpr` through the python bindings, but some other values are missing too so that's bey

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101843/new/ https://reviews.llvm.org/D101843 ___ cfe-commits mailing list cfe-commits@

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh updated this revision to Diff 347428. svenvh edited the summary of this revision. svenvh added a comment. Fix formatting issues, rebase patch, add test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 Files: clang/test/Headers/lit.local

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:22 +extern generic float g_generic_extern_var; +#ifndef __opencl_c_program_scope_global_variables +// expected-error@-17 {{program scope variable must reside in constant address space}} -

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the `memory_scope_all_devices` enum value, which is restri

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348245. svenvh edited the summary of this revision. svenvh added a comment. Update change to be header-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h clan

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTIONA

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348309. svenvh added a comment. Restrict feature macro definition to SPIR target only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h clang/test/Headers/opencl-

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

svenvh added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space");

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

svenvh added a comment. > I also added a new test file to check the output AST. If there's a better > place for this test I will move it there. If you're primarily interested in the AST, then it doesn't have to be a Sema test I guess. In that case `clang/test/AST` seems to be a better place, a

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103252/new/ https://reviews.llvm.org/D103252 ___ cfe-commits mailing list cfe-commits@

[PATCH] D95135: Fix signedness in vector bitcast evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14947cd04701: [clang] Fix signedness in vector bitcast evaluation (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95135/new/ https://rev

[PATCH] D95061: [OpenCL][Docs] Moved information about internals from UsersManual into OpenCLSupport

svenvh added a comment. Please build the docs and check the build log, as you might break some references? Comment at: clang/docs/UsersManual.rst:2951 address space map can be added using the :ref:`-ffake-address-space-map ` flag. Is this a dead refere

[PATCH] D95061: [OpenCL][Docs] Moved information about internals from UsersManual into OpenCLSupport

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM then, thanks! Comment at: clang/docs/UsersManual.rst:2951 address space map can be added using the :ref:`-ffake-address-space-map ` flag. Anasta

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the `cl_khr_subgroup_ballot` extension to `-fde

[PATCH] D95616: Change extension handling for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, the `-fdeclare-opencl-builtins` option behaved differently compared t

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh updated this revision to Diff 319860. svenvh added a comment. Add test after rebasing on dependent commit (D95616 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95523/new/ https://reviews.llvm.org/D95523

<    1   2   3   4   5   >