[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

0x59616e added a comment. I can only nitpick some of the peripheral issues since I have no knowledge in most of the part of clang. Perhaps implementing the new standard feature is too arduous for a tyro like me. It's great to see the real expert to complete this. Comment at:

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

0x59616e added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6114-6116 +// const ValueDecl *VD = Entity.getDecl(); +// if (const VarDecl *VarD = dyn_cast_or_null(VD); +// VarD && VarD->hasInit() && !VarD->getInit()->containsErrors()) ---

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. The pre-merge checks seem to have some issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___ cfe-commits mailing list cfe-commit

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. Also, could you add "Fixes #58974" in the commit message so that the item will be closed automatically upon commiting ? Thtanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 _

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e accepted this revision. 0x59616e added a comment. The CI seems OK. My first LGTM is given to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___ c

[PATCH] D126947: [clang][doc][NFC] Update get_started.html

0x59616e created this revision. Herald added a project: All. 0x59616e requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -cc1 is replaced by -Xclang. Update get_started.html to reflect this change. Repository: rG LLVM Github Monorepo http

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

0x59616e added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

0x59616e requested changes to this revision. 0x59616e added a comment. This revision now requires changes to proceed. A few minor adjustments are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143529/new/ https://reviews.llvm.org/D143529

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

0x59616e accepted this revision. 0x59616e added a comment. This revision is now accepted and ready to land. Shoot. I mixed it up with my own one. I'm sorry. I can't find any isseu in this patch and it LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D151062: [clang][Sema] Fix a crash when instantiating a non-type template argument in a dependent scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcde139016a4e: [clang][Sema] Fix a crash when instantiating a non-type template argument in a… (authored by 0x59616e). Herald added a project: clang.

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e accepted this revision. 0x59616e added a comment. This revision is now accepted and ready to land. Though creating our own calling convention is better, I think Min's path is correct at this moment given that m68k is still an experimental target. We can reignite this discussion once we'

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:559 +emitError |= DefaultCC == LangOptions::DCC_StdCall && + !(Arch == llvm::Triple::m68k || Arch == llvm::Triple::x86); emitError |= (DefaultCC == LangOptions::DCC_Vect

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e added inline comments. Comment at: clang/test/CodeGen/mrtd.c:9 +// X86: define{{.*}} x86_stdcallcc void @foo(i32 noundef %arg) [[NUW:#[0-9]+]] +// M68k: define{{.*}} cc104 void @foo(i32 noundef %arg) void foo(int arg) { 0x59616e wrote: > Just curious, w

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e added a comment. I didn't see any issue here. Let's wait for the approval from other (more senior) reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cf

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

0x59616e added a comment. LGTM. Thanks ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co