Author: compnerd
Date: Sun Apr 30 19:26:59 2017
New Revision: 301783
URL: http://llvm.org/viewvc/llvm-project?rev=301783&view=rev
Log:
utils: Silence -Wpedantic warning
llvm/tools/clang/utils/TableGen/ClangAttrEmitter.cpp:1673:67: warning: default
argument specified for lambda parameter [-Wpedan
Author: compnerd
Date: Thu May 4 14:18:21 2017
New Revision: 302184
URL: http://llvm.org/viewvc/llvm-project?rev=302184&view=rev
Log:
Driver: only inject libstdc++ paths when needed on CrossWindows
When building with libc++ don't bother with injecting the libstdc++
search paths into the linker s
Author: compnerd
Date: Fri May 5 13:39:06 2017
New Revision: 302270
URL: http://llvm.org/viewvc/llvm-project?rev=302270&view=rev
Log:
CodeGen: avoid use of @clang.arc.use intrinsic at O0
The clang.arc.use intrinsic is removed via the ARC Contract Pass. This
pass is only executed in optimized bu
Author: compnerd
Date: Mon Oct 24 15:47:58 2016
New Revision: 285023
URL: http://llvm.org/viewvc/llvm-project?rev=285023&view=rev
Log:
CodeGen: centralise label construction for method lists
Move all the label construction for the various method list emission into
EmitMethodList. Rather than hav
Author: compnerd
Date: Mon Oct 24 16:25:57 2016
New Revision: 285028
URL: http://llvm.org/viewvc/llvm-project?rev=285028&view=rev
Log:
CodeGen: remove incorrect temporary Twine
Twines should not be stack allocated. This somehow managed to get past me.
Modified:
cfe/trunk/lib/CodeGen/CGObjCM
Author: compnerd
Date: Tue Oct 25 09:50:44 2016
New Revision: 285073
URL: http://llvm.org/viewvc/llvm-project?rev=285073&view=rev
Log:
CodeGen: mark protocols as common data
This allows for the coalescing of the protocol declarations. When the protocols
are declared in headers, multiple definiti
Author: compnerd
Date: Tue Oct 25 16:43:28 2016
New Revision: 285126
URL: http://llvm.org/viewvc/llvm-project?rev=285126&view=rev
Log:
CodeGen: be more conservative about setting section
The section names currently are MachO specific. Only set the section on the
variables if the file format is M
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
It would be nice if there is a simple way to handle the possible performance
impact for python 2. Worst case, we can deal with it when it becomes an issue.
Comment at:
Author: compnerd
Date: Sun Nov 13 19:55:54 2016
New Revision: 286788
URL: http://llvm.org/viewvc/llvm-project?rev=286788&view=rev
Log:
__cxa_demangle: ensure that we have a mangled symbol
Ensure that we have a mangled symbol before attempting to demangle it. We would
previously treat any input a
Author: compnerd
Date: Sun Nov 13 21:07:47 2016
New Revision: 286793
URL: http://llvm.org/viewvc/llvm-project?rev=286793&view=rev
Log:
__cxa_demangle: allow demangling invocation blocks
The block invocation function uses an extension where the prefix is ___Z
as opposed to _Z. This should make th
compnerd added a subscriber: compnerd.
compnerd added a comment.
While I agree that this makes the option much nicer to use, it collides with
the -l flag. Since it was an internal only option until this point, we should
rename it before exposing it at the driver level.
Repository:
rL LLVM
compnerd added a comment.
Do you know if GCC requires the = or can you do -fplugin name.so ?
Repository:
rL LLVM
http://reviews.llvm.org/D12903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: compnerd
Date: Fri Sep 18 00:32:23 2015
New Revision: 247967
URL: http://llvm.org/viewvc/llvm-project?rev=247967&view=rev
Log:
Driver: avoid unnecessary string based operations
Use an enumeration and change the use of the FloatABI from a string to the
enumeration. This avoids the use of
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Looks fine minus the one thing that needs a quick look at.
Comment at: include/clang/Driver/Options.td:952
@@ -951,1 +951,3 @@
def fn
Author: compnerd
Date: Fri Sep 18 23:33:38 2015
New Revision: 248083
URL: http://llvm.org/viewvc/llvm-project?rev=248083&view=rev
Log:
Driver: avoid unnecessary string ops
Use an enumeration for the Floating Point ABIs supported on MIPS. This is
replicating the ARM change to avoid string based t
Author: compnerd
Date: Sat Sep 19 13:19:44 2015
New Revision: 248094
URL: http://llvm.org/viewvc/llvm-project?rev=248094&view=rev
Log:
Driver: tweak ARM target feature calculation
Rather than using re-calculating the effective triple, thread the already
calculated value down into AddARMTargetArgs
Author: compnerd
Date: Sat Sep 19 15:40:16 2015
New Revision: 248095
URL: http://llvm.org/viewvc/llvm-project?rev=248095&view=rev
Log:
Driver: alter the getARMFloatABI signature
This changes getARMFloatABI to use the ToolChain and Args instead of Driver,
Args, Triple. Although this pushes the Tr
compnerd created this revision.
compnerd added a reviewer: rengolin.
compnerd added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
ARM EABI adds target attributes to the object file. Amongst the attributes that
are emitted is the VFP argu
Author: compnerd
Date: Sat Sep 19 21:08:31 2015
New Revision: 248108
URL: http://llvm.org/viewvc/llvm-project?rev=248108&view=rev
Log:
EH: fix register usage for SjLj
When using SjLj EH, do not use __builtin_eh_return_regno, map directly to the
ID. This would work on some targets, particularly t
compnerd added a comment.
Yeah, I realize that we will need that part of the change as well. However, I
think that this is a sufficiently standalone piece that we can merge this first.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
cf
compnerd added a comment.
It would fail to link previously anyways, since as Renato correctly explained,
you would have objects that were built with the soft float attribute, and then
were linking against hard float built object.
http://reviews.llvm.org/D12996
__
Author: compnerd
Date: Fri Sep 25 22:26:44 2015
New Revision: 248649
URL: http://llvm.org/viewvc/llvm-project?rev=248649&view=rev
Log:
Driver: support ARM/HF on a single toolchain
ARM EABI adds target attributes to the object file. Amongst the attributes that
are emitted is the VFP argument pass
compnerd added a comment.
While I can certainly appreciate the simplification this may afford, Im not
sure if adding a new option here is really that valuable. Options being added
to the frontend are expensive because they can't be changed or removed. If gcc
has a similar frontend option, we
compnerd added a comment.
Ah. Well, Im tempted to say that we should avoid the option. Generally,
making the backend options visible is undesirable since there is no guarantee
of stability there. This simplifies that, and if users start using that, we
would not be able to change those as eas
compnerd added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'
compnerd added inline comments.
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+ else if (Args.hasArg(options::OPT_fno_declspec))
+CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
@rsmith, so they are. I misread something and wa
Author: compnerd
Date: Fri Oct 2 22:39:28 2015
New Revision: 249227
URL: http://llvm.org/viewvc/llvm-project?rev=249227&view=rev
Log:
Driver: follow WoA ABI recommendations
The Windows on ARM ABI recommends that FPO be disabled. This is since the
Windows on ARM ABI uses the FP for fast stack wa
Author: compnerd
Date: Sat Oct 3 01:37:38 2015
New Revision: 249229
URL: http://llvm.org/viewvc/llvm-project?rev=249229&view=rev
Log:
try to fix the ARM self host bots
The default target is ARM on the ARM self host bots. This is problematic since
the behaviour on x86, x64 is different from ARM.
Author: compnerd
Date: Sat Oct 3 02:15:28 2015
New Revision: 249232
URL: http://llvm.org/viewvc/llvm-project?rev=249232&view=rev
Log:
fix previous commit
Forgot to add the '='. In cl mode, --target must have an '='.
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Dri
Author: compnerd
Date: Sun Oct 4 12:51:05 2015
New Revision: 249279
URL: http://llvm.org/viewvc/llvm-project?rev=249279&view=rev
Log:
Add -f[no-]declspec to control recognition of __declspec as a keyword
In versions of clang prior to r238238, __declspec was recognized as a keyword in
all modes.
compnerd closed this revision.
compnerd added a comment.
Committed as SVN r249279 (as per your request in the initial revision).
http://reviews.llvm.org/D13322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
compnerd added a subscriber: compnerd.
compnerd added a comment.
Why add docs for these but not the others around it?
http://reviews.llvm.org/D11773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you need this committed on your behalf?
http://reviews.llvm.org/D11772
___
Author: compnerd
Date: Tue Aug 11 22:21:44 2015
New Revision: 244715
URL: http://llvm.org/viewvc/llvm-project?rev=244715&view=rev
Log:
libclang: Add period to typedef kind docblock
All of the other docblocks for the CXCursor_* cursor kind enum values
include documentation that ends with a period.
compnerd closed this revision.
compnerd added a comment.
Committed as SVN r244715.
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
Okay, if thats the general pattern, then we can stick it in the triple.
Though, that means that the use of the triple for determining the MS
compatibility needs to be undone. If the version in the triple is the libc
version, then it can differ from the MS compatibili
compnerd added a comment.
AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into
the ucrt. msvcrt is the "shared" common bits, while the ucrt is more
"platform" specific bits.
But really, the point is: supporting an older version with a newer compiler is
what doing this
Author: compnerd
Date: Thu Aug 20 22:21:31 2015
New Revision: 245665
URL: http://llvm.org/viewvc/llvm-project?rev=245665&view=rev
Log:
unwind: fix invalid memory access
Fix out-of-bounds array access when setting arm float registers.
Patch by Leandro Graciá Gil!
Modified:
libunwind/trunk/sr
On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote:
> +Saleem and Renato; maybe you can take a look?
Thanks for pointing this out!
The patch is correct and pretty safe to apply for 3.7 I think since its a
simple bug fix, and can result in VFP state corruption (the invalid memory
access in th
On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote:
> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
> wrote:
> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg
> wrote:
> >>
> >> +Saleem and Renato; maybe you can take a look?
> >
> >
> > Thanks for pointing this out!
> >
> > The patch
compnerd added a subscriber: compnerd.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
Why does this need a builtin? Is an inline assembly block using lgdt
insuff
compnerd added inline comments.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
mkuper wrote:
> compnerd wrote:
> > Why does this need a builtin? Is an inline asse
compnerd added a comment.
While I can see the argument you raise, the saving grace here is that this is
buried in libc++abi. The only real piece of libc++abi of real use to users is
`__cxa_demangle` (which is only relevant for Windows, and Darwin where you have
two level namespaces). For ever
Author: compnerd
Date: Mon Aug 31 23:29:03 2015
New Revision: 246528
URL: http://llvm.org/viewvc/llvm-project?rev=246528&view=rev
Log:
unwind: cleanup -Wunused-parameter
Cleanup a number of `-Wunused-parameter` warnings. NFC.
Modified:
libunwind/trunk/src/Registers.hpp
Modified: libunwind/
compnerd created this revision.
compnerd added reviewers: rafael, rnk.
compnerd added a subscriber: cfe-commits.
Simplify the mangling handling. This allows for the correct handling of extern
"C" symbols in C++ input. The observable difference with this simplification
that additional symbols ar
compnerd added inline comments.
Comment at: lib/AST/Mangle.cpp:191
@@ -199,3 +190,3 @@
else
-Out << "_block_invoke_" << discriminator+1;
+Out << "_block_invoke_" << discriminator + 1;
}
Drive by reformat.
Comment at: test/CodeGen/pr96
compnerd added inline comments.
Comment at: lib/AST/Mangle.cpp:139
@@ -149,2 +138,3 @@
- Out << '\01';
+ // shouldMangleCXXName lies sometimes for the MS-ABI, so check the CC
mangling
+ // when targeting MS-ABI (it doesnt consider CC which take precedence over
--
Author: compnerd
Date: Sat Sep 5 13:53:43 2015
New Revision: 246931
URL: http://llvm.org/viewvc/llvm-project?rev=246931&view=rev
Log:
Index: expose visibility attribute
Expose the previously unexposed visibility attribute via the python and C
bindings.
Added:
cfe/trunk/test/Index/visibility
On Fri, Sep 4, 2015 at 1:11 AM, Xan López via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> > There is no __cxa_finalize symbol available on recent Solaris OS
> > versions, so we need this flag to make non trivial C+
On Fri, Sep 4, 2015 at 1:12 AM, Xan López via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote:
> > This is actually needed, otherwise libc won't be added at all. For
> > instance when building libclang.so all the libc sym
On Mon, Sep 7, 2015 at 7:18 AM, Xan López wrote:
> On Sat, Sep 05, 2015 at 12:28:43PM -0700, Saleem Abdulrasool wrote:
> > > Ping?
> > >
> >
> > Testcase? Looks fine otherwise.
>
> Basically check that -lc is present when clang is called in a certain
> way I guess? Or something more sophisticate
On Mon, Sep 7, 2015 at 2:28 AM, Xan López wrote:
> On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote:
> > > Ping?
> > >
> >
> > Does this break with older Solaris releases? How far back did this
> change
> > in Solaris? The change itself should really be accompanied with a test
compnerd added a comment.
While I think that ensuring that the fallback malloc path works properly is
needed, AIUI, this is still insufficient, as there is a first attempt at using
malloc, which doesn't have alignment guarantees (except on Darwin). Also, a
clang-format over the patch would be
On Mon, Sep 7, 2015 at 10:34 AM, Xan López wrote:
> OK! So here's the patch with a test.
The patch LGTM with a minor request for tweaking the commit message to have
the context about the fact that cxa_finalize.o never shipped, and so this
doesn't really cause any problems for older releases.
On Mon, Sep 7, 2015 at 10:42 AM, Xan López wrote:
> On Mon, Sep 07, 2015 at 10:38:08AM -0700, Saleem Abdulrasool wrote:
> > The patch LGTM with a minor request for tweaking the commit message to
> have
> > the context about the fact that cxa_finalize.o never shipped, and so this
> > doesn't reall
Author: compnerd
Date: Sun Oct 11 22:10:20 2015
New Revision: 250008
URL: http://llvm.org/viewvc/llvm-project?rev=250008&view=rev
Log:
bindings: add new C++ function attribute accessors
Add methods to index Cursor to see if a cxx method is pure_virtual,
virtual or const methods.
Patch by Jonatha
Author: compnerd
Date: Mon Oct 12 15:21:08 2015
New Revision: 250094
URL: http://llvm.org/viewvc/llvm-project?rev=250094&view=rev
Log:
Support Debug Info path remapping
Add support for the `-fdebug-prefix-map=` option as in GCC. The syntax is
`-fdebug-prefix-map=OLD=NEW`. When compiling files f
Author: compnerd
Date: Mon Oct 12 16:19:30 2015
New Revision: 250112
URL: http://llvm.org/viewvc/llvm-project?rev=250112&view=rev
Log:
test: change argument
This failed on AArch64 due to the type mismatch using int instead of
__builtin_va_list.
Modified:
cfe/trunk/test/CodeGen/Inputs/stdio.h
Author: compnerd
Date: Mon Oct 12 16:19:27 2015
New Revision: 250111
URL: http://llvm.org/viewvc/llvm-project?rev=250111&view=rev
Log:
test: relax path matching for windows
The test failed on Windows due to use of \ as a path separator rather than /.
Modified:
cfe/trunk/test/CodeGen/debug-pr
On Thu, Oct 15, 2015 at 3:41 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Thu Oct 15 17:41:51 2015
> New Revision: 250469
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250469&view=rev
> Log:
> [libcxx] Make libc++.so a linker script by default
Author: compnerd
Date: Sun Oct 18 15:24:53 2015
New Revision: 250665
URL: http://llvm.org/viewvc/llvm-project?rev=250665&view=rev
Log:
CodeGen: simplify TargetOptions setup
Do direct assignment of boolean values and regroup. Use StringSwitch instead of
custom cases. NFC.
Modified:
cfe/trun
Author: compnerd
Date: Sun Oct 18 20:24:08 2015
New Revision: 250674
URL: http://llvm.org/viewvc/llvm-project?rev=250674&view=rev
Log:
docs: remote stale refs
Since the attribute documentation is now auto-generated, the previous references
are no longer valid. This prevented the docs build from
On Monday, October 26, 2015, Ariel Arelovich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi:
>
> Where I'm working I've been asked to look into developing a C (by this I
> mean C89 C standard) compiler a new processor architecture being created
> inhouse.
>
> On looking at the options a
Author: compnerd
Date: Tue Oct 27 10:50:22 2015
New Revision: 251410
URL: http://llvm.org/viewvc/llvm-project?rev=251410&view=rev
Log:
Index: expose is_mutable_field
Expose isMutable via libClang and python bindings.
Patch by Jonathan B Coe!
Modified:
cfe/trunk/bindings/python/clang/cindex.
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGAtomic.cpp:782
@@ +781,3 @@
+ LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy);
+ AtomicInfo At
Author: compnerd
Date: Tue Oct 27 23:45:58 2015
New Revision: 251493
URL: http://llvm.org/viewvc/llvm-project?rev=251493&view=rev
Log:
Driver: support -fuse-ld= on cross windows
Update the linker selection to support the `-fuse-ld=` option for selecting a
linker.
Added:
cfe/trunk/test/Driver
Author: compnerd
Date: Wed Oct 28 22:36:38 2015
New Revision: 251598
URL: http://llvm.org/viewvc/llvm-project?rev=251598&view=rev
Log:
Driver: tweak CrossWindows sanitizer support
Indicate support for ASAN on the CrossWindows toolchain. Although this is
insufficient, this at least permits the ha
Author: compnerd
Date: Wed Oct 28 22:36:45 2015
New Revision: 251600
URL: http://llvm.org/viewvc/llvm-project?rev=251600&view=rev
Log:
Driver: CrossWindows sanitizers link support
Add the required libraries to the linker invocation when building with
sanitizers.
Modified:
cfe/trunk/lib/Drive
Author: compnerd
Date: Wed Oct 28 22:36:42 2015
New Revision: 251599
URL: http://llvm.org/viewvc/llvm-project?rev=251599&view=rev
Log:
Driver: inline some small arrays
Use an initializer list to remove a couple of small static arrays. NFC.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified
Author: compnerd
Date: Wed Oct 28 22:52:14 2015
New Revision: 251603
URL: http://llvm.org/viewvc/llvm-project?rev=251603&view=rev
Log:
test: fix overzealous match
Accidentally made the test too strict.
Modified:
cfe/trunk/test/Driver/windows-cross.c
Modified: cfe/trunk/test/Driver/windows-c
compnerd created this revision.
compnerd added a reviewer: djasper.
compnerd added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Correct handling for C++17 inline namespaces. We would previously fail to
identify the inline namespaces as a namespace name since multiple ones may be
compnerd requested changes to this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision now requires changes to proceed.
Please add a unit test for this.
http://reviews.llvm.org/D14180
___
cfe-commits mailing list
c
Author: compnerd
Date: Fri Oct 30 00:07:56 2015
New Revision: 251690
URL: http://llvm.org/viewvc/llvm-project?rev=251690&view=rev
Log:
Format: support inline namespaces
Correct handling for C++17 inline namespaces. We would previously fail to
identify the inline namespaces as a namespace name si
compnerd added a comment.
This looks like what I had in mind wrt use of `-meabi`.
Comment at: lib/CodeGen/BackendUtil.cpp:524
@@ +523,3 @@
+ .Case("5", llvm::EABI::Eabi5)
+ .Case("gnu", llvm::EABI::Gnu)
+ .Default(llvm::EABI::Default);
I'd reall
compnerd closed this revision.
compnerd added a comment.
SVN r251690 with the mod.
http://reviews.llvm.org/D14188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Fri Oct 30 19:39:15 2015
New Revision: 251729
URL: http://llvm.org/viewvc/llvm-project?rev=251729&view=rev
Log:
Sema: correct typo recovery with blocks
Handle blocks in the tree transform for the typo correction as otherwise, the
capture may miss. This would trigger an ass
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Yeah, this is a COFF limitation. Its unfortunate we don't have a better way to
detect COFF targets.
http://rev
On Wednesday, November 4, 2015, Tamas Berghammer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> tberghammer created this revision.
> tberghammer added a reviewer: echristo.
> tberghammer added a subscriber: cfe-commits.
>
> Add new compiler flag to enable the generation of dwarf accelerato
compnerd added a comment.
Unfortunate that they have this crazy behavior.
Comment at: lib/CodeGen/CGAtomic.cpp:901
@@ -897,1 +900,3 @@
+ PostOp = llvm::Instruction::Add;
+// Fall through.
case AtomicExpr::AO__c11_atomic_fetch_add:
I think we should
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGAtomic.cpp:901
@@ -897,1 +900,3 @@
+ PostOp = llvm::Instruction::Add;
+// Fall through.
case AtomicExpr::AO__c11_atomic_fe
Author: compnerd
Date: Wed Nov 11 21:57:16 2015
New Revision: 252852
URL: http://llvm.org/viewvc/llvm-project?rev=252852&view=rev
Log:
libclang: add new StringSet type
This allows the return of a set of CXStrings from libclang. This is setup work
for an upcoming change to permit returning multip
Author: compnerd
Date: Wed Nov 11 21:57:22 2015
New Revision: 252853
URL: http://llvm.org/viewvc/llvm-project?rev=252853&view=rev
Log:
libclang: add clang_Cursor_getCXXManglings
This function permits the mangling of a C++ 'structor. Depending on the ABI and
the declaration, the declaration may c
compnerd added a comment.
-gnu implies GLIBC. Traditionally, -uclibc is used instead of -gnu for uclibc
environments, and many (most?) Linux distros use -musl to indicate a MUSL
environment. For Android, the environment is -android, and thus, assumed to be
bionic. If the OS is BSD, usually,
compnerd added a comment.
Yes, we *could*. Its just a matter of how it is being specified. I find that
having the separate option is potentially cleaner than stuffing it in the
triple (which does get pushed into the metadata), and then parsing it back out
as a value. I think that this is som
compnerd added inline comments.
Comment at: src/UnwindRegistersRestore.S:331
@@ +330,3 @@
+ ldr r4, [r0, #0x2c]
+ ldr r5, [r0, #0x30]
+ mov r8, r1
Is there a benefit to doing the explicit loading rather than a add + ldm?
Comment at: src/Unwind
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
@rnk, okay, that seems reasonable enough. Although, we should check to ensure
that the x64 toolchain is available and make a decision on that.
BTW, seems that I had missed the p
Author: compnerd
Date: Mon Jul 18 21:13:08 2016
New Revision: 275943
URL: http://llvm.org/viewvc/llvm-project?rev=275943&view=rev
Log:
clang-rename: fix referenced variable in vim-script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.py
Modified: clang-tools-extra/trunk/cla
Hey Hans,
I think that we should get this merged into 3.9. Its a trivial fix and
makes the script usable if you set g:clang_rename_path.
Thanks!
On Mon, Jul 18, 2016 at 7:13 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Mon
compnerd added a comment.
LGTM; we should make sure Nick is okay with it as well (for Darwin). This
should also make its way into 3.9 I think.
https://reviews.llvm.org/D22543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you have commit access?
https://reviews.llvm.org/D22712
___
cfe-commits mailing list
cfe-commits@list
Author: compnerd
Date: Tue Jul 26 23:43:15 2016
New Revision: 276836
URL: http://llvm.org/viewvc/llvm-project?rev=276836&view=rev
Log:
test: simplify commands, NFC
Rather than copying the file and then doing an in-place edit, perform the
replacements to stdout and pass the output to FileCheck dir
On Wed, Jul 27, 2016 at 5:53 AM, Martin Storsjö
wrote:
> mstorsjo created this revision.
> mstorsjo added a subscriber: cfe-commits.
> Herald added subscribers: samparker, rengolin, aemerson.
>
> This test uses an immediate constant, which was previously broken in
> inline assembly, prior to LLVM
Author: compnerd
Date: Wed Jul 27 19:42:01 2016
New Revision: 276948
URL: http://llvm.org/viewvc/llvm-project?rev=276948&view=rev
Log:
clang-rename: adjust NamedDeclFindingASTVisitor for RecordDecls
Ensure that Context is always properly initialised in the constructor. It is
used for querying th
Author: compnerd
Date: Wed Jul 27 19:43:14 2016
New Revision: 276949
URL: http://llvm.org/viewvc/llvm-project?rev=276949&view=rev
Log:
test: fix typo in file name (NFC)
Added:
clang-tools-extra/trunk/test/clang-rename/ClassNameInFunctionDefinition.cpp
- copied, changed from r276948,
cl
compnerd closed this revision.
compnerd added a comment.
SVN r276948
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Fri Jul 29 14:15:51 2016
New Revision: 277200
URL: http://llvm.org/viewvc/llvm-project?rev=277200&view=rev
Log:
CodeGen: try harder to make the CFString structure RW
The previous change was insufficient to mark the content as read-write as the
structure itself was marked co
Author: compnerd
Date: Mon Aug 1 16:31:24 2016
New Revision: 277390
URL: http://llvm.org/viewvc/llvm-project?rev=277390&view=rev
Log:
CodeGen: simplify the CC handling for TLS wrappers
Use the calling convention of the wrapper directly to set the calling convention
to ensure that the calling con
compnerd added inline comments.
Comment at: lib/Headers/armintr.h:26
@@ +25,3 @@
+#ifndef _MSC_VER
+#include_next
+#else
Hmm, why not do __has_header instead? armv7-windows-itanium won't define
`_MSC_VER` but you may have the header from the SDK.
https://revi
On Mon, Aug 1, 2016 at 9:36 AM, Alexander Kornienko
wrote:
> Please revert or fix (or better revert and then post another patch for
> review).
>
Kirill reverted it in SVN r277354.
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
___
cfe-commits
compnerd added a comment.
The `\01` is to prevent the mangler from touching the function name. If you
noticed the check tags in the quoted test, some targets expect it to be
decorated and others do not. What exactly do you mean that `lit` has a strings
matching with `\01`? Its not a string `
601 - 700 of 1042 matches
Mail list logo
