compnerd added inline comments. ================ Comment at: src/UnwindRegistersRestore.S:331 @@ +330,3 @@ + ldr r4, [r0, #0x2c] + ldr r5, [r0, #0x30] + mov r8, r1 ---------------- Is there a benefit to doing the explicit loading rather than a add + ldm?
================ Comment at: src/UnwindRegistersRestore.S:336 @@ +335,3 @@ + mov r11, r4 + mov r12, r5 + ldr r2, [r0, #0x34] ---------------- Any point of this restoration? It is IP scratch. ================ Comment at: src/UnwindRegistersSave.S:328 @@ +327,3 @@ + @ It is safe to use here though because we are about to return, and cpsr is + @ not expected to be preserved. + movs r0, #0 @ return UNW_ESUCCESS ---------------- Thanks for the comment here! https://reviews.llvm.org/D22292 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
