compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. This revision is now accepted and ready to land.
================ Comment at: lib/CodeGen/CGAtomic.cpp:782 @@ +781,3 @@ + LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy); + AtomicInfo Atomics(*this, AtomicVal); + ---------------- s/Atomics/AI/? Or perhaps Atomic? ================ Comment at: lib/CodeGen/CGAtomic.cpp:1021 @@ -1010,1 +1020,3 @@ + ResVal, + Builder.CreateBitCast(Dest, ResVal->getType()->getPointerTo())); } ---------------- It feels like it might be nice to hoist the `CreateBitCast`. Repository: rL LLVM http://reviews.llvm.org/D13874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits