[PATCH] D84005: Introduce ns_error_domain attribute.

MForster created this revision. MForster added reviewers: gribozavr2, milseman. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is chery-picked from https://github.com/llvm/llvm-project-staging/commit/a14779f504b02ad0e4dbc39d6d10

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 278724. MForster marked 4 inline comments as done. MForster added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/i

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done and an inline comment as not done. MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain"

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 278728. MForster marked an inline comment as not done. MForster added a comment. Fix diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2158019 , @gribozavr2 wrote: > Did your latest update unintentionally drop the test file > `clang/test/Analysis/ns_error_enum.m`? I'm struggling with arcanist :-). Fixed. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2158029 , @aaron.ballman wrote: > FWIW, this is *really* hard to review because it's not a diff against the > trunk and so it's not immediately clear what the actual changes are. > > The change is missing all of its te

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 279228. MForster marked 13 inline comments as done. MForster added a comment. - Run test also in C and C++ mode - Address more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://r

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; aaron.ballman wrote: > gribozavr2 wrote: > > aaron.ballm

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; MForster wrot

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280415. MForster marked 15 inline comments as done. MForster added a comment. Herald added a reviewer: jdoerfert. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://review

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2162433 , @aaron.ballman wrote: > It's a bit odd that this attribute has an AST node created for it but nothing > is using that AST node elsewhere in the project. Are there other patches > expected for making use of t

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a subscriber: doug.gregor. MForster added a comment. @milseman, @doug.gregor, could you please help with the open questions on this review? Specifically: - Is `ns_error_domain` ever needed for something other than an enum? - Why is this designed in the way it is (requiring an ide

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280804. MForster marked 8 inline comments as done. MForster edited the summary of this revision. MForster added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ htt

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. I have updated the attribute documentation to include the additional information provided by Doug. I think adding additional diagnostics would rather be separate changes. I think I have addressed all remaining review comments. Comment at: clang/lib/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280806. MForster added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280828. MForster marked 3 inline comments as done. MForster added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/inc

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/test/Sema/ns_error_enum.c:25 + +const char *MyErrorDomain; +typedef NS_ERROR_ENUM(unsigned char, MyErrorEnum, MyErrorDomain) { gribozavr2 wrote: > const char * => NSStrin

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280829. MForster marked an inline comment as done. MForster added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basi

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280831. MForster added a comment. Rename test back to ns_error_enum.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clan

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked 3 inline comments as done. MForster added a comment. Two clarifying questions... Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); aaron.ballm

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281525. MForster marked 4 inline comments as done. MForster added a comment. Store the VarDecl instead of the identifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); aaron.ballman wrote: > MForster wrote: > > aaron.ballman wrote: > > > Shouldn'

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281531. MForster added a comment. Rebase against master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281546. MForster added a comment. Use declaration in diagnostics instead of name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Att

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281550. MForster added a comment. Apply ClangTidy suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281791. MForster added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281927. MForster added a comment. Simplify code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); aaron.ballman wrote: > MForster wro

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281928. MForster marked 5 inline comments as done. MForster added a comment. Fix patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Bas

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. For context, this is the backported change, to be applied downstream before landing this review: https://github.com/apple/llvm-project/pull/1565 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llv

[PATCH] D78487: Explicitly move from llvm::json Array/Object to Value

MForster created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. MForster retitled this revision from "Explicitly move from llvm::json Array to Value" to "Explicitly move from llvm::json Array/Object to Value". MForster a

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 282168. MForster added a comment. Pretty-print VarDecl arguments correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284286. MForster added a comment. Add an -ast-print test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284288. MForster added a comment. Fix mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/At

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284343. MForster marked an inline comment as done. MForster added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 285329. MForster added a comment. Rebase before submission Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2215685 , @thakis wrote: > Looks like this breaks check-clangd on Windows: > http://45.33.8.238/win/21943/step_9.txt Update from an offline conversation: This may actually be rather an issue with the test, which was i

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. It also seems weird to me that a file that relies on CRLF line endings is checked in explicitly with LF line endings. A better approach IMHO would be to check it in as binary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster created this revision. MForster added a reviewer: labath. Herald added a subscriber: jdoerfert. Herald added a project: All. MForster requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These automatic conversions lead to i

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425742. MForster added a comment. Force-add crlf.cpp(.expected) with CRLF line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files: clang-tools-extra/te

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. I'm proposing this: D124606 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124563/new/ https://reviews.llvm.org/D124563 ___ cfe-commits mailin

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425745. MForster added a comment. Use `-text` instead of `binary`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files: clang-tools-extra/test/.gitattributes c

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aba5fa77482: Use `-text` git attribute instead of `text eol=...` (authored by MForster). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479798 , @ilya-biryukov wrote: > NIT: change the commit message to say `-text` instead of `binary` Ah, sorry, saw this too late... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479805 , @MForster wrote: > In D124606#3479798 , @ilya-biryukov > wrote: > >> NIT: change the commit message to say `-text` instead of `binary` > > Ah, sorry, saw this too la

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. > In D124563#3479405 , @MForster > wrote: > >> It also seems weird to me that a file that relies on CRLF line endings is >> checked in explicitly with LF line endings. A better approach IMHO would be >> to check it in as binary

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. Well, I tested this on Windows. :-) forster@Desktop MINGW64 ~/src/llvm-project/clang-tools-extra/test (main) $ git reset --hard 4aba5fa774821279c2e2e26dd6ed6e1c6a151044 && grep 'crlf.cpp ' .gitattributes && file clang-apply-replacements/Inputs/crlf/crlf.cpp HEAD i

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

MForster added a comment. In D124563#3479990 , @aaronpuchert wrote: > In D124563#3478625 , @smeenai wrote: > >> I *think* this would mean that if you're on Windows and have `core.autocrlf` >> set to `input`, whe

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

MForster added a comment. Adrian has reverted this commit for me. Here is a reproduction case for the issue that is triggered by this change: #include template struct S {}; template S foo() { for (auto status : { S() }) { return status; } } void a() {

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

MForster added a comment. That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it was his suggestion in the first place to go to declref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450 __

[PATCH] D70872: Advertise documentLink capability

MForster created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Add "textDocument/documentLink" protocol support Implement "textDocument/documentLink" Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang-tools-extra/clangd/test/document-link.test:21 +# CHECK-NEXT: }, +# CHECK-NEXT: "target": "file://{{.*}}/iostream" +# CHECK-NEXT:}, Originally I tried to add

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked 6 inline comments as done. MForster added a comment. I think I addressed all review comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster updated this revision to Diff 233433. MForster marked an inline comment as not done. MForster added a comment. Adress review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 Files: clang

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster added a comment. In D70872#1781703 , @sammccall wrote: > Thanks! I'll land this for you. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 __