Author: matze
Date: Mon Sep 25 19:37:23 2017
New Revision: 314187
URL: http://llvm.org/viewvc/llvm-project?rev=314187&view=rev
Log:
CodeGenModule: Adapt to LLVM TargetLibraryInfo changes
Adapt to LLVM TargetLibraryInfo changes in r314185.
See also https://reviews.llvm.org/D38106 and https://revi
MatzeB created this revision.
MatzeB added reviewers: bruno, rsmith, aprantl.
MatzeB added a subscriber: cfe-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.
This option behaves in a similar spirit as -save-temps and writes out
llvm statistics i
MatzeB added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
bruno wrote:
> Why removing StatsFile here? IIUC, at this point StatsF
MatzeB updated this revision to Diff 72376.
MatzeB marked an inline comment as done.
MatzeB added a comment.
Thanks for the reviews.
Addressed comments.
Repository:
rL LLVM
https://reviews.llvm.org/D24820
Files:
docs/CommandGuide/clang.rst
include/clang/Basic/DiagnosticFrontendKinds.td
MatzeB added inline comments.
Comment at: test/Driver/save-stats.c:1
@@ +1,2 @@
+// RUN: %clang -target x86_64-apple-darwin -save-stats %s -### 2>&1 |
FileCheck %s
+// RUN: %clang -target x86_64-apple-darwin -save-stats=cwd %s -### 2>&1 |
FileCheck %s
bruno wrot
Author: matze
Date: Mon Sep 26 13:53:34 2016
New Revision: 282426
URL: http://llvm.org/viewvc/llvm-project?rev=282426&view=rev
Log:
CC1: Add -save-stats option
This option behaves in a similar spirit as -save-temps and writes
internal llvm statistics in json format to a file.
Differential Revisi
MatzeB added inline comments.
Comment at: test/Driver/save-stats.c:12
@@ +11,3 @@
+// RUN: %clang -target x86_64-apple-darwin -save-stats=obj -c -o
obj/dir/save-stats.o %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OBJ
+// CHECK-OBJ: "-stats-file=obj/dir{{/|}}save-stats.sta
Author: matze
Date: Mon Sep 26 15:48:34 2016
New Revision: 282438
URL: http://llvm.org/viewvc/llvm-project?rev=282438&view=rev
Log:
Fix test on windows
Modified:
cfe/trunk/test/Driver/save-stats.c
Modified: cfe/trunk/test/Driver/save-stats.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
Author: matze
Date: Tue Sep 27 14:38:59 2016
New Revision: 282533
URL: http://llvm.org/viewvc/llvm-project?rev=282533&view=rev
Log:
Adapt to LLVM EnableStatistics() change.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
Mo
Author: matze
Date: Tue Sep 27 18:44:38 2016
New Revision: 282557
URL: http://llvm.org/viewvc/llvm-project?rev=282557&view=rev
Log:
Put new warning in a diagnostic group.
The warning I added in r282426 should be a diagnostic group.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticFrontendKi
If we do this we should at least be targetted and restrict it to the tests that
need the flag. For example you could put:
list(APPEND CFLAGS -ffp-contract=off)to
MultiSource/Applications/oggenc/CMakeLists.txt
and
CFLAGS += -ffp-contract=off into MultiSource/Applications/oggenc/Makefile
https://github.com/MatzeB updated
https://github.com/llvm/llvm-project/pull/71874
>From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Wed, 19 Oct 2022 10:58:40 -0700
Subject: [PATCH] Remove unused LoopInfo from InlineSpiller and SpillPlacement
---
https://github.com/MatzeB updated
https://github.com/llvm/llvm-project/pull/71874
>From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Wed, 19 Oct 2022 10:58:40 -0700
Subject: [PATCH 1/2] Remove unused LoopInfo from InlineSpiller and
SpillPlacement
https://github.com/MatzeB updated
https://github.com/llvm/llvm-project/pull/71874
>From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Wed, 19 Oct 2022 10:58:40 -0700
Subject: [PATCH 1/3] Remove unused LoopInfo from InlineSpiller and
SpillPlacement
https://github.com/MatzeB closed https://github.com/llvm/llvm-project/pull/71874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB closed https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatzeB wrote:
And digging even deeper:
- FWIW I noticed that I only used `clang -c` as benchmark previously, should
have used `clang -c -O3` resulting in this:
```
Old-BFI: insn: 37,821,687,947 (baseline)
New-BFI: insn: 38,133,312,923 +0.82%
Old-BFI, no-cold: insn: 37,423,365
https://github.com/MatzeB approved this pull request.
Seems like a sensible backstop for slightly incorrect profile data leading to
extreme branch weights. Added some nitpicks, either way LGTM
https://github.com/llvm/llvm-project/pull/70094
___
cfe-co
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/70094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
https://github.com/MatzeB approved this pull request.
Seems like a sensible backstop for slightly incorrect profile data leading to
extreme branch weights. Added some nitpicks, either way LGTM
https://github.com/llvm/llvm-project/pull/70094
___
cfe-co
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/70094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
@@ -636,9 +636,13 @@ static void updateBranchWeights(Instruction *Term,
WeightInfo &Info) {
MDB.createBranchWeights(Info.Weights));
for (auto [Idx, SubWeight] : enumerate(Info.SubWeights))
if (SubWeight != 0)
- Info.Weights[Idx] = Info.Weights[Id
MatzeB wrote:
Do you just see regression or also some wins? I don't know whether this is all
stems from the `isColdCallSite` behavior, and not just the usual some things
get better some things get worse situation you can easily have when inlining
changes?
https://github.com/llvm/llvm-project/
MatzeB wrote:
Or put another way: Do you see regressions disappear with `-mllvm
-cold-callsite-rel-freq=0` ?
https://github.com/llvm/llvm-project/pull/66285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/MatzeB approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/73593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB commented:
Consider using `utils/update_analyze_test_checks.py` to create the check
lines...
https://github.com/llvm/llvm-project/pull/73593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
MatzeB wrote:
How does this relate to the existing `shouldOptimizeForSize(Function&)` and
similar APIs which appear to provide similar functionality at a first glance.
If they are the same, then we should have a plan in place to cleanup and only
have one system afterwards, if there are importa
MatzeB wrote:
The internal services I tried here tended to slightly improve or stay neutral.
We can revert, but could you please share some details on how your clang built
/ tested so I have a chance to address things and bring these changes back?
https://github.com/llvm/llvm-project/pull/6628
MatzeB wrote:
Oh so this isn't even a PGO enabled build, interesting...
https://github.com/llvm/llvm-project/pull/66285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatzeB wrote:
Oh so this isn't even a PGO enabled build, interesting...
https://github.com/llvm/llvm-project/pull/66285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatzeB wrote:
So not sure if there is an easy fix for the regression.
We should probably have some logic that scales all BFI values when inlining to
better accomodate the new range of frequencies so we loose less precision by
accident. Though that won't help with the regression at hand as that
MatzeB wrote:
I think I traced the clang regression down to
`InlineCostCallAnalyzer::isColdCallSite` returning `true` in more instances. It
previously did not do that because of what feels more like an accidental loss
of precision:
The example I analyzed starts out as a single-block function
MatzeB wrote:
Also note that this 2% cold-code threshold is only applied in situation where
no PGO data is available. So maybe we should just ignore this, given that
without PGO data it just is often impossible for the compiler to make good
inlining decisions...
https://github.com/llvm/llvm-p
MatzeB wrote:
Seems this got introduced in https://reviews.llvm.org/D34312 with the rough
idea that we shouldn't inline into parts of the code that
`_builtin_expect(...)` deems unlikely. Which makes sense when you say it
express it like this, but I guess numeric thresholds can go wrong...
htt
MatzeB wrote:
Seems this got introduced in https://reviews.llvm.org/D34312 with the rough
idea that we shouldn't inline into parts of the code that
`_builtin_expect(...)` deems unlikely. Which makes sense when you say it
express it like this, but I guess numeric thresholds can go wrong...
htt
MatzeB wrote:
Not sure how this change could trigger leaks. Changing BFI here should mostly
effect inlining decisions, basic block placement, register allocation. But it
shouldn't change program behavior or memory operations...
Will try to reproduce this test on my machine, to see if there's a
MatzeB wrote:
Some very ad-hoc benchmarking. Of clang compilation speed (measured in
instructions as reported by valgrind/callgrind which I think somewhat matches
the setup of nikic) compiling `sqlite3` of CTMark:
Old-BFI (this PR reverted), New-BFI (this PR applied), no-cold
(cold-callsite-r
Author: Matthias Braun
Date: 2022-11-07T12:31:28-08:00
New Revision: cafe50daf525971ffc3b8c5f2f6343d24e381384
URL:
https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384
DIFF:
https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384.diff
Author: Matthias Braun
Date: 2022-06-01T18:05:53-07:00
New Revision: 850d53a197f9ffbf5708b7bd795056335e81e9b7
URL:
https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7
DIFF:
https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7.diff
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -618,7 +623,7 @@ class SampleContext {
void clearState(ContextStateMask S) { State &= (uint32_t)~S; }
bool hasContext() const { return State != UnknownContext; }
bool isBaseContext() const { return FullContext.size() == 1; }
- StringRef getName() const { return Name;
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -643,14 +648,11 @@ class SampleContext {
uint64_t getHashCode() const {
if (hasContext())
return hash_value(getContextFrames());
-
-// For non-context function name, use its MD5 as hash value, so that it is
-// consistent with the profile map's key.
-
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,215 @@
+//===--- ProfileFuncRef.h - Sample profile function reference ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
MatzeB wrote:
> There are two ways ProfileFuncRef can originate (ignoring copy constructions):
> ...
So you are saying there can be hashcode `ProfileFuncRef`s coming from the
profile, but an `llvm::Function` would always produce a string `ProfileFuncRef`?
> B - Whenever we lookup a ProflieFuncR
MatzeB wrote:
> There are two ways ProfileFuncRef can originate (ignoring copy constructions):
> ...
So you are saying there can be hashcode `ProfileFuncRef`s coming from the
profile, but an `llvm::Function` would always produce a string `ProfileFuncRef`?
> B - Whenever we lookup a ProflieFuncR
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matthias Braun
Date: 2023-09-11T10:38:06-07:00
New Revision: f8431a0e4008db374dfb17a21119178fb960e334
URL:
https://github.com/llvm/llvm-project/commit/f8431a0e4008db374dfb17a21119178fb960e334
DIFF:
https://github.com/llvm/llvm-project/commit/f8431a0e4008db374dfb17a21119178fb960e334.diff
Author: Matthias Braun
Date: 2023-03-30T11:16:32-07:00
New Revision: e00a8d081d789cac606cf0749c332c4632132820
URL:
https://github.com/llvm/llvm-project/commit/e00a8d081d789cac606cf0749c332c4632132820
DIFF:
https://github.com/llvm/llvm-project/commit/e00a8d081d789cac606cf0749c332c4632132820.diff
Author: Matthias Braun
Date: 2023-02-23T11:26:41-08:00
New Revision: c21378f90a4442810adc4af924a83a9c222fdc51
URL:
https://github.com/llvm/llvm-project/commit/c21378f90a4442810adc4af924a83a9c222fdc51
DIFF:
https://github.com/llvm/llvm-project/commit/c21378f90a4442810adc4af924a83a9c222fdc51.diff
Author: matze
Date: Tue Jan 10 11:43:01 2017
New Revision: 291576
URL: http://llvm.org/viewvc/llvm-project?rev=291576&view=rev
Log:
CGDecl: Skip static variable initializers in unreachable code
This fixes http://llvm.org/PR31054
Differential Revision: https://reviews.llvm.org/D28505
Added:
MatzeB added a subscriber: MatzeB.
MatzeB added a comment.
The sanitizer code triggers this warning for code that looks conceptually like
this:
typedef struct Bla { char bar; int foo; } __attribute__((packed));
uintptr_t getu(struct Bla *b) { return (uintptr_t)&b->foo; }
Resulting in:
Author: matze
Date: Fri Jan 27 20:36:00 2017
New Revision: 293364
URL: http://llvm.org/viewvc/llvm-project?rev=293364&view=rev
Log:
Avoid calling dump() in normal code
dump() is only available in debug builds and meant for debugger usage,
normal code should use something like print(errs());
Modi
Author: matze
Date: Fri Feb 3 17:09:31 2017
New Revision: 294065
URL: http://llvm.org/viewvc/llvm-project?rev=294065&view=rev
Log:
Driver: Do not warn about unused -pthread when linking on darwin
While there is nothing to do at link time to get pthreads support on
darwin, specifying the argument
Author: matze
Date: Fri Jul 14 17:29:25 2017
New Revision: 308071
URL: http://llvm.org/viewvc/llvm-project?rev=308071&view=rev
Log:
Try to fix modules build
Module builds somehow report an ambiguity between clang::Diagnostic and
clang::Tooling::Diagnostic. It seems as if one of the additional hea
Author: matze
Date: Fri Nov 18 13:43:25 2016
New Revision: 287371
URL: http://llvm.org/viewvc/llvm-project?rev=287371&view=rev
Log:
Adapt to llvm NamedRegionTimer changes
We have to specify a name and description for the timers and groups now.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Author: matze
Date: Sat Dec 3 23:55:09 2016
New Revision: 288614
URL: http://llvm.org/viewvc/llvm-project?rev=288614&view=rev
Log:
TableGen: Adapt to llvm r288612
Modified:
cfe/trunk/utils/TableGen/ClangASTNodesEmitter.cpp
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trun
Author: matze
Date: Mon Dec 5 00:00:51 2016
New Revision: 288645
URL: http://llvm.org/viewvc/llvm-project?rev=288645&view=rev
Log:
Adapt to llvm/TableGen DagInit changes.
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp
URL:
http://llvm.
Author: matze
Date: Mon Apr 24 13:41:00 2017
New Revision: 301218
URL: http://llvm.org/viewvc/llvm-project?rev=301218&view=rev
Log:
Pragma: Fix DebugOverflowStack() resulting in endless loop.
Drive-by fix (noticed while working on https://reviews.llvm.org/D32205):
DebugOverflowStack() is supposed
Author: matze
Date: Fri May 19 17:37:15 2017
New Revision: 303463
URL: http://llvm.org/viewvc/llvm-project?rev=303463&view=rev
Log:
CodeGenModule: Always output wchar_size, check LLVM assumptions.
llvm::TargetLibraryInfo needs to know the size of wchar_t to work on
functions like `wcslen`. This p
Author: matze
Date: Fri May 19 19:38:27 2017
New Revision: 303474
URL: http://llvm.org/viewvc/llvm-project?rev=303474&view=rev
Log:
Revert "CodeGenModule: Always output wchar_size, check LLVM assumptions."
Let's revert this for now (and with it the assert()) to get the bots
back to green until I
Author: matze
Date: Fri May 19 20:29:55 2017
New Revision: 303478
URL: http://llvm.org/viewvc/llvm-project?rev=303478&view=rev
Log:
CodeGenModule: Always output wchar_size, check LLVM assumptions.
Re-commit r303463 now that LLVM is fixed and adjust some lit tests.
llvm::TargetLibraryInfo needs t
Author: matze
Date: Wed Oct 28 12:20:33 2015
New Revision: 251529
URL: http://llvm.org/viewvc/llvm-project?rev=251529&view=rev
Log:
Adapt to lit change in llvm r251478-r251481
Sorry for the breakage.
Modified:
libcxx/trunk/test/libcxx/test/format.py
Modified: libcxx/trunk/test/libcxx/test/f
Author: matze
Date: Wed Jul 27 17:47:07 2016
New Revision: 276930
URL: http://llvm.org/viewvc/llvm-project?rev=276930&view=rev
Log:
test/Frontend: Add a test for aarch64 target CPU names.
Nothing else checked the target cpu names for aarch64 yet.
Add a test in the spirit of x86-target-cpu.c.
Add
Author: matze
Date: Wed Jul 27 17:47:09 2016
New Revision: 276931
URL: http://llvm.org/viewvc/llvm-project?rev=276931&view=rev
Log:
Basic/Targets.cpp: Reformat aarch64 CPU list.
Having 1 entry per line and an alphabetical order is clearer and reduces
the risk of invalid merges.
Modified:
cfe
Author: matze
Date: Tue Aug 9 20:02:28 2016
New Revision: 278191
URL: http://llvm.org/viewvc/llvm-project?rev=278191&view=rev
Log:
test/hard_link_count(): Fix test on darwin
The hard link count that stat reports are different between normal hfs and the
case sensitive variant. Accept both.
Modif
Author: matze
Date: Mon Feb 1 16:18:58 2016
New Revision: 259424
URL: http://llvm.org/viewvc/llvm-project?rev=259424&view=rev
Log:
Fix build problem by lower SmallSet to a reasonable value
Modified:
clang-tools-extra/trunk/modularize/PreprocessorTracker.cpp
Modified: clang-tools-extra/trunk
MatzeB added a comment.
Most patterns and several of the ones coming from lit.local.cfg are explained
in TestingGuide.rst as well. On the other hand it makes sense to explain the
lit specific substitutions in the lit docu, maybe just add an additional link
to the TestingGuide.rst to reference t
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
I'd probably go for a term like "pattern" instead of macro (there is no
parameters or anything more complicated). The explanation for %t/%T is not
helpful in the current form. Maybe something
MatzeB created this revision.
MatzeB added reviewers: doug.gregor, bkramer.
MatzeB added a subscriber: cfe-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.
llvm statistics are currently printed when the destructor of a
"static ManagedStatic Stat
Author: matze
Date: Wed Jun 15 14:24:55 2016
New Revision: 272820
URL: http://llvm.org/viewvc/llvm-project?rev=272820&view=rev
Log:
cc1_main: Do not print statistics twice in -disable_free mode.
llvm statistics are currently printed when the destructor of a "static
ManagedStatic StatInfo" in llvm
MatzeB added a comment.
Putting static-analyzer tests into the test-suite sounds good to me, the static
analyzer is part of llvm so this should be fine. Though I'd like to wait a bit
to hear other opinions on this matter.
As for the patch itself:
- I'd call the directory ClangAnalyzer
- For th
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM, though you should wait a week or two for other opinions before committing.
http://reviews.llvm.org/D16115
___
cfe-commits mailing list
cfe-
MatzeB created this revision.
MatzeB added reviewers: chandlerc, reames, echristo.
MatzeB added a subscriber: cfe-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.
These sets perform linear searching in small mode so it is never a good
idea to us
Author: matze
Date: Fri Jan 29 19:27:06 2016
New Revision: 259284
URL: http://llvm.org/viewvc/llvm-project?rev=259284&view=rev
Log:
Avoid overly large SmallPtrSet/SmallSet
These sets perform linear searching in small mode so it is never a good
idea to use SmallSize/N bigger than 32.
Differential
Author: matze
Date: Fri Nov 20 18:56:41 2015
New Revision: 253741
URL: http://llvm.org/viewvc/llvm-project?rev=253741&view=rev
Log:
Fix testcase when building on darwin
Explicitely specify a target to avoid "_" prefixes on the names.
Modified:
cfe/trunk/test/CodeGen/c-unicode.c
Modified: cf
Author: matze
Date: Fri Nov 20 20:13:29 2015
New Revision: 253758
URL: http://llvm.org/viewvc/llvm-project?rev=253758&view=rev
Log:
Fix c-unicode.c testcase again.
Specifying a fixed triple is not possible because that target may not
even be compiler. Go for a simpler fix by using a _? regex for
Author: matze
Date: Fri Nov 20 20:28:42 2015
New Revision: 253760
URL: http://llvm.org/viewvc/llvm-project?rev=253760&view=rev
Log:
Let's try to fix this test again with a fixed target triple
Modified:
cfe/trunk/test/CodeGen/c-unicode.c
Modified: cfe/trunk/test/CodeGen/c-unicode.c
URL:
http
Author: matze
Date: Tue Dec 1 19:12:06 2015
New Revision: 254477
URL: http://llvm.org/viewvc/llvm-project?rev=254477&view=rev
Log:
Force test to a target that supports thread_local
This should fix darwin bots.
Modified:
clang-tools-extra/trunk/test/clang-tidy/cert-static-object-exception.cp
MatzeB wrote:
Please provide additional context in your summary on how this happens.
My understanding is that this is for a setup with linux binfmt-misc + qemu
running aarch64 binaries on an x86 system. The fact that we end up with
absolute pathnames in `argv[0]` may be a bug in qemu or binfmt
https://github.com/MatzeB approved this pull request.
https://github.com/llvm/llvm-project/pull/107974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB created
https://github.com/llvm/llvm-project/pull/91275
None
>From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Mon, 6 May 2024 14:39:37 -0700
Subject: [PATCH] Use cmake to find perl executable
---
clang/CMakeLists.txt
1 - 100 of 132 matches
Mail list logo
