MatzeB added a comment.

Putting static-analyzer tests into the test-suite sounds good to me, the static 
analyzer is part of llvm so this should be fine. Though I'd like to wait a bit 
to hear other opinions on this matter.

As for the patch itself:

- I'd call the directory ClangAnalyzer
- For the external file you should provide a sha256 (or md5) sum and ideally 
check it in the download script, so other people can be sure that the reference 
results do indeed match the artifact being analyzed.
- Why is there a subdirectory "2016-01-11-134007-41609-1" in the 
RefScanBuildResults directory, that name appears arbitrary for reference 
results.


http://reviews.llvm.org/D16115



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to