[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3581240 , @dyung wrote: > Can you take a look? Hi @dyung , thanks for the report and sorry for the trouble! Can you help me try to reproduce it? Which version of Visual Studio, and what preset are you using? Reposi

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

mizvekov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. mizvekov published this revision for review. mizvekov added reviewers: dyung, nikic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository:

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. Hi @dyung, can you verify the solution I proposed in https://reviews.llvm.org/D127943 is good for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 __

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe35096ae961e: cmake: configure clang lit to use hmaptool from source directly (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov updated this revision to Diff 437905. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127351/new/ https://reviews.llvm.org/D127351 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaTemplateIn

[PATCH] D127690: [NFC] clang/Parser: remove dead code

mizvekov updated this revision to Diff 437906. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127690/new/ https://reviews.llvm.org/D127690 Files: clang/lib/Parse/Parser.cpp Index: clang/lib/Parse/Parser.cpp

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438073. mizvekov retitled this revision from "clang: fix pack substitution scope in function params" to "clang: fix checking parameter packs for expansion.". mizvekov edited the summary of this revi

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mizvekov updated this revision to Diff 438089. mizvekov added a comment. mizvekov published this revision for review. mizvekov added reviewers: rsmith, v.g.vassilev. Herald added a project: clang.

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438084. mizvekov added a comment. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . Signed-off-by: Matheus Izvekov Repository

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 438117. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 438118. mizvekov added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSON

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov updated this revision to Diff 438680. mizvekov edited the summary of this revision. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/S

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov updated this revision to Diff 438702. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128112/new/ https://reviews.llvm.org/D128112 Files: clang/test/AST/ast-dump-template-decls.cpp Index: clang/test/AST/ast-d

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov updated this revision to Diff 438723. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128112/new/ https://reviews.llvm.org/D128112 Files: clang/test/AST/ast-dump-template-decls.cpp Index: clang/test/AST/ast-d

[PATCH] D128112: [NFC] clang: Implement tests for PR56099

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG271cc588054a: [NFC] clang: Implement tests for PR56099 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438697. mizvekov added a comment. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . Fixes PR28087. Signed-off-by: Matheus Izvek

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 438813. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSON

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov updated this revision to Diff 439241. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127351/new/ https://reviews.llvm.org/D127351 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaTemplateIn

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov updated this revision to Diff 439244. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInte

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

mizvekov updated this revision to Diff 439245. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128276/new/ https://reviews.llvm.org/D128276 Files: clang/lib/Sema/SemaOverload.cpp clang/test/CXX/temp/temp.decls/te

[PATCH] D127690: [NFC] clang/Parser: remove dead code

mizvekov updated this revision to Diff 439246. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127690/new/ https://reviews.llvm.org/D127690 Files: clang/lib/Parse/Parser.cpp Index: clang/lib/Parse/Parser.cpp

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3538064 , @stephenneuendorffer wrote: > LGTM... Does LLVM_TOOLS_BINARY_DIR include CMAKE_CFG_INTDIR? Is this > actually NFC? On a normal build where the CMakelists in the llvm subdir is used as the top level one,

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 432339. mizvekov added a comment. - Just rebase, no review comments addressed yet. - One small churn in test/SemaCXX/deduced-return-void.cpp, which is new since last rebase. As this patch uses the template deduction machinery to also handle the mutiple retu

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf1ab1f0eb95: cmake: use llvm dir variables for clang/utils/hmaptool (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3545410 , @nikic wrote: > It looks like this change breaks the standalone build for clang. From what I > can see, while LLVM_TOOLS_BINARY_DIR and LLVM_TOOLS_INSTALL_DIR are exported > in llvm/cmake/modules/LLVMConfig

[PATCH] D126671: cmake: fix clang standalone build

mizvekov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D126308 broke building clang standalone, as LLVM_UT

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3545937 , @Ericson2314 wrote: > There is a lot of cruft behind the signs. I would just use > `LLVM_TOOLS_INSTALL_DIR` then which is exported to get this unblocked, and > I'll rebase D117977

[PATCH] D126674: [clang] NFC: introduce test for D126620

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126674 Files: clang/

[PATCH] D126671: cmake: fix clang standalone build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG93319128d0d4: cmake: fix clang standalone build (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 432974. mizvekov retitled this revision from "WIP" to "[clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy". mizvekov edited the summary of this revision. mizvekov added a comment.

[PATCH] D126674: [clang] NFC: introduce test for D126620

This revision was automatically updated to reflect the committed changes. Closed by commit rGc825abd6b019: [clang] NFC: introduce test for D126620 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126674/new/ https://reviews.llvm

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3547435 , @nikic wrote: > In D126308#3546235 , @mizvekov > wrote: > >> In D126308#3545937 , @Ericson2314 >> wrote: >> >>> There is a

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a reviewer: mizvekov. mizvekov added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:373-374 case TemplateExpansion: -return TemplateArg.Name == Other.TemplateArg.Name && +return getAsTemplateOrTemplatePattern().getAsTemplateDecl() == +

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov updated this revision to Diff 433729. mizvekov edited the summary of this revision. mizvekov added a comment. - fix for standalone builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 Files:

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. @nikic can you confirm this new patch is good for standalone? @Ericson2314 FYI in case your patch is going to improve on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 __

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127074 Files: clang/

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434334. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434335. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434336. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434337. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf62433f17c30: [NFC] Add test cases reported in PR54341 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our rules to determine if the throw expression are within the variable scope were giving a false negative result in case t

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

This revision was automatically updated to reflect the committed changes. Closed by commit rG43ef17cac172: [clang] P2266: apply move elision rules on throw expr nested in function… (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D127075?vs=434351&id=434623#toc Reposit

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:848 (Scope::FnScope | Scope::ClassScope | Scope::BlockScope | - Scope::FunctionPrototypeScope | Scope::ObjCMethodScope | -

[PATCH] D127361: [NFC] clang: add test for PR55886

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127361 Files: clang/

[PATCH] D127361: [NFC] clang: add test for PR55886

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfda534b9944: [NFC] clang: add test for PR55886 (authored by mizve

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added a comment. @rsmith , I have marked the few spots where the change is meaningful. Comment at: clang/include/clang/Sema/Template.h:488-497 +bool EarlySubstitution; + public: TemplateDeclInstantiator(Sema &SemaRef, DeclContext *Owner, -

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. @nikic ping, can you confirm this current patch works for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308 ___ cfe-commits mailing

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1060 LocalInstantiationScope Scope(SemaRef); + auto EarlySubstitutionScope = getEarlySubstitutionRAII(); mark Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

This revision was automatically updated to reflect the committed changes. Closed by commit rG51608515faa7: cmake: use llvm dir variables for clang/utils/hmaptool (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3569379 , @nikic wrote: > Sorry, missed the update. Just tried this in a local build and it seems to > work fine! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

mizvekov added inline comments. Herald added a subscriber: Peiming. Comment at: bolt/tools/CMakeLists.txt:11-13 +macro(add_bolt_tool_symlink name) + llvm_add_tool_symlink(BOLT ${ARGV}) +endmacro() Instead of each project having to define a different macro for th

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

mizvekov added a comment. This broke a buildbot, as a user reported on discord: https://buildkite.com/llvm-project/github-pull-requests/builds/5171#018aec0c-75ba-431a-a5c8-6a5cba51de28 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ http

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

mizvekov added a comment. This was never mentioned in the review, but I have a late question: Why did we need to implement a new flag, instead of using `getFullyQualifiedName` from `QualTypeNames.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov added inline comments. Comment at: clang/test/SemaObjCXX/arc-objc-lifetime.mm:69-79 +// See https://github.com/llvm/llvm-project/issues/61419 + +template struct pair { + T0 first; + T1 second; +}; + I think the fix looks good, although this test may b

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147263/new/ https://reviews.llvm.org/D147263 ___

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 ___ cfe-commits mailing list cfe-commi

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3984855 , @arphaman wrote: > Ping @mizvekov. > > Unfortunately I'm unable to revert this commit now so we won't be able to get > the bot back to green until it's fixed. Hello, sorry for the long time to respond. Can

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov added a comment. I don't know what is going on with the clang-format linux failure here. The patch it suggests looks awful... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160 ___

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov created this revision. Herald added subscribers: jansvoboda11, dexonsmith, lxfind, dang. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP, not yet ready for review. Small sample of things wrong with this patch: - Have

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. In D99005#2639501 , @aaronpuchert wrote: > For coroutines I have D68845 . The current > code is wrong, and not trivial to fix. We have never properly implemented > P1825

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 332140. mizvekov added a comment. - Removed special flag, now is enabled on -std=c++2b - Always enabled for coroutines - Ran test suite - Some relevant test files updated to also run c++2b - Some new tests added Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. In D99005#2639977 , @Quuxplusone wrote: > Conspicuously missing: tests for `decltype(auto)` return types, tests for > `co_return`. Though the first comment warns you that this is a work in progress and I just didn't get around

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. In D99005#2640121 , @aaronpuchert wrote: > With my previous comment I meant that it's better if you leave out the > `co_return` bits for now because it's wrong anyway. We can't use > `PerformMoveOrCopyInitialization`. It would

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 332184. mizvekov added a comment. Changed: - Implemented co_return as per Aaron's suggestion. - Imported coroutine tests from D68845 . - Test tags shortened: cxxYY_cxxZZ means every version from YY to ZZ, instead of cxxAA_BB

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 332186. mizvekov added a comment. small cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp c

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 332187. mizvekov added a comment. small cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added a comment. In D98971#2644747 , @Quuxplusone wrote: > Shrink the code by one line, by introducing another local named variable. > Still hoping for an "accept" here. My two cents: Functionality-wise I think it is OK, but like I said before,

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reworks a small set of tests, as preparatory work for implementing P2266 . - R

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p7-cxx14.cpp:3 +// RUN: %clang_cc1 -verify -std=c++20 -verify %s +// RUN: %clang_cc1 -verify -std=c++14 -verify %s Quuxplusone wrote: > (1) You skipped 17. > (2)

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:444 void f(volatile void); // expected-error {{'void' as parameter must not have type qualifiers}} + // cxx20_2b-warning@-1 {{volatile-qualified parameter type 'volatile void' is deprecated}} void g

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 332832. mizvekov added a comment. Changes per Arthur. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org/D99225 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cp

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. Splitting off the test changes into: https://reviews.llvm.org/D99225 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 ___ cfe-commits mai

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 332844. mizvekov added a comment. Normalize test tag names on clang/test/SemaCXX/P1155 .cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org/D9

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 333158. mizvekov added a comment. Rebased on top of D99225 , running on a bunch of extra tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.o

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8643 QualType MatchedType = -BuildDecltypeType(E, E->getBeginLoc()).getCanonicalType(); +BuildDecltypeType(E, E->getBeginLoc(), true, true).g

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 333707. mizvekov added a comment. Cleaned up implementation, not WIP anymore, ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333745. mizvekov added a comment. So it turns out there was a pre-existing bug where ObjC++ blocks with dependent return type were not getting copy elision. My latest refactoring accidentally fixed this in the return statement sema action, but unfortunately

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a subscriber: rjmccall. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else @rjmcca

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333749. mizvekov added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333756. mizvekov added a comment. some further simplifications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sem

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333925. mizvekov added a comment. Small update making some invariants more clear, with some simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: c

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2761 def note_expr_requirement_constraints_not_satisfied_simple : Note< - "%select{and|because}0 %1 does not satisfy %2:">; + "%select{and|be

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else rjmccall wrote: > mizvekov wrote: > > @rjmccal

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 334016. mizvekov added a comment. Changes per rsmith review: Just print the non-canonical type in the diagnostics. Instead of printing the expression, make the caret point to it, instead of pointing to the constraint. Repository: rG LLVM Github Monorepo

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad6dd5d8f0a: [clang] Use decltype((E)) for compound requirement type constraint (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else rjmccall wrote: > mizvekov wrote: > > rjmccall

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This expands NRVO propagation for more cases: Parse analysis improvement: Lambdas and Blocks with dependent retu

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2662816 , @Quuxplusone wrote: > Wow, nice catches. For posterity, here's the missed-optimization being > addressed IIUC: https://godbolt.org/z/MEoKGs7cE Thanks! And again thank you for providing test cases, it's what I

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 334575. mizvekov added a comment. fix clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sem

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335044. mizvekov added a comment. Includes some new NRVO tests which will be used in D99696 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335045. mizvekov added a comment. Fixes for auto&, decltype(auto). Exclude candidates from functions with dependent / undeduced return types which are references. Adjusts the CodeGen tests from D99225 . Repository: rG LLV

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added a comment. @Quuxplusone Thank you for the review. All your points are good ones and will be addressed in time! The new NRVO propagation `clang/test/CodeGen/nrvo-tracking.cpp` is also breaking on the buildbot, but it works on my machine. Will also take a look at that one. =

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99826 Files: clang/test/CXX/drs/dr3xx.cpp clang/test/CXX/expr/expr.prim/expr.prim

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbac74a50e99f: [clang] NFC: remove trailing white spaces from some

<    4   5   6   7   8   9   10   >