mizvekov added a comment.
@Quuxplusone Thank you for the review. All your points are good ones and will
be addressed in time!
The new NRVO propagation `clang/test/CodeGen/nrvo-tracking.cpp` is also
breaking on the buildbot, but it works on my machine.
Will also take a look at that one.
================
Comment at: clang/test/SemaCXX/conversion-function.cpp:160
+ return "Hello"; // cxx98_14-error {{calling a private constructor}}
#if __cplusplus <= 199711L
// expected-warning@-2 {{an accessible copy constructor}}
----------------
Quuxplusone wrote:
> When is this condition true?
> (Honestly I'm surprised that the `expected-warning` parser understands `#if`
> in the first place.)
Too bad you can't also define macros for these expected declarations :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99225/new/
https://reviews.llvm.org/D99225
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
