krasimir added a comment.
Thank you! That's a bug in the raw string format manager.
This code effectively first looks for a matching top-level style, and if that's
not found, then it tries to derive one via the RawFormat's BasedOnStyle:
https://github.com/llvm/llvm-project/blob/main/clang/lib/For
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150116/new/
https://reviews.llvm.org/D150116
_
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG34b422bafbd9: clang-format: [JS] support import/export type
(authored by jankuehle, committed by krasimir).
Repository:
rG LLVM Github Monorepo
C
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150563/new/
https://reviews.llvm.org/D150563
_
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe1f34b735b66: clang-format: [JS] terminate import sorting on
`export type X = Y` (authored by jankuehle, committed by krasimir).
Repository:
rG LL
krasimir added a comment.
I'll submit this for you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140211/new/
https://reviews.llvm.org/D140211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf86cdb485361: [clang][dataflow] Remove unused lambda capture
(authored by merrymeerkat, committed by krasimir).
Repository:
rG LLVM Github Monorep
krasimir updated this revision to Diff 81551.
krasimir added a comment.
- Split BreakableComment back into a BreakableBlockComment and
BreakableLineCommentSection
- Extract common reflow computation functionality
https://reviews.llvm.org/D27754
Files:
lib/Format/BreakableToken.cpp
lib/Form
krasimir updated this revision to Diff 82081.
krasimir added a comment.
- Put LastLineNeedsDecoration and Decoration and Prefix to the appropriate
subclasses
- Fixed a double indentation bug caused by the WhitespaceManager.
https://reviews.llvm.org/D27754
Files:
lib/Format/BreakableToken.cpp
krasimir added a comment.
Next 2 steps: will implement a simple heuristic about some sorts of ascii-art
types of things; next will branch and produce a version that takes the reflow
state out of the BreakableComment classes and puts it in the
breakProtrudingToken implementation.
https://revie
krasimir updated this revision to Diff 82089.
krasimir added a comment.
Ready for review.
- Split BreakableComment back into a BreakableBlockComment and
BreakableLineCommentSection
- Extract common reflow computation functionality
- Put LastLineNeedsDecoration and Decoration and Prefix to the ap
krasimir added inline comments.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
Maybe prepend a `, for example: /usr/bin/cla
krasimir added a comment.
It looks pretty good! I just have a minor suggestion.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
---
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Sorry for the delay.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298696: [clangd] Add support for vscode extension
configuration (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31121?vs=92367&id=92907#toc
Repository:
rL LLVM
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298697: [libclang] Bury dead TemporaryFiles (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31288?vs=92804&id=92908#toc
Repository:
rL LLVM
https://reviews.llvm.org/D31288
krasimir created this revision.
Adds code completion support to clangd.
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHandlers.h
test/clangd/
krasimir updated this revision to Diff 92931.
krasimir added a comment.
- Clean-up leftovers
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHand
krasimir updated this revision to Diff 92939.
krasimir added a comment.
- Add '.' and '>' as completion trigger characters
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHand
krasimir updated this revision to Diff 92940.
krasimir marked 7 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
c
krasimir updated this revision to Diff 92948.
krasimir added a comment.
- Make Items ownership more explicit
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
cla
krasimir added a comment.
Looks good! I just have two nits.
Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:139
+}
if (NamespaceTok->isNot(tok::kw_namespace))
continue;
I'd instead just add a guard check at old line 136:
```
if (!Namespace
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299421: [clangd] Add code completion support (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31328?vs=92948&id=94026#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3132
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great!
https://reviews.llvm.org/D31441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
krasimir added inline comments.
Comment at: clangd/ASTManager.cpp:166
tooling::CompilationDatabase *
ASTManager::getOrCreateCompilationDatabaseForFile(StringRef Uri) {
auto &I = CompilationDatabases[Uri];
I think we should rename the `Uri` parameter here to
krasimir added a comment.
Looks great! I'm wondering, can you think of ways to test the `didClose` method
similarly to how it's done for other handlers?
Comment at: clangd/ASTManager.cpp:203
+ // TODO(ibiryukov): at this point DocDatasLock can be unlocked in
asynchronous
+
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D31401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299758: [clangd] Extract FsPath from file:// uri (authored
by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31401?vs=94271&id=94507#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
krasimir requested changes to this revision.
krasimir added a comment.
This revision now requires changes to proceed.
Looks good! However it would be easier for reviewers if you could please use
arc: http://llvm.org/docs/Phabricator.html#id2
This makes it easy since I only have to do `arc patch D
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D31746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299843: [clangd] Remove ASTUnits for closed documents and
cache CompilationDatabase per… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31746?vs=94664&id=94665#toc
Repositor
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you!
https://reviews.llvm.org/D31853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
krasimir added a comment.
Do you still need someone to commit this?
https://reviews.llvm.org/D31853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299935: [clangd] Implement item kind for completion results
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31853?vs=94720&id=94811#toc
Repository:
rL LLVM
https://reviews
krasimir added a comment.
Seems that we're starting to hit some YAML/JSON mismatches, or is it that your
YAML string support is lacking?
Repository:
rL LLVM
https://reviews.llvm.org/D31992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir created this revision.
krasimir added a reviewer: klimek.
krasimir added subscribers: ioeric, cfe-commits, mgorny, klimek, djasper.
This presents a version of the comment reflowing with less mutable state inside
the comment breakable token subclasses. The state has been pushed into the
dr
krasimir created this revision.
Tests under tools/llvm-objdump should not use inputs from Object. Copied the
required inputs and aligned the new tests to be more consistent with the
existing
tests in this respect.
https://reviews.llvm.org/D28799
Files:
test/tools/llvm-objdump/X86/Inputs/open
This revision was automatically updated to reflect the committed changes.
Closed by commit rL29: [llvm-objdump tests] Copy the inputs of tests closer
to tests. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28799?vs=84653&id=84667#toc
Repository:
rL LLVM
http
krasimir added a comment.
@bkramer: yes, it passes with RUN: false removed
https://reviews.llvm.org/D28941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292600: Remove 'RUN: false' from Driver/response-file.c
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28941?vs=85111&id=85114#toc
Repository:
rL LLVM
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292604: [clang-format] Remove redundant test in
style-on-command-line.cpp (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28943?vs=85117&id=85122#toc
Repository:
rL LLVM
h
krasimir updated this revision to Diff 85339.
krasimir added a comment.
- [clang-format] Improve the interface of BreakableToken and add comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Commen
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.h:87
/// space.
virtual void replaceWhitespace(unsigned LineIndex, unsigned TailOffset,
Split Split,
By the way, I got confused, this stays because the n
krasimir updated this revision to Diff 85376.
krasimir added a comment.
- Add a note about replaceWhitespace in the comments of BreakableToken.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments.
krasimir updated this revision to Diff 85381.
krasimir added a comment.
- Add back a test case that I had previously removed for no good reason.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292796: [clang-format] Fix LanguageKind comments. (authored
by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29033?vs=85397&id=85403#toc
Repository:
rL LLVM
https://reviews.llvm.org/
krasimir marked 3 inline comments as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.h:55-56
+/// been reformatted, and
+/// - replaceWhitespaceBefore, for executing the reflow using a whitespace
+/// manager.
+///
klimek wrote:
>
krasimir updated this revision to Diff 85557.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments.cp
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159
+CommentPragmasRegex.match(Current.TokenText.substr(2)) ||
+Current.TokenText.substr(2).ltrim().startswith("clang-format on") ||
+Current.TokenText.substr(2).ltrim().
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.h:42-48
+/// There is a pair of operations that are used to compress a long whitespace
+/// range with a single space if that will bring the line lenght under the
+///
krasimir updated this revision to Diff 85725.
krasimir marked 8 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments.cp
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159
+CommentPragmasRegex.match(Current.TokenText.substr(2)) ||
+Current.TokenText.substr(2).ltrim().startswith("clang-format on") ||
+Current.TokenText.substr(2).ltrim().
krasimir updated this revision to Diff 85737.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address comments. Add a bunch of comments about various range computations.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
krasimir added a comment.
Tried to add some comments around range computations. Most of the time it's
about converting range offsets from local line-based values to
start-of-token-based offsets.
Comment at: lib/Format/BreakableToken.cpp:279-280
+ return Content.size() >= 2 &
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:747
+Split SplitBefore, WhitespaceManager &Whitespaces) {
+ // If this is the first line of a token, we need to inform Whitespace Manager
+ // about it: either adapt the whitespace range preceding it,
krasimir updated this revision to Diff 85739.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D28764
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/CMakeLists.txt
lib/Format/Comments.cp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293055: [clang-format] Implement comment reflowing.
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28764?vs=85739&id=85740#toc
Repository:
rL LLVM
https://reviews.llvm.or
krasimir updated this revision to Diff 86316.
krasimir added a comment.
- Remove scope
https://reviews.llvm.org/D29291
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293539: [clang-format] Separate line comment sections after
a right brace from comment… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29291?vs=86316&id=86317#toc
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293548: [clang-format] Fix regression that breaks comments
without a comment prefix (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29298?vs=86328&id=86331#toc
Repository:
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a line comment that is
klimek w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293617: [clang-format] Don't reflow comment lines starting
with '@'. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29323?vs=86405&id=86406#toc
Repository:
rL LLVM
https:
krasimir added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:178
- LastBlockComment = &Change;
-} else if (Change.Kind == tok::unknown) {
- if ((Change.StartOfBlockComment = LastBlockComment))
What happened to the tok::unknown case?
krasimir added a comment.
looks good!
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir updated this revision to Diff 86410.
krasimir added a comment.
- Add a FIXME for separating line comment sections into child lines
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unit
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a lin
krasimir updated this revision to Diff 86412.
krasimir marked an inline comment as done.
krasimir added a comment.
- Add a FIXME also in the parser
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Ind
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129
+// Additional fine-grained breaking of line comment sections is controlled
+// by the class BreakableLineCommentSection in case it is desirable to keep
+// several line comment s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293624: [clang-format] Fix regression merging comments
across newlines. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29322?vs=86412&id=86413#toc
Repository:
rL LLVM
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293633: [clang-format] Fix reflow in block comment lines
with leading whitespace. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29326?vs=86419&id=86422#toc
Repository:
rL
krasimir added a comment.
@djasper: I agree with the two spaces rule. Sounds pretty reasonable. Will add
this feature eventually.
Repository:
rL LLVM
https://reviews.llvm.org/D29326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293641: [clang-format] Fix regression about adding leading
whitespace to the content of… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29329?vs=86435&id=86437#toc
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293755: [clang-format] Fix regression about not aligning
trailing comments in case they… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29383?vs=86595&id=86596#toc
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293878: [clang-format] Don't reflow lines starting with
TODO, FIXME or XXX. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29396?vs=86643&id=86781#toc
Repository:
rL LLVM
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
looks good!
https://reviews.llvm.org/D29451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
krasimir added a comment.
That sounds reasonable. However it won't work with comment pragmas in newlines
in block comments.
The root issue that I was looking at was a taze directive inside a block
comment in a random typescript file, like:
/* random stuff
* long long long long
* taze
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293891: [clang-format] Fix breaking of comment sections in
unwrapped lines containing… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29444?vs=86790&id=86802#toc
Repository:
krasimir added a comment.
Ideally, we may try doing both: break a line comment section token steam and
keep this too. What do you think?
https://reviews.llvm.org/D29450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
krasimir updated this revision to Diff 86813.
krasimir edited the summary of this revision.
krasimir added a comment.
- Add a break in line comment sections by pragmas
https://reviews.llvm.org/D29450
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationI
krasimir updated this revision to Diff 86814.
krasimir added a comment.
- Merge branch 'master' into arcpatch-D29450_1
https://reviews.llvm.org/D29450
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/UnwrappedLineParser.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293898: [clang-format] Don't reflow across comment pragmas.
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29450?vs=86814&id=86816#toc
Repository:
rL LLVM
https://reviews
krasimir added a comment.
It's very unlikely that you caused this. After re-flowing lots of cases started
going over alternative code paths, and this looks like an instance of that.
https://reviews.llvm.org/D29486
___
cfe-commits mailing list
cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293997: [clang-format] Re-align broken comment lines where
appropriate. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29486?vs=86942&id=86945#toc
Repository:
rL LLVM
htt
krasimir added a comment.
I feel that this is a bit too rough now; any suggestions on improving the
architecture/design of this patch are welcome!
Comment at: lib/Format/UnwrappedLineParser.cpp:2206
+const SmallVectorImpl &Comments,
+const FormatToken* NextTok) {
bo
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207
+const FormatToken* NextTok) {
bool CommentsInCurrentLine = true;
+ int StartOfSectionAlignedWithNextToken = -1;
Need to add comments about this if we decide we may go wit
krasimir added inline comments.
Comment at: test/clangd/formatting.txt:9
+# CHECK: {"jsonrpc":"2.0","id":0,"result":{"capabilities":{
+# CHECK: "textDocumentSync": 1,
+# CHECK: "documentFormattingProvider": true,
bkramer wrote:
> djasper wrote:
krasimir updated this revision to Diff 87410.
krasimir marked 6 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index:
krasimir updated this revision to Diff 87424.
krasimir added a comment.
- Moved method summary from the implementation to the declaration.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: uni
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208
+const FormatToken *NextTok) {
+ // Decides which comment tokens should be added to the current line and which
+ // should be added as comment
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+ // Comments specifies the sequence of comment tokens to analyze. They get
+ // either pushed to the current line or added to the comments before the
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+ // Comments specifies the sequence of comment tokens to analyze. They get
+ // either pushed to the current line or added to the comments before the next
+ // token.
klimek
krasimir updated this revision to Diff 87614.
krasimir added a comment.
- Invent better name for comment analysis.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest
krasimir updated this revision to Diff 87615.
krasimir marked an inline comment as done.
krasimir added a comment.
- Updated call sites.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: unitt
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+ // Comments specifies the sequence of comment tokens to analyze. They get
+ // either pushed to the current line or added to the comments before the next
+ // token.
klimek
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294435: [clang-format] Break before a sequence of line
comments aligned with the next… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29626?vs=87615&id=87622#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294457: [clang-format] Move OriginalPrefix from base to
subclass. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29716?vs=87643&id=87653#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306386: [clang-format] Add a test for associative map proto
buffer fields (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D34623
Files:
cfe/trunk/unittests/Format/FormatTestProt
krasimir updated this revision to Diff 104146.
krasimir added a comment.
- Rebase with master
- Updated implementation with the new tests
https://reviews.llvm.org/D34621
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/Unwrappe
krasimir updated this revision to Diff 104148.
krasimir added a comment.
- Remove todo test case
https://reviews.llvm.org/D34621
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306406: [clang-format] Support <>-style proto message fields
(authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D34621
Files:
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/tr
601 - 700 of 948 matches
Mail list logo
