[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGClass.cpp:1773 // function - EmitSanitizerDtorCallback(CGF, VTablePtr, PoisonSize); + EmitSanitizerDtorCallback(C

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd67e6972f85: [ASan] Reland of D116182 to always link asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122407/new

[PATCH] D106101: [asan] Slightly modified the documentation to check commit permissions.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor documentation change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106101 Files: clang/docs/AddressSanitizer.rst I

[PATCH] D106101: [asan] Slightly modified the documentation to check commit permissions.

kstoimenov updated this revision to Diff 359129. kstoimenov added a reviewer: kcc. kstoimenov added a comment. Add kcc as reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106101/new/ https://reviews.llvm.org/D106101 Files: clang/docs/Addr

[PATCH] D106101: [asan] Slightly modified the documentation.

kstoimenov updated this revision to Diff 359130. kstoimenov retitled this revision from "[asan] Slightly modified the documentation to check commit permissions." to "[asan] Slightly modified the documentation.". kstoimenov edited the summary of this revision. kstoimenov added a comment. Updated

[PATCH] D106101: [asan] Slightly modified the documentation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713949765614: [asan] Slightly modified the documentation. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG035441ff3008: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kstoimenov added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558 + TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*"); + EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning)); + // And we can explicitly exclude a

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added a comment. One meta-observation: can you split this into smaller patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 ___ cfe-commits maili

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:33 + +class SanitizerMetadataFactory { + SanitizerMetadataFactory(const SanitizerMetadataFactory &) = delete; Not sure if this class follows the 'factory' design pattern,

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

kstoimenov accepted this revision. kstoimenov added a comment. I think the name 'mainsrc' is slightly misleading because of the association with the 'main' function. Maybe something like primarysrc would be better to avoid this confusion? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365608. kstoimenov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added an IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365650. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/test/CodeGen/asan-use-callbacks.cpp llvm/inclu

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365787. kstoimenov added a comment. Address lint comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/test/CodeGen/asan-use-callbacks.cpp llv

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 366069. kstoimenov added a comment. Started using R8 instead of RAX beacuse of some test failures. Also fixed the "Yes means No and No means Yes. Delete all files [Y]? " bug :-) for the load/store functions. Rep

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 366141. kstoimenov added a comment. Added code generation tests and fixed some bugs along the way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/t

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 366970. kstoimenov retitled this revision from "[asan] Implemented custom calling convention similar to the one used by HWASan for X86. " to "[asan] Implemented custom calling convention similar to the one used by HWASan for X86.". kstoimenov added a comme

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Amended this patch to be the x86 only patch. PTAL. In D107850#2949939 , @vitalybuka wrote: > This can be split into 3 patches in the following order: > > 1. x86 > 2. Instrumentation > 3. clang > > Each of them needs tests, In

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Never mind, this won't compile. Let me fix it and I will let you know when it is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367011. kstoimenov edited the summary of this revision. kstoimenov added a comment. Instead of packing and bit shifting arguments passing them as individual intrinsic arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367013. kstoimenov added a comment. Removed unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td llvm/lib/

[PATCH] D107850: [asan] [Patch 1/3] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Compiles and tests are passing now. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. I know it seems redundant to pass the constants with every function call, but otherwise the code generation code will have to take dependency on AddressSanitizerCommon.h, which I am not sure is ideal. I spent some time looking into it and becomes quite messy. For exa

[PATCH] D108323: [asan] Added -inline-small-callbacks LLVM flag, which would force inline code for 8 and 16 byte data types when otherwise a callback would have been used.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added a subscriber: hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The reason to inline the 8 and 16 byte access chec

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added a subscriber: hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The address sanitizer part of the code. Reposito

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367500. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: clang/tes

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367501. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/tes

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367505. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/tes

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367507. kstoimenov added a comment. Fixed after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td llvm/lib/Targ

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov marked 7 inline comments as done. kstoimenov added a comment. Added getAddressSanitizerParams to pull the constants out. Let me know if this is what you had in mind. Also struggled a little bit with git and rebase, but I think I have figured it out now. Comment at:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov marked an inline comment as done. kstoimenov added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], vitalybuka wrote: > vitalybuka wrote: > > P

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367575. kstoimenov added a comment. Update before expanding intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367577. kstoimenov added a comment. Update before expanding intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: clang/test/CodeGen/asan-use-callba

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367585. kstoimenov added a comment. Removed unused encodeMemToShadowInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: clang/test/CodeGen/asan-use-call

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367601. kstoimenov retitled this revision from "[asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86." to "[asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.". kstoim

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov marked an inline comment as done. kstoimenov added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1640 +def int_asan_check_memaccess : + Intrinsic<[],[llvm_ptr_ty, llvm_i8_ty, llvm_i8_ty], eugenis wrote: > vitalybuka wrote: > > pcc

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov created this revision. kstoimenov added reviewers: kda, vitalybuka. Herald added a subscriber: dang. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Summary This option can be used to reduce the size of the binary. The

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov updated this revision to Diff 358422. kstoimenov added a comment. Modified UsersManual.rst and added a test. Couldn't find a relevant section in AddressSanitizer.rst and adding a new one is outside of the scope of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov updated this revision to Diff 358689. kstoimenov added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105726/new/ https://reviews.llvm.org/D105726 Files: clang/docs/AddressSanitizer.rst clang/docs/Users

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382481. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382482. kstoimenov added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h ll

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382483. kstoimenov added a comment. Removed {} after if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov marked 2 inline comments as done. kstoimenov added a comment. PTAL. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1265 GlobalsMetadata ASanGlobalsMetadataAnalysis::run(Module &M, ModuleAnalysis

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382486. kstoimenov added a comment. s/I/LI/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h llvm/lib/T

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112732 Files: cl

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383068. kstoimenov added a comment. Removed unrelated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/incl

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysisManager::Invalidator &) { +return false; eugenis wrote: > vitalybuka wro

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383071. kstoimenov edited the summary of this revision. kstoimenov added a comment. Reverted pass builder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383072. kstoimenov added a comment. Added AddressSanitizerOptions back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov planned changes to this revision. kstoimenov added a comment. Tests are not passing. Hold off the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 ___

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383536. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test failures and crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 F

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 + } + Modified |= ModuleSanitizer.instrumentModule(M); + if (Modified) At first I had module sanitizer run first, but some tests failed. Is it possible

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383819. kstoimenov added a comment. Fixed remaing 2 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/includ

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383921. kstoimenov marked an inline comment as done. kstoimenov added a comment. Update after discussing with vitalybuka@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() vitalybuka wrote: > Why do we need to remove AddressSanitizerOptions? Adding it back

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384465. kstoimenov added a comment. Moved module instumentation back ahead of function instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: cl

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384467. kstoimenov added a comment. Moved empty check to the top of the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/Backen

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384488. kstoimenov marked 3 inline comments as done. kstoimenov added a comment. Moved module after function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384515. kstoimenov added a comment. After rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Tr

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76ea87b94e5c: [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 76ea87b94e5cba335d691e4e18e3464ad45c8b52

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3145323b549: Revert "[ASan] Process functions in Asan module pass" (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn)); -

[PATCH] D113131: [ASan] Process functions in Asan module pass.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Re-land of D112732

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384544. kstoimenov added a comment. After merging D113072 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/Co

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGa55c4ec1cee7: [ASan] Process functions in Asan module pass (authored by kstoimenov). Changed prior to commit: https://reviews.llvm.org/D112732?vs=384544&id=384571#toc Repository: rG LLVM Github Monor

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384583. kstoimenov added a comment. After removing function pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAn

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384587. kstoimenov added a comment. Restored StackSafetyAnalysis.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/lib/Transforms/Instrumentation/Ad

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384877. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/lib/Tra

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384902. kstoimenov added a comment. Moved AddressSanitizer back to the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/lib/Transforms/Instrumen

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kstoimenov marked an inline comment as done. Closed by commit rG3f1aca58df8f: [ASan] Added stack safety support in address sanitizer. (authored by kstoimenov). Reposit

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

kstoimenov added a comment. Is it possible these errors are due to your change: https://lab.llvm.org/buildbot/#/builders/5/builds/30522/steps/13/logs/stdio? If so please consider reverting/fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1383

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll:8 ; -; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S | Fil

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM, but get one from vitalybuka@ too. Sorry about delayed review, I missed it. Next time ping me if I don't respond within a day. Comment at: llvm/lib/IR/Globals.

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

kstoimenov added a comment. This change is breaking memory sanitizer in some cases. We observed that when the argument is not actually removed the pass is dropping the noundef attribute. See the diff snippet below. Is that an intended behavior? We would like to revert this as it is breaking MS

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); Would it make sense to create two separate functions something like

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); hctim wrote: > kstoimenov wrote: > > Would it make sense to create

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. Please get approval from vitalybuka@ before submitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.o

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added inline comments. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} thetruestblue wrote: > Can you explain the motivation here? > > RTAsan_static object

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

kstoimenov created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50cd2c257cb4: [LSAN] Disable leaks in test using environment variables instead of not running… (authored by kstoimenov). Repository: rG LLVM Githu

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov abandoned this revision. kstoimenov added a comment. I will send a different patch with LSAN_OPTIONS instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145451/new/ https://reviews.llvm.org/D145451 ___

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added subscribers: arphaman, emaste. Herald added a project: All. kstoimenov requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov updated this revision to Diff 503915. kstoimenov added a comment. Removed debug print. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.org/D145727 Files: clang/test/Driver/crash-diagnostics-dir-3.c cla

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011b4d4706ee: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145822 Files:

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov updated this revision to Diff 504264. kstoimenov edited the summary of this revision. kstoimenov added a comment. Moved UNSUPPORTED to one line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov marked an inline comment as done. kstoimenov added a comment. In D145822#4185801 , @vitalybuka wrote: > what is about detect_leaks? Yes. I had to revert only this file because it broke a bunch of bots. Repository: rG LLVM Github Monorepo

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14582

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

kstoimenov added a comment. Looks like this might have broken a couple of sanitizer builds. Here is one of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you please revert or fix? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

kstoimenov added a comment. In D151785#4418037 , @zyounan wrote: > In D151785#4417973 , @kstoimenov > wrote: > >> Looks like this might have broken a couple of sanitizer builds. Here is one >> of them: https://l

[PATCH] D118184: [ASan] Not lininking asan_static library for DSO.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Whithout this change DSOs fail to link because of missing asan_report_(load|store)n functions. Repository: rG LLVM Github Monorepo https://re

[PATCH] D118184: [ASan] Not linking asan_static library for DSO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf730d8ce134: [ASan] Not linking asan_static library for DSO. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov created this revision. kstoimenov added a reviewer: kda. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To make sure the the libraries are there for executable and not there for DSOs. Repository: rG LLVM Github Mo

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov updated this revision to Diff 403083. kstoimenov added a comment. Fixed order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118205/new/ https://reviews.llvm.org/D118205 Files: clang/test/Driver/sanitizer-ld.c Index: clang/test/Driv

[PATCH] D118205: [ASan] Added a unit test for D118184.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69da422bdaa6: [ASan] Added a unit test for D118184. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turned out that this change is causing segfaults in some situations. This reverts commit cf730d8ce1341ba593144df2e2bc8411238e04c3

  1   2   >