kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land.
LGTM, but get one from vitalybuka@ too. Sorry about delayed review, I missed it. Next time ping me if I don't respond within a day. ================ Comment at: llvm/lib/IR/Globals.cpp:225 +const SanitizerMetadata &GlobalValue::getSanitizerMetadata() const { + assert(hasSanitizerMetadata()); + return getContext().pImpl->GlobalValueSanitizerMetadata[this]; ---------------- Do we expect that 'this' is in the map? If so could you add an assert here using 'find' for example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits