kstoimenov marked 2 inline comments as done. kstoimenov added a comment. PTAL.
================ Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1265 GlobalsMetadata ASanGlobalsMetadataAnalysis::run(Module &M, ModuleAnalysisManager &AM) { return GlobalsMetadata(M); ---------------- vitalybuka wrote: > vitalybuka wrote: > > You can make this module pass to calculate StackSafetyGlobalAnalysis and > > use cached one below. > > This way we will avoid exposure of this logic to PM > It should probably be in ModuleAddressSanitizerPass, so it wll return ::all() > and we don't care about invalidation. getCachedResult uses the invalidation so I couldn't get rid of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits