[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259644. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-t

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:18 #include "index/dex/Dex.h" +#include "index/remote/Client.h" #include "llvm/ADT/ScopeExit.h" sammccall wrote: > Being able to include this header but not call the fu

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259701. kbobyrev marked 13 inline comments as done. kbobyrev added a comment. Resolve comments that refer to the outdated patch and address few small issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259762. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve couple more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: cla

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.cpp:27 +llvm::StringRef SpanName, SymbolIndex::Stub *Stub, ClangdRequestT Request, +std::function>( +SymbolIndex::Stub *, grpc::ClientContext *, const RPCRequestT &)> -

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259836. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve the last comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259839. kbobyrev added a comment. Don't use callback on the last message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-extra/clangd/CMakeLists.

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259859. kbobyrev marked 16 inline comments as done. kbobyrev added a comment. Address the last round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files

[PATCH] D78521: [clangd] Extend dexp to support remote index

This revision was automatically updated to reflect the committed changes. Closed by commit rG67b2dbd5a335: [clangd] Extend dexp to support remote index (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D78521?vs=259859&id=259869#toc Repository: rG LLVM Github Monorepo

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ -#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMOTE@ I don't know how much code will have with `ifdefs` in the Clangd itself, but I

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added projects: clang, LLVM. Generated Protobuf library has to be in CLANG_EXPORTS and should a

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260188. kbobyrev added a comment. Slightly adjust the CMake scripts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files: clang-tools-extra/clangd/index/remote/CMa

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:12 #include "index/remote/marshalling/Marshalling.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/StringRef.h" This can also be removed.

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Silence few PEP8 warnings. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78985 Files: clang-tools-extra/clang-tidy/add_new_che

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260606. kbobyrev added a comment. Don't create a separate directory for proto files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files: clang-tools-extra/clangd/

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260618. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files: clang-to

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8 ) -target_compile_definitions(clangd-index-server PRIVATE -D GOOGLE_PROTOBUF_NO_RTTI=1) -clang_target_link_libraries(clangd-index-server sammccall wrote:

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev updated this revision to Diff 260627. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Remove python3 from shebang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm.org/D78985 Files: clan

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev added a comment. In D78985#2007669 , @Eugene.Zelenko wrote: > It would be great to also run Flake9 and PyLint. Those were actually from pylint. That's a good idea, but I didn't fix all the warnings there and while I might get back to this in t

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ff3f339e881: [clangd] Fix remote index build without shared libs mode (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ http

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 __

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.h` can be compiled before the those headers are generated. https://github.com/kirillbobyrev/indexing-tools/runs/629305684 (disregard the mess in the repo) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev updated this revision to Diff 260906. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Use DEPENDS instead of add_dependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085 F

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. In D79085#2010025 , @sammccall wrote: > Haha, CMake :-( Now that I know this it kind of makes sense (I guess it's faster to just build everything and then link when all deps are ready), just something I didn't think about :)

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4645ef17ff1a: [clangd] Add CMake dependencies for Protobuf-generated files (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D79085?vs=260906&id=260920#toc Repository: rG LLVM

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. Ah, sorry, stale tab :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). Ah, I've done that (since I primarily build in the shared mod

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Extended version of D78843 . Repository: rG LLVM

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev updated this revision to Diff 282147. kbobyrev added a comment. Switch to `SymbolCollector::Options::FileFilter` that is even more straightforward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84811/new/ https://reviews.llvm.org/D84811 F

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 282166. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Good points, thanks! Addressed post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.or

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if (llvm::sys::path::is_a

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5588b0ad59: [clangd] Propagate remote index errors via Expected (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:70 SymbolCollector::Options Opts; +Opts.FileFilter = FileFilter; Opts.CountReferences = true; hokein wrote: > `FileFilter` seems more promising, but there a

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added a comment. Need tot resolve `FIXME`s around `shouldIndexFile()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84811/new/ https://reviews.llvm.org/D84811 ___

[PATCH] D85285: [clangd] WIP experimentation with finding static grpc++ libraries

kbobyrev created this revision. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, LLVM. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monor

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Tests failing so far: Ba

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev planned changes to this revision. kbobyrev added a comment. @sammccall This is the change I was talking about during the standup: the code looks legit, but `BackgroundIndexTests.IndexTwoFiles` fails because with the following code path in `Background.cpp`'s `FileFilter`: const auto *

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev requested review of this revision. kbobyrev added a comment. Even despite `FileFilter` not being fully implemented yet (an issue for a separate patch) I think this change should still be correct and is probably OK to land, WDYT @hokein? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev added a comment. In D84811#2199820 , @hokein wrote: > In D84811#2199510 , @kbobyrev wrote: > >> Even despite `FileFilter` not being fully implemented yet (an issue for a >> separate patch) I think this cha

[PATCH] D85285: [clangd] WIP experimentation with finding static grpc++ libraries

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP, nothing important here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85285/new/ https://reviews.llvm.org/D85285 ___ cfe-commits

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:643 assert(Loc.isValid() && "Invalid source location for NamedDecl"); - // FIXME: use the result to filter out symbols. - shouldIndexFile(SM.getFileID(Loc)); + if (!shouldIndexFil

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added a comment. In D84811#2199891 , @hokein wrote: > In D84811#2199829 , @kbobyrev wrote: > >> In D84811#2199820 , @hokei

[PATCH] D85502: [clangd] Add more error details on the remote index server side

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monore

[PATCH] D85502: [clangd] Add more error details on the remote index server side

kbobyrev updated this revision to Diff 284230. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85502/new/ https://reviews.llvm.org/D85502 Files: clang

[PATCH] D85502: [clangd] Add more error details on the remote index server side

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG836f937a1f11: [clangd] Add more error details on the remote index server side (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85637: [clangd] Fix the background index is not disabled when using remote-index.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Oh, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85637/new/ https://reviews.llvm.org/D85637 __

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Githu

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284609. kbobyrev marked an inline comment as done. kbobyrev added a comment. Handle slash appending in Marshaller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 File

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284611. kbobyrev added a comment. Remove redundant `.str()` calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 Files: clang-tools-extra/clangd/index/remote/Clien

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284648. kbobyrev added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 Files: clang-tools-extra/clangd/index/remote/Client.cpp clang-tools-extra

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1013a4825b: [clangd] Enforce trailing slash for remote index's project root (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

kbobyrev updated this revision to Diff 262036. kbobyrev marked an inline comment as done. kbobyrev added a comment. Make it possible for dexp to include generated headers again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79313/new/ https://revie

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG07f8ca6ab19b: [clangd] NFC: Cleanup unused headers and libraries (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79313/new/ https://re

[PATCH] D79487: [clangd] NFC: Use deprecated grpc++ headers for compatibility

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Ubuntu 18.04 and older versions do not provide latest gRCP packages and the ones that are in

[PATCH] D79487: [clangd] NFC: Use deprecated grpc++ headers for compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c198b550ebb: [clangd] NFC: Use deprecated grpc++ headers for compatibility (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79487/new/

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. YAML serialization was used in the Proof of Concept for simplicity. This patch replaces imple

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

kbobyrev added a comment. Wow, nice work, thank you! Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:51 +public: + // Returns the tokens which are given symbol's characteristics. Currently, the + // generated tokens only contain fuzzy matching trigrams and symbol's sc

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79918/new/ https://reviews.llvm.org/D79918 _

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264190. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a subscriber: mgorny. Add tests for Protobuf (de)serialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264205. kbobyrev added a comment. Simplify test setup and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/in

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264553. kbobyrev added a comment. Don't complicate SymbolCollectorTest, use TestTU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/i

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264554. kbobyrev added a comment. Inline HeaderCode and MainCode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index/remote/Client

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Thank you for the patch, this is a good idea! Comment at: clang-tools-extra/clangd/index/Ref.cpp:11 +#include "llvm/ADT/STLExtras.h" +#includ

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rG968d293063bc: [clang-tidy] NFC: Cleanup Python scripts (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264633. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264873. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tool

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) sammccall wrote: > Can we conditionally include these tests into the main ClangdTests, instead > of setting up anothe

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264874. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Move remote tests into all Clangd tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Fi

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264877. kbobyrev added a comment. Move a comment to the line it corresponds to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) kbobyrev wrote: > sammccall wrote: > > Can we conditionally include these tests into the main ClangdTests, instead >

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added a comment. In D79862#2044073 , @sammccall wrote: > Thanks! Sorry about the hassle with the tests. No worries, I think it looks cleaner and simpler which is important. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b2b784299b: [clangd-remote] Replace YAML serialization with proper Protobuf messages (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 417940. kbobyrev added a comment. Herald added a project: All. Switch to a different model of recording includes that differentiates between user includes and public headers recored through IWYU pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418155. kbobyrev added a comment. Fix a bug, add tests for diagnostics. This is ready for a review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clan

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418159. kbobyrev added a comment. Add some docs, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418160. kbobyrev added a comment. Use better name for header recorder lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/Inclu

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 419378. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb38bfe76b7: [clangd] IncludeCleaner: Add support for IWYU pragma private (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420175. kbobyrev added a comment. Fix the behavior: get Real Path instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/index/Ca

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. This is required for D120306 which was landed but later reverted because of the failing Windows tests (different slash types for filenames requested during preamble parsing and in the main file). Repository: rG LLVM Github Monorepo

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426303 , @kadircet wrote: > note that you seem to be using `auto PublicHeader = > CanonIncludes.mapHeader(Entry->getName());` (i.e. `getName`) in D120306 > and not `tryGetRealPathN

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426382 , @kadircet wrote: >> Right! I think I also need to do that in SymbolCollector.cpp. > > Now that you mentioned this too, it feels like the issue is not about being > consistent, as I think all of the places th

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:73 + auto Filename = SM.getFileEntryForID(SM.getFileID(Range.getBegin())) + ->tryGetRealPathName(); + Includes->addMapping(Filename, isLiteralInclud

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420423. kbobyrev added a comment. Switch to stable file UniqueIDs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.c

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420425. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420426. kbobyrev added a comment. Rebase correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420462. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420500. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Fix the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3de4d5e6dd66: [clangd] Use stable keys for CanonicalIncludes mappings (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3429801 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/55690/step_9.txt > > please take a look, etc :) Should be fixed in https://github.com/llvm/llvm-project/commit/211df7319af

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

kbobyrev added a comment. I think this is no longer [WIP] but rather review-ready, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 ___ cfe-commits mailin

[PATCH] D106432: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Due to the LLVM's J

[PATCH] D106432: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG907efdf95da5: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Take full advantage of AND's it

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91 /// sync. void sync() { ReachedEnd |= Children.front()->reachedEnd(); sammccall wrote: > I stared at this for a while and this change makes me think about th

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360968. kbobyrev added a comment. Add another 7% compared to the patched version: cache Child->peek() in the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528 Fi

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360970. kbobyrev added a comment. Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index

<    2   3   4   5   6   7   8   9   10   11   >