kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/index/remote/Index.cpp:27 + llvm::StringRef SpanName, SymbolIndex::Stub *Stub, ClangdRequestT Request, + std::function<std::unique_ptr<grpc::ClientReader<ReplyT>>( + SymbolIndex::Stub *, grpc::ClientContext *, const RPCRequestT &)> ---------------- sammccall wrote: > Hmm, I think member pointers are totally the right thing here. And all the > params should be deducible. > > Have a look at https://godbolt.org/z/AnprJ- (simplified but self-contained > and I think shows all the bits) > > The thing I can't work out how to do is make the member pointer a template > param *and* have it be deduced... Uh, I had the pointers but decided against it because of rather... bizarre syntax :D And yes, just like you said, the calls contained too many explicit template parameters, so I decided the implementation should be more verbose than "user code". I'm not against pointers, but I think the current version looks simpler, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
