kbobyrev added inline comments.

================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:70
     SymbolCollector::Options Opts;
+    Opts.FileFilter = FileFilter;
     Opts.CountReferences = true;
----------------
hokein wrote:
> `FileFilter` seems more promising, but there are some FIXMEs ("use the result 
> to filter out symbols.") in the SymbolCollector.cpp` -- looks like the 
> SymbolCollector doesn't support this yet, sigh...
Hmm, you are right. However, I tried running the indxer with and without new 
option and the number of symbols & references was different. Hmm, this is 
interesting, I wonder why this happened.

Yeah, I think I should update the code to make sure everything works. Thanks 
for noticing it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84811/new/

https://reviews.llvm.org/D84811

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to