[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett marked 2 inline comments as done. juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:308 - llvm::errs() << "Invalid type for info.\n"; - exit(1); } leonardchan wrote: > Probably not important or it's just

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett marked 2 inline comments as done. juliehockett added a comment. In https://reviews.llvm.org/D48909#1194501, @leonardchan wrote: > Should there be any tests associated with these changes? There are, this is just supposed to be a NFC so the tests don't need to change. They all pass

[PATCH] D48908: [clang-doc] Pass over function-internal declarations

juliehockett closed this revision. juliehockett added a comment. Closed in https://reviews.llvm.org/rL339592. https://reviews.llvm.org/D48908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett closed this revision. juliehockett added a comment. Closed in https://reviews.llvm.org/rL339617. https://reviews.llvm.org/D48909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D50709: [clang-doc] Fix unused var

juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D50709 Files: clang-tools-extra/clang-doc/Mapper.cpp Index: clang-tools-extra/clang-doc/Mapper.cpp ===

[PATCH] D50709: [clang-doc] Fix unused var

This revision was automatically updated to reflect the committed changes. Closed by commit rL339685: [clang-doc] Fix unused variable (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50709?vs=160593&id=160600#t

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

This revision was automatically updated to reflect the committed changes. juliehockett marked an inline comment as done. Closed by commit rCTE339948: Implement a (simple) Markdown generator (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D43424?vs=15

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett reopened this revision. juliehockett added a comment. This revision is now accepted and ready to land. Herald added a subscriber: kadircet. Reopening because it was reverted and I haven't had time to look into it yet Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43

[PATCH] D51137: [clang-doc] Fix memory leaks

juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. Adds a virtual destructor to the base Info class. https://reviews.llvm.org/D51137 Files: clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp Index: c

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145788. juliehockett marked 10 inline comments as done. juliehockett added a comment. Made the check for system headers more comprehensive & fixed newline issues https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fu

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. juliehockett added a project: clang. Herald added subscribers: kbarton, nemanjai. Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective in PPCallbacks, and updating calls to that function. This wil

[PATCH] D46615: [tools] Updating PPCallbacks::InclusionDirective calls

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. juliehockett added a project: clang-tools-extra. Herald added subscribers: jkorous, kbarton, ioeric, nemanjai. [[ https://reviews.llvm.org/D46614 | [https://reviews.llvm.org/D46614] ]] adds SrcMgr::CharacteristicKi

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 145934. juliehockett added a comment. Adding test https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallbacks.cpp lib/CodeGen/MacroPPCallbacks.h lib/Frontend/Depe

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 145941. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing formatting and tests. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCa

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. This will break things in clang-tools-extra without https://reviews.llvm.org/D46615, so I'm going to hold off landing this until that goes through https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commi

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D43341#1093117, @juliehockett wrote: > This will break things in clang-tools-extra without > https://reviews.llvm.org/D46615, so I'm going to hold off landing this until > that goes through Oops wrong patch disregard https://reviews.

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett added a comment. This will break things in clang-tools-extra without https://reviews.llvm.org/D46615, so I'm going to hold off landing this until that goes through https://reviews.llvm.org/D46614 ___ cfe-commits mailing list cfe-commi

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rL331904: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D46615: [tools] Updating PPCallbacks::InclusionDirective calls

This revision was automatically updated to reflect the committed changes. juliehockett marked an inline comment as done. Closed by commit rL331905: [tools] Updating PPCallbacks::InclusionDirective calls (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, ilya-biryuko

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: docs/ReleaseNotes.rst:116 + + Checks for allowed system includes and suggests removal of any others. If no + includes are specified, the check will exit without issuing any warnings. Eugene.Zelenko wrote: > Is it

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145978. juliehockett marked 3 inline comments as done. juliehockett added a comment. Updating the inclusiondirective to filter out non-system files https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaT

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE331930: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module (authored by juliehockett, committed by ). R

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett reopened this revision. juliehockett added a comment. Sorry, branches got crossed. Reverted and reopened. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146032. juliehockett added a comment. Reverted because of memory leak in PPCallbacksTest, this fixes it. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallbacks.c

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146158. juliehockett marked 3 inline comments as done. juliehockett added a comment. Removing unused function https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallba

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146175. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallbacks.cpp lib/CodeGen/MacroPPCallbacks.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGrap

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rC332021: Reland '[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective' (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D46614 Files: include/c

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 146349. juliehockett added a comment. Updating parameter list to be a glob-style list. https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/RestrictSystemIncludesChec

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/RestrictSystemIncludesCheck.h:35 + void storeOptions(ClangTidyOptions::OptionMap &Opts) override; + bool contains(StringRef FileName) { +return AllowedIncludesGlobList.contains(FileName); aa

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

This revision was automatically updated to reflect the committed changes. Closed by commit rL332125: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://rev

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. Pingany more thoughts? https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 147606. juliehockett marked 11 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. Updating for better integration with MR framework, the generator now takes in an info and an output stream and emits t

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett added inline comments. Comment at: clang-doc/generators/Generators.h:49 + +class GeneratorFactory { +public: ioeric wrote: > ioeric wrote: > > Please add documentation and explain why this is needed. > If you plan to plugin in more generators (e.g.

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. ping https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 148678. juliehockett marked 11 inline comments as done. juliehockett added a comment. Reworking the reducer interface a bit to address comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-do

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.h:138 + SymbolID USR = + SymbolID(); // Unique identifier for the decl described by this Info. + const InfoType IT = InfoType::IT_default; // InfoType of this particular Info. ioeric

[PATCH] D51137: [clang-doc] Fix memory leaks

This revision was automatically updated to reflect the committed changes. Closed by commit rL340620: [clang-doc] Fix memory leaks (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51137?vs=162081&id=162399#toc

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL341955: Reland "Implement a (simple) Markdown generator" (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43424?vs=1

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341955: Reland "Implement a (simple) Markdown generator" (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D43424?vs=161123&id=164903#toc Repository: rL L

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added inline comments. Herald added a subscriber: arphaman. Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44 +// CHECK-0: --- +// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210' +// CHECK-0-NEXT: Name:'C' -

[PATCH] D48395: Added PublicOnly flag

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE337602: [clang-doc] Adding PublicOnly flag (authored by juliehockett, committed by ). Herald added a subscriber: arphaman. Changed prior to commit: https://reviews.llvm.org/D48395?vs=154470&id=156562#

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

juliehockett added a comment. In https://reviews.llvm.org/D49158#1159882, @hokein wrote: > In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote: > > > Is there a way to add a test, that would trigger the old segfault and show > > that it does not happen anymore with this fix? > > > +1, w

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added a comment. ping https://reviews.llvm.org/D48341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added a comment. any further thoughts on this? https://reviews.llvm.org/D48341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:246 + + std::vector ChildNamespaces; + std::vector ChildRecords; ioeric wrote: > Would a record ever have namespace children? Maybe we should assert that this > doesn'

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett marked 2 inline comments as done. juliehockett added inline comments. Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106 +// CHECK-0-NEXT: +// CHECK-0-NEXT: +// CHECK-0-NEXT:blob data = 'InnerClass' ioeric wrote: > juliehockett w

[PATCH] D50208: [clang-doc] Fix unique_ptr error on bots

juliehockett created this revision. juliehockett added reviewers: ioeric, lebedev.ri, jakehehrlich, leonardchan. juliehockett added a project: clang-tools-extra. Explicitly declare the return unique_ptr instead of using auto type deduction, as some of the bots' older compilers don't support some

[PATCH] D50208: [clang-doc] Fix unique_ptr error on bots

juliehockett updated this revision to Diff 158872. https://reviews.llvm.org/D50208 Files: clang-tools-extra/clang-doc/Serialize.cpp Index: clang-tools-extra/clang-doc/Serialize.cpp === --- clang-tools-extra/clang-doc/Serialize.cp

[PATCH] D50208: [clang-doc] Fix unique_ptr error on bots

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE338796: [clang-doc] Fix unique_ptr error on bots (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D50208?vs=158872&id=158874#toc Repository: rCTE Clang T

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett updated this revision to Diff 159070. https://reviews.llvm.org/D48909 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeReader.h Index: clang-tools-extra/clang-doc/BitcodeReader.h =

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett updated this revision to Diff 159071. juliehockett marked 2 inline comments as done. https://reviews.llvm.org/D48909 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeReader.h Index: clang-tools-extra/clang-doc/BitcodeReader.h ==

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett updated this revision to Diff 159091. juliehockett marked an inline comment as done. juliehockett added a comment. Herald added a subscriber: arphaman. Updating based on recent landed patches & updated tests https://reviews.llvm.org/D43424 Files: clang-tools-extra/clang-doc/CMake

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133108. juliehockett marked 27 inline comments as done. juliehockett edited the summary of this revision. juliehockett edited projects, added clang-tools-extra; removed clang. juliehockett added a comment. 1. Moved the tool to clang-tools-extra 1. Refac

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDoc.h:29 +struct ClangDocContext { + // Which format in which to emit representation. + OutFormat EmitFormat; sammccall wrote: > juliehockett wrote: > > sammccall wrote: > > > Is this the inte

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL324432: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133714. juliehockett marked 6 inline comments as done. juliehockett added a comment. 1. Implementing the bitstream decoder (and fixing the encoder) 2. Setting up new tests for the mapper output 3. Fixing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133726. juliehockett added a comment. Updating documentation https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/ClangDoc.cpp clang-doc/ClangDoc.h clang-doc/ClangDocBinary.cpp clang-doc/ClangDocBinary.h

[PATCH] D43223: [clang-tidy] Update fuchsia-multiple-inheritance to not fail

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating the fuchsia-multiple-inheritance to gracefully handle unknown record types (e.g. templatized classes) by

[PATCH] D43223: [clang-tidy] Update fuchsia-multiple-inheritance to not fail

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325015: [clang-tidy] Update fuchsia-multiple-inheritance to not fail (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43223 Files: clang-tidy

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett created this revision. juliehockett added reviewers: klimek, sammccall, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D41102: Setup clang-doc frontend framework. Implements a simple, in-memory reducer

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134544. juliehockett edited the summary of this revision. juliehockett added a comment. Updating tests and moving the bitcode reader out (to the next patch) https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 134546. juliehockett edited the summary of this revision. juliehockett added a comment. Moving the entire implementation of the bitcode reader to this patch (from the mapper patch, here ) and cleaning up implementation

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a checker to find a function given its name and add a visibility attribute if none is present (i.e.

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 134684. juliehockett marked 7 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. 1. Added visibility parameter 2. Updated Name parameter to be a list of names, as opposed to a single name 3. Fixed comm

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: mgrang, mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend framework. I

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDocBinary.cpp:88 + Stream.Emit((unsigned)'C', 8); + Stream.Emit((unsigned)'S', 8); +} lebedev.ri wrote: > General comment: shouldn't the bitcode be versioned? Possibly? My understanding of the versi

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134855. juliehockett marked 14 inline comments as done. juliehockett added a comment. 1. Fixing docs 2. Adding static map from bitcode block/record id to block/record name 3. Pulling magic numbers into one struct 4. Cleaning up and clarifying command line

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDoc.cpp:32 + ECtx.reportResult( + Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D))); +} lebedev.ri wrote: > I wonder if `Name` should be `std::move()`'d ? Or not, `reportRes

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135009. juliehockett marked 27 inline comments as done. juliehockett added a comment. 1. Decoupled the mapper implementation from the main program, exposing only the function to generate the action factory 2. Implemented the matchers into a RecursiveASTV

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. > 2. I've mentioned it before as a comment, but to what extent will you be > parsing information in this frontend? Currently the links between types are > primarily stored as strings. Are you planning to have the backend that > generates the MarkDown parse those st

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135168. juliehockett marked 13 inline comments as done. juliehockett added a comment. 1. Updating mapper keys to use USRs instead of names 2. Also updating internal representation to use USRs instead of names 3. Renaming files (getting rid of the ClangDoc

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1011299, @lebedev.ri wrote: > I don't know the protocol, but i think it might be a good idea > to add a new entry to `CODE_OWNERS.TXT` for `clang-doc`? > > `clang-doc` going to be quite distinctive, and bigger/complicated > than w

[PATCH] D43538: [clang-tidy] Update run-clang-tidy.py with config arg

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating the run-clang-tidy.py script to allow specification of the config argument to the clang-tidy invocation.

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135181. juliehockett marked 10 inline comments as done. juliehockett added a comment. Updating check to allow for #pragma and command line visibility specs, and updating tests https://reviews.llvm.org/D43392 Files: clang-tidy/fuchsia/AddVisibilityCh

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68 + diag(MatchedDecl->getLocStart(), + "visibility attribute not set for specified function") + << MatchedDecl aaron.ballman wrote: > jakehehrlich w

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I, + BitstreamWriter &Stream, lebedev.ri wrote: > Hmm, common pattern again > ```

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135305. juliehockett marked 20 inline comments as done. juliehockett added a comment. Cleaning up bitcode writer and fixing pointers for CommentInfos https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/Bitc

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I, + BitstreamWriter &Stream, jakehehrlich wrote: > lebedev.ri wrote: > > julieho

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135342. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating location creation and adding mapping from type to BlockId https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/Bi

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135453. juliehockett marked 13 inline comments as done. juliehockett added a comment. Cleaning up bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.tx

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:219 + +void ClangDocBitcodeWriter::emitIntRecord(int Value, RecordId ID) { + if (!Value) return; lebedev.ri wrote: > Now, all these three `emit*Record` functions now have the 'same signa

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 135520. juliehockett added a comment. Updating for parent diff changes https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135559. juliehockett marked 10 inline comments as done. juliehockett added a comment. Refactoring bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.tx

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend framewor

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett updated this revision to Diff 135583. juliehockett added a comment. Updating based on parent revision changes -- still rough, will continue to improve. https://reviews.llvm.org/D43424 Files: clang-doc/generators/CMakeLists.txt clang-doc/generators/Generators.h clang-doc/gene

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135678. juliehockett marked 29 inline comments as done. juliehockett added a comment. 1. Continued refactoring the bitcode writer 2. Added a USR attribute to infos 3. Created a Reference struct to replace the string references to other infos https://rev

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017499, @Athosvk wrote: > Disadvantage is of course that you add complexity to certain parts of the > deserialization (/serialization) for nested types and inheritance, by either > having to do so in the correct order or having t

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135682. juliehockett added a comment. Fixing CMakeLists formatting https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-doc/ClangDoc.h clang-doc/Mapper.cp

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135944. juliehockett marked 6 inline comments as done. juliehockett added a comment. After discussion, the goal of this checker slightly changed to target definitions in header files, rather than declarations. As a result, the check now adds the attribu

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:52-53 + Finder->addMatcher( + functionDecl(allOf(hasAnyName(SmallVector(Names.begin(), + Names.end())), +

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a check to restrict specific includes. Given a list of includes that should not be used, the

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017918, @lebedev.ri wrote: > Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if > trying to output some recordid > which is, according to the `BLOCKINFO_BLOCK`, should not be there? > E.g. outputting `V

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136010. juliehockett marked 10 inline comments as done. juliehockett added a comment. 1. Moved the serialization logic out of the Mapper class and into its own namespace 2. Updated tests 3. Addressing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 127033. juliehockett added a comment. Updating checker to only warn on declarations. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett marked 3 inline comments as done. juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 127053. juliehockett marked 8 inline comments as done. https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h tools/clang-doc/ClangDocReporter.cpp too

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.h:35 + +struct StringPair { + std::string Key; JDevlieghere wrote: > Do you still need this? Yes, it's used to serialize the map to yaml. https://reviews.llvm.org/D41102 __

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

This revision was automatically updated to reflect the committed changes. juliehockett marked 4 inline comments as done. Closed by commit rL320841: [clang-tidy] Adding Fuchsia checker for virtual inheritance (authored by juliehockett, committed by ). Herald added a subscriber: klimek. Changed pri

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if an operator is overloaded, except move and copy operators.

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127799. juliehockett marked 7 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/OverloadedOp

  1   2   3   4   5   >