[PATCH] D97264: [RISCV] Define types for Zvlsseg.

2021-02-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 325987. HsiangKai added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/B

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-03 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 349750. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDec

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-03 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 349751. HsiangKai added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDecl.cp

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

2021-06-03 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 349754. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 Files: clang/include/clang/Basic/IdentifierTable.h clang/in

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-05 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 350035. HsiangKai added a comment. Simplify the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2b13ff697946: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

2021-06-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 354117. HsiangKai added a comment. Split vlseg and vlseg_ff tests in two different files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 Files: clang/include/cla

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

2021-06-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104822/new/ https://reviews.llvm.org/D104822

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

2021-07-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D106939#2915134 , @HsiangKai wrote: > In D106939#2912807 , @frasercrmck > wrote: > >> LGTM but there are test failures. Is that just a whole load of `mu->ma` >> changes that have be

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

2021-07-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, khchen, kito-cheng, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jo

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

2021-07-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 363241. HsiangKai added a comment. Use '^' instead of '@2'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107139/new/ https://reviews.llvm.org/D107139 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

2021-07-31 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b33839f010f: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

2021-08-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, rogfer01, frasercrmck, khchen. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

2021-08-08 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 365065. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107433/new/ https://reviews.llvm.org/D107433 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

2021-08-09 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5f996705e0ca: [RISCV] Half-precision for vget/vset. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107433/new/ https://reviews.llvm.

[PATCH] D106738: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

2021-08-11 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106738/new/ https://reviews.llvm.org/D106738

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

2021-06-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c:13 +// ASM-NOT: warning #include craig.topper wrote: > Do you plan to bring back the ASM check for all tests? No, I will remove it. This is the first patch

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

2021-06-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

2021-06-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 355420. HsiangKai added a comment. - Use constant value for tail policy argument. - Rename HasPolicy to HasPolicyOp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

2021-07-05 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Is it possible to land these Zvlsseg patches before LLVM 13 branch created? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 __

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

2021-07-06 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG593bf9b4ded3: [Clang][RISCV] Implement vlseg and vlsegff. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

2021-07-08 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105626/new/ https://reviews.llvm.org/D105626

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

2021-07-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 357716. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlsseg

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

2021-07-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 357717. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c __

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

2021-07-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 357718. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103871/new/ https://reviews.llvm.org/D103871 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsseg.

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

2021-07-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 357719. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103872/new/ https://reviews.llvm.org/D103872 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssseg

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

2021-07-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 357720. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsoxse

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103871/new/ https://reviews.llvm.org/D103871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103872/new/ https://reviews.llvm.org/D103872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

2021-07-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

2021-07-13 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 358205. HsiangKai added a comment. Add the TA argument to most of the intrinsics with mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: clang/include/c

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-10-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: kito-cheng, craig.topper, frasercrmck, rogfer01. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-10-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 382298. HsiangKai added a comment. Remove redundant test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td clang/in

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-10-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 382529. HsiangKai added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td cl

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-10-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D111617#3076994 , @rogfer01 wrote: > In D111617#3060377 , @HsiangKai > wrote: > >> Although it reduces the header size, this patch will increase the binary >> size of clang. > > Opt

[PATCH] D97825: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

2021-03-02 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added a reviewer: craig.topper. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook. HsiangKai requested review of this revision. Herald added a

[PATCH] D97825: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

2021-03-02 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e675b3da1d: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D97826: [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

2021-03-03 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97826/new/ https://reviews.llvm.org/D97826 __

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

2021-03-14 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27,

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 387472. HsiangKai added a comment. Herald added subscribers: VincentWu, luke957, mgrang. Restructure the data structure to reuse information between C intrinsics. In this way, we can have a smaller binary size and speed up the lookup for the C intrinsics.

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 387488. HsiangKai added a comment. Check required extensions when adding the declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/cl

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 387489. HsiangKai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/B

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-17 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. The clang binary size increases about +1.4%. Compared to +2.3% previously, it is better in the implementation. The test time of lit testing under `clang/test/CodeGen/RISCV/` is 25.59s. It spends 112.07s without this patch in my local environment. Repository: rG LL

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 31. HsiangKai added a comment. Update the implementation of getMangledName(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-11-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 390198. HsiangKai added a comment. Address a part of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic/CMakeLists.txt c

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-12-05 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 391948. HsiangKai added a comment. - Use unique_ptr. - Avoid to create static global constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/in

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

2022-08-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: aemerson, paquette. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. HsiangKai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. AArch64 only

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

2022-08-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 455454. HsiangKai added a comment. Make the test lines consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https://reviews.llvm.org/D132538 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

2022-08-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/test/Driver/mcmodel.c:9 // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: %clang -target aarch64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: %

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

2022-08-25 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa8690143057b: [AArch64] Filter out invalid code model in frontend. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https:

[PATCH] D45045: [DebugInfo] Generate DILabel metadata for labels.

2018-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 140423. HsiangKai retitled this revision from "[DebugInfo] Generate debug information about labels" to "[DebugInfo] Generate DILabel metadata for labels.". HsiangKai edited the summary of this revision. HsiangKai added a comment. 1. No generating llvm.dbg.l

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

2018-04-02 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 140627. HsiangKai retitled this revision from "[DebugInfo] Generate DILabel metadata for labels." to "[DebugInfo] Generate debug information for labels.". HsiangKai edited the summary of this revision. Herald added a subscriber: eraman. Repository: rC Cla

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

2018-04-11 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 141989. HsiangKai added a comment. Update the test case for inlined functions. The inlined label will attach to DISubprogram(..., labels: !n) Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeb

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339602. HsiangKai added a comment. Add clang attribute `clang_builtin_alias`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Att

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339606. HsiangKai added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. @aaron.ballman, could you help me to review it again? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 ___ cfe-commits mailing

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D100821#2707667 , @rogfer01 wrote: > I can reproduce the crash above in my computer, so something is definitely > off. > > Looks like we emit this > > case RISCV::BI__builtin_rvv_vmmv_m_b8: > case RISCV::

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HsiangKai marked an inline comment as done. Closed by commit rG14cc1cb22230: [RISCV] Implement the vneg.v builtin. (authored by HsiangKai). Changed prior to commit:

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339875. HsiangKai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://reviews.llvm.org/D100821 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/R

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339876. HsiangKai added a comment. Use new defined intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339879. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td clang/tes

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D100821#2711395 , @rogfer01 wrote: > In D100821#2710998 , @HsiangKai > wrote: > >> Rebase. > > Thanks, I had missed that and my comment above was wrong. That's fine. Thanks for your

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/include/clang/Basic/Attr.td:646 +def BuiltinAlias : Attr { + let Spellings = [Clang<"clang_builtin_alias">]; + let Args = [IdentifierArgument<"BuiltinName">]; aaron.ballman wrote: > Hrm, this is interesting --

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 340232. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG108864397d26: [Clang] Add clang attribute `clang_builtin_alias`. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D10061

[PATCH] D100658: [RISCV] Apply clang_builtin_alias to overloaded builtins.

2021-04-25 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8fa5ef6a297: [RISCV] Apply clang_builtin_alias to overloaded builtins. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2434172cc1: [RISCV] Implement the vmmv.m/vmnot.m builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100821?vs=339875&id=340442#toc Repository: rG LLVM Github Monor

[PATCH] D100822: [RISCV] Implement the vfabs.v/vfneg.v builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb3fca7e110: [RISCV] Implement the vfabs.v/vfneg.v builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100822?vs

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG645c5f27a84d: [RISCV] Implement the pseudo compare builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100823?vs=339879&id=340444#toc Repository: rG LLVM Github Monor

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

2021-04-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D99741#2721669 , @craig.topper wrote: > In D99741#2721596 , @thakis wrote: > >> In D99741#2721235 , @craig.topper >> wrote: >> >>> I believe w

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

2021-05-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: khchen, arcbbb. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

2021-05-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc04c66d705b4: [RISCV] Consider scalar types for required extensions. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/ http

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-12-09 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D111617#3175167 , @craig.topper wrote: > In D111617#3060377 , @HsiangKai > wrote: > >> Although it reduces the header size, this patch will increase the binary >> size of clang. >>

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-12-09 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Release build: Before this patch: text data bssdec hex 115471733 7987112 443760 123902605 7629a8d ./bin/clang After this patch: text data bssdec hex 117568981 7996376 443760 1260

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

2021-12-09 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D111617#3183146 , @HsiangKai wrote: > Release build: > Before this patch: > > text data bssdec hex > 115471733 7987112 443760 123902605 7629a8d ./bin/clang > > After this patch:

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Herald added subscribers: VincentWu, luke957. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; craig.topper wrote: > Is c

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; HsiangKai wrote: > craig.topper wrote: > > Is constant still used? > Yes

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-15 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 394751. HsiangKai added a comment. Address @craig.topper and @frasercrmck's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/B

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-16 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 394766. HsiangKai added a comment. Fix build errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-16 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 394782. HsiangKai added a comment. Herald added a subscriber: jdoerfert. Update attribute test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

2021-12-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 395365. HsiangKai added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. In riscv-insert-vsetvli, use the policy argument. No use implicit-def maskedoff to adjust the setting. Repository: rG LLVM Github Monorep

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

2021-12-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llvm.org/D115430

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

2021-03-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, efriedma, c-rhodes, sdesmalen, rogfer01, frasercrmck, david-arm. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

2021-03-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 333806. HsiangKai added a comment. Use 'vr' for vector registers and 'vm' for vector mask registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98616/new/ https://reviews.llvm.org/D98616 Files: clang/li

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

2021-03-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5821a58d8e4c: [RISCV] Add inline asm constraint 'vr' and 'vm' in Clang for RISC-V 'V'. (authored by HsiangKai). Repository: rG LLVM Github Monore

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 334145. HsiangKai edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99482/new/ https://reviews.llvm.org/D99482 Files: clang/lib/CodeGen/CGCall.cpp Index: clang/lib/CodeGen/

[PATCH] D99590: [Clang] Do not use memcpy for struct copy.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For scalable struct types, we do not know the

[PATCH] D99592: [PoC][Clang] Use TypeSize instead of uint64_t for getTypeAllocSize().

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The return type of getTypeAllocSize() is TypeS

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 334150. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/Builtins.def clang/include/clang/Bas

[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99528/new/ https://reviews.llvm.org/D99528 __

[PATCH] D99610: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.

2021-03-30 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99610/new/ https://reviews.llvm.org/D99610 __

<    1   2   3   >