Re: r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-28 Thread Hans Wennborg via cfe-commits
Should we merge this to 3.9? Cheers, Hans On Thu, Jul 28, 2016 at 7:29 AM, Samuel Antao via cfe-commits wrote: > Author: sfantao > Date: Thu Jul 28 09:29:18 2016 > New Revision: 276979 > > URL: http://llvm.org/viewvc/llvm-project?rev=276979&view=rev > Log: > [OpenMP][CUDA] Do not forward OpenMP

Re: r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-28 Thread Hans Wennborg via cfe-commits
I've merged it in r277004. Cheers, Hans On Thu, Jul 28, 2016 at 10:15 AM, Samuel F Antao wrote: > Hi Hans, > > I think it should. All the stuff that enables this fix seems to be in 3.9 > already. > > Thanks! > Samuel > > > > - Original message - > From: Hans Wennborg > Sent by: hwennb..

Re: r276653 - Support '#pragma once' in headers when using PCH

2016-07-28 Thread Hans Wennborg via cfe-commits
The change seems straight-forward, well reviewed and has been in the tree for a while, so I've merged it to 3.9 in r277075. Thanks, Hans On Mon, Jul 25, 2016 at 1:51 PM, Hans Wennborg wrote: > Should me merge this to 3.9? > > On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits >

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-28 Thread Hans Wennborg via cfe-commits
Sorry, I was supposed to chime in here. I don't have a strong opinion on this, but I don't think it's a problem for us to allow the -gline-tables-only spelling in addition to /Zd. It just doesn't seem like a big deal to me. On Mon, Jul 11, 2016 at 5:50 PM, Saleem Abdulrasool via cfe-commits wro

Re: r274991 - [clang-cl] Add support for /Zd

2016-07-29 Thread Hans Wennborg via cfe-commits
On Fri, Jul 29, 2016 at 10:12 AM, Nico Weber wrote: > On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote: >> >> Sorry, I was supposed to chime in here. >> >> I don't have a strong opinion on this, but I don't think it's a >> problem for us to allow the -gline-tables-only spelling in addition to

Re: r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-29 Thread Hans Wennborg via cfe-commits
The test was failing on 3.9 on my Mac, and I noticed there were some follow-up commits, so I've merged r276983, r277138, r277141 in r277193. On Thu, Jul 28, 2016 at 10:18 AM, Hans Wennborg wrote: > I've merged it in r277004. > > Cheers, > Hans > > On Thu, Jul 28, 2016 at 10:15 AM, Samuel F Antao

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Hans Wennborg via cfe-commits
Yes, it still appears to be broken: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/26504/steps/run%20tests/logs/stdio On Thu, Jul 28, 2016 at 1:30 PM, Samuel F Antao via cfe-commits wrote: > Hi Mike, > > I've already pushed r276981 and r276988 to fix those failures shortly after > I

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Hans Wennborg via cfe-commits
I agree this looks like a compiler bug, but I'm not sure what's causing it exactly. Putting "this->" in front of those accesses to CurDir and CGF seems to fix it, but it's also very ugly. I tried a couple of other things, like moving the method out-of-line, but no luck yet. On Fri, Jul 29, 2016 a

[libcxx] r277236 - Creating release candidate rc1 from release_390 branch

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:20 2016 New Revision: 277236 URL: http://llvm.org/viewvc/llvm-project?rev=277236&view=rev Log: Creating release candidate rc1 from release_390 branch Added: libcxx/tags/RELEASE_390/rc1/ (props changed) - copied from r277235, libcxx/branches/release_

[libcxx] r277235 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:17 2016 New Revision: 277235 URL: http://llvm.org/viewvc/llvm-project?rev=277235&view=rev Log: Creating release directory for release_390. Added: libcxx/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commits@

[libcxxabi] r277237 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:24 2016 New Revision: 277237 URL: http://llvm.org/viewvc/llvm-project?rev=277237&view=rev Log: Creating release directory for release_390. Added: libcxxabi/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commi

[libcxxabi] r277238 - Creating release candidate rc1 from release_390 branch

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:26 2016 New Revision: 277238 URL: http://llvm.org/viewvc/llvm-project?rev=277238&view=rev Log: Creating release candidate rc1 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc1/ - copied from r277237, libcxxabi/branches/release_39/ ___

[libunwind] r277249 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:51 2016 New Revision: 277249 URL: http://llvm.org/viewvc/llvm-project?rev=277249&view=rev Log: Creating release directory for release_390. Added: libunwind/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commi

[libunwind] r277250 - Creating release candidate rc1 from release_390 branch

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:54 2016 New Revision: 277250 URL: http://llvm.org/viewvc/llvm-project?rev=277250&view=rev Log: Creating release candidate rc1 from release_390 branch Added: libunwind/tags/RELEASE_390/rc1/ (props changed) - copied from r277249, libunwind/branches/re

r277256 - Fix VS2013 build of CGOpenMPRuntime.cpp

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 19:41:37 2016 New Revision: 277256 URL: http://llvm.org/viewvc/llvm-project?rev=277256&view=rev Log: Fix VS2013 build of CGOpenMPRuntime.cpp It seems the compiler was getting confused by the in-class initializers in local struct MapInfo, so moving those to a default

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Hans Wennborg via cfe-commits
It seems the compiler was getting thrown off by the in-class initializers of the local MapInfo struct. I've tried to work around this in r277256. Hopefully this will make the buildbots happier. Cheers, Hans On Fri, Jul 29, 2016 at 2:20 PM, Samuel F Antao wrote: > Hi Hans, > > Thanks for the trou

Re: [Diffusion] rL277097: [clang-tidy] Fixes to modernize-use-emplace

2016-08-01 Thread Hans Wennborg via cfe-commits
Merged in r277385. Cheers, Hans On Fri, Jul 29, 2016 at 3:58 PM, Piotr Padlewski wrote: > It would be very good to import this patch to clang-tidy-3.9 > > > -- Forwarded message -- > From: Piotr Padlewski > Date: 2016-07-28 19:18 GMT-07:00 > Subject: Re: [Diffusion] rL277097: [c

Re: r277221 - Remove unused variable.

2016-08-01 Thread Hans Wennborg via cfe-commits
Merged in r277384. Cheers, Hans On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher wrote: > Hi Hans, > > Can you make sure this makes it into 3.9 please? > > Thanks! > > -eric > > > On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits > wrote: >> >> Author: echristo >> Date: Fri Jul

Re: r277307 - Add more gcc compatibility names to clang's cpuid.h

2016-08-01 Thread Hans Wennborg via cfe-commits
Go ahead (or let me know if you'd prefer me to do it). Cheers, Hans On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote: > Hi Hans, > > I would like to merge this one to release_39, since it fixes a few third > party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros. > > -

r277405 - Revert r276896 "Update Clang Parser test error message to match new parser errors"

2016-08-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Aug 1 18:34:42 2016 New Revision: 277405 URL: http://llvm.org/viewvc/llvm-project?rev=277405&view=rev Log: Revert r276896 "Update Clang Parser test error message to match new parser errors" This depended on r276895, which was reverted in r277402. Modified: cfe/trunk/

Re: r276896 - Update Clang Parser test error message to match new parser errors

2016-08-01 Thread Hans Wennborg via cfe-commits
Reverted in r277405 since the LLVM change got reverted. For what it's worth, it would have been great if this commit mentioned that it was a companion commit to r276895. That would give some nice context for anyone reading the log, and also I wouldn't have missed it when reverting the LLVM side.

Re: r277095 - [Parser] Fix bug where delayed typo in conditional expression was corrected twice

2016-08-02 Thread Hans Wennborg via cfe-commits
Should we merge this to 3.9? Thanks, Hans On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Thu Jul 28 19:55:40 2016 > New Revision: 277095 > > URL: http://llvm.org/viewvc/llvm-project?rev=277095&view=rev > Log: > [Parser] Fix bug where delayed typo

Re: r277095 - [Parser] Fix bug where delayed typo in conditional expression was corrected twice

2016-08-02 Thread Hans Wennborg via cfe-commits
Merged in r277525. Thanks, Hans On Tue, Aug 2, 2016 at 2:33 PM, Erik Pilkington via cfe-commits wrote: > Sure, this is a pretty harmless bugfix. > Cheers, > Erik > >> On Aug 2, 2016, at 11:05 AM, Hans Wennborg wrote: >> >> Should we merge this to 3.9? >> >> Thanks, >> Hans >> >> On Thu, Jul 28,

Re: Diagnostics improvements for 3.9

2016-08-05 Thread Hans Wennborg via cfe-commits
These all sgtm for 3.9. Go ahead and merge with utils/release/merge.sh, or I'll do it when I get in on Monday. Cheers, Hans On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: > Typos and unused test variables fixed in r277900 > > On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: >> >> On F

Re: r277743 - [OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.

2016-08-08 Thread Hans Wennborg via cfe-commits
Okay, merged in r278019. Cheers, Hans On Fri, Aug 5, 2016 at 9:36 AM, Anastasia Stulova wrote: > Hans, > > If still possible could we merge this into 3.9. It contains just a minor > renaming but it makes all those new OpenCL Builtins usable. > > Thanks, > Anastasia > > -Original Message

Re: Diagnostics improvements for 3.9

2016-08-08 Thread Hans Wennborg via cfe-commits
I've merged the lot in r278020. Thanks, Hans On Fri, Aug 5, 2016 at 7:43 PM, Hans Wennborg wrote: > These all sgtm for 3.9. Go ahead and merge with > utils/release/merge.sh, or I'll do it when I get in on Monday. > > Cheers, > Hans > > On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: >> Typ

[libunwind] r278023 - Merging r277868:

2016-08-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Aug 8 12:18:56 2016 New Revision: 278023 URL: http://llvm.org/viewvc/llvm-project?rev=278023&view=rev Log: Merging r277868: r277868 | compnerd | 2016-08-05 14:35:28 -0700 (Fri, 05 Aug 2016) | 4 lines

Re: [libunwind] r277868 - unwind: disable executable stacks

2016-08-08 Thread Hans Wennborg via cfe-commits
Okay, r278023. Thanks, Hans On Fri, Aug 5, 2016 at 2:46 PM, Saleem Abdulrasool wrote: > On Fri, Aug 5, 2016 at 2:35 PM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Fri Aug 5 16:35:28 2016 >> New Revision: 277868 >> >> URL: http://llvm.org/viewvc/llvm-project?rev

[libunwind] r278043 - Merging r278029 with version number adjusted:

2016-08-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Aug 8 15:04:18 2016 New Revision: 278043 URL: http://llvm.org/viewvc/llvm-project?rev=278043&view=rev Log: Merging r278029 with version number adjusted: r278029 | eugenezelenko | 2016-08-08 10:56:28 -0

Re: [libunwind] r278029 - CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing.

2016-08-08 Thread Hans Wennborg via cfe-commits
Merged to 3.9 in r278043 with the version number adjusted. On Mon, Aug 8, 2016 at 10:56 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:56:28 2016 > New Revision: 278029 > > URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev > Log: > CMakeLists.tx

[libcxxabi] r278044 - Merging r278030 with version number adjusted:

2016-08-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Aug 8 15:06:27 2016 New Revision: 278044 URL: http://llvm.org/viewvc/llvm-project?rev=278044&view=rev Log: Merging r278030 with version number adjusted: r278030 | eugenezelenko | 2016-08-08 10:59:02 -0

Re: [libcxxabi] r278030 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

2016-08-08 Thread Hans Wennborg via cfe-commits
Merged to 3.9 in r278044 with the version number adjusted. On Mon, Aug 8, 2016 at 10:59 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:59:02 2016 > New Revision: 278030 > > URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev > Log: > CMakeLists.tx

Re: [libcxx] r278032 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

2016-08-08 Thread Hans Wennborg via cfe-commits
I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to have always been trunk-svn, and it's at least not as misleading as having the wrong number. I wonder if PACKAGE_VERSION is actually important for anything in libcxx, libcxxabi and libunwind? At least for libcxx, the important vers

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

2016-08-08 Thread Hans Wennborg via cfe-commits
Richard: ping? On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote: > Should this be merged to 3.9? > > Thanks, > Hans > > On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits > wrote: >> Author: epilk >> Date: Wed Jul 27 13:25:10 2016 >> New Revision: 276900 >> >> URL: http://llvm

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-09 Thread Hans Wennborg via cfe-commits
For the record, this was for PR28666. Richard: what do you think about merging this to 3.9? On Tue, Aug 2, 2016 at 2:07 PM, Devin Coughlin via cfe-commits wrote: > Author: dcoughlin > Date: Tue Aug 2 16:07:23 2016 > New Revision: 277522 > > URL: http://llvm.org/viewvc/llvm-project?rev=277522&vi

Re: r278139 - [clang-cl] Make -gline-tables-only imply -gcodeview

2016-08-10 Thread Hans Wennborg via cfe-commits
Sure, r278240. On Wed, Aug 10, 2016 at 3:55 AM, Nico Weber wrote: > Since this flag is new in 3.9, should we merge this there? > > On Tue, Aug 9, 2016 at 1:23 PM, Reid Kleckner via cfe-commits > wrote: >> >> Author: rnk >> Date: Tue Aug 9 12:23:56 2016 >> New Revision: 278139 >> >> URL: http://

Re: r278234 - [OpenCL] Change block descriptor address space to constant.

2016-08-10 Thread Hans Wennborg via cfe-commits
Merged together with r278235 in r278248. Thanks, Hans On Wed, Aug 10, 2016 at 10:25 AM, Anastasia Stulova via cfe-commits wrote: > Hi Hans, > > Is it still possible to merge this change in release 3.9 branch. This is just > a minor bug fix we have found with Clang Blocks and only affects OpenCL

Re: [libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

2016-08-10 Thread Hans Wennborg via cfe-commits
Should we merge this to 3.9? Looks like a straight-forward fix for something that was hit by real code. Thanks, Hans On Wed, Aug 10, 2016 at 1:04 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Wed Aug 10 15:04:46 2016 > New Revision: 278282 > > URL: http://llvm.org/viewvc/ll

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

2016-08-11 Thread Hans Wennborg via cfe-commits
Merged in r278374. Thanks, Hans On Thu, Aug 11, 2016 at 11:07 AM, Richard Smith wrote: > Yes, this should be merged. It's not quite right, but it's certainly better > than what we had before. > > On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote: >> >> Richard: ping? >> >> On Wed, Jul 27, 201

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

2016-08-11 Thread Hans Wennborg via cfe-commits
Merged in r278376. Thanks, Hans On Thu, Aug 11, 2016 at 11:13 AM, Richard Smith wrote: > Well, the whole approach here is still wrong (per the FIXME in > CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. > Let's take this for 3.9 to at least stem the bleeding. > > > On

[libcxx] r278425 - Merging r278387:

2016-08-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 11 16:47:28 2016 New Revision: 278425 URL: http://llvm.org/viewvc/llvm-project?rev=278425&view=rev Log: Merging r278387: r278387 | marshall | 2016-08-11 11:46:24 -0700 (Thu, 11 Aug 2016) | 1 line R

Re: [libcxx] r278387 - Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936

2016-08-11 Thread Hans Wennborg via cfe-commits
Merged to 3.9 in r278425, as the PR was marked as a release blocker. On Thu, Aug 11, 2016 at 11:46 AM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Thu Aug 11 13:46:24 2016 > New Revision: 278387 > > URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev > Log: > Remove t

[libcxx] r278426 - Merging r278282:

2016-08-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 11 16:48:37 2016 New Revision: 278426 URL: http://llvm.org/viewvc/llvm-project?rev=278426&view=rev Log: Merging r278282: r278282 | marshall | 2016-08-10 13:04:46 -0700 (Wed, 10 Aug 2016) | 1 line s

Re: [libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

2016-08-11 Thread Hans Wennborg via cfe-commits
I've gone ahead and merged it in r278426. On Wed, Aug 10, 2016 at 5:19 PM, Eric Fiselier wrote: > I would support merging this change. > > /Eric > > On Wed, Aug 10, 2016 at 3:20 PM, Hans Wennborg via cfe-commits > wrote: >> >> Should we merge this to 3.9? Lo

[libcxx] r278538 - Merging r278357:

2016-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 12 12:59:24 2016 New Revision: 278538 URL: http://llvm.org/viewvc/llvm-project?rev=278538&view=rev Log: Merging r278357: r278357 | compnerd | 2016-08-11 09:58:12 -0700 (Thu, 11 Aug 2016) | 6 lines

Re: [libcxx] r278357 - test: relax the FS test a slight bit to be more reliable

2016-08-12 Thread Hans Wennborg via cfe-commits
On Thu, Aug 11, 2016 at 8:50 PM, Saleem Abdulrasool wrote: > On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Thu Aug 11 11:58:12 2016 >> New Revision: 278357 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev >> Log: >>

Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

2016-08-12 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm! Please commit to https://llvm.org/svn/llvm-project/cfe/branches/release_39 or let me know if you'd prefer me to do it. Comment at: docs/ReleaseNotes.rst:206 @@ +205,3 @@ +

Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

2016-08-12 Thread Hans Wennborg via cfe-commits
hans added a comment. In https://reviews.llvm.org/D23452#514110, @Anastasia wrote: > Thanks! Is there a way to check the doc before committing? I am not sure how > to make the html generated out of this. I build the docs like this: cmake -GNinja -DLLVM_ENABLE_SPHINX=ON -DLLVM_BUILD_DOCS=ON

[libcxxabi] r278675 - Merging r278579:

2016-08-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Aug 15 11:10:06 2016 New Revision: 278675 URL: http://llvm.org/viewvc/llvm-project?rev=278675&view=rev Log: Merging r278579: r278579 | mehdi_amini | 2016-08-12 17:02:33 -0700 (Fri, 12 Aug 2016) | 3 line

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-15 Thread Hans Wennborg via cfe-commits
Merged in r278675. Thanks! On Fri, Aug 12, 2016 at 5:54 PM, Mehdi Amini wrote: > CC hans. > > >> On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith >> wrote: >> >> This seems like a good candidate to cherry-pick to 3.9. >> >>> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits >>> wrote:

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

2016-08-15 Thread Hans Wennborg via cfe-commits
hans added a comment. > [This is my first time submitting 'pull requests' for a specific branch. I > checked-out the respective release branches for llvm and clang, and reverted > the above commit (resolved a conflict in the process) and created a patch. My > box is currently still compiling an

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

2016-08-15 Thread Hans Wennborg via cfe-commits
hans added a comment. Faisal: go ahead and commit directly to the branch, or let me know if you'd like me to do it. https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

2016-02-01 Thread Hans Wennborg via cfe-commits
On Fri, Jan 29, 2016 at 4:50 PM, Alexey Samsonov wrote: > > On Fri, Jan 29, 2016 at 3:16 PM, Hans Wennborg wrote: >> >> Yes, that seems like a good idea. Go ahead and merge (or let me know >> if you'd prefer me to do it). > > > I'd appreciate if you could do it. Thanks! r259371. Thanks. >> On F

Re: r257710 - [Sema] Suppress diags in overload resolution.

2016-02-01 Thread Hans Wennborg via cfe-commits
Thanks! r259412. On Mon, Feb 1, 2016 at 1:32 PM, Richard Smith wrote: > LGTM for 3.8. > > On Wed, Jan 13, 2016 at 4:03 PM, Hans Wennborg wrote: >> Thanks! Richard, what say the code owner? >> >> On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV >> wrote: >>> FYI: This patch should to be merged

Re: r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

2016-02-01 Thread Hans Wennborg via cfe-commits
Thanks! r259414. On Mon, Feb 1, 2016 at 1:36 PM, Richard Smith wrote: > LGTM for 3.8. > > On Thu, Jan 21, 2016 at 1:10 PM, Hans Wennborg wrote: >> Richard, it was suggested (in >> https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged >> to 3.8. I believe this falls under your own

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

2016-02-01 Thread Hans Wennborg via cfe-commits
Marshall: ping? On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: > On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: >> On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote: >>> On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits >>> wrote: Author: marshall Date

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

2016-02-01 Thread Hans Wennborg via cfe-commits
On Mon, Feb 1, 2016 at 1:53 PM, Richard Smith wrote: > On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg wrote: >> I don't think we have a specific code owner for OpenCL in Clang, which >> means Richard is the owner. >> >> Richard, what do you think? > > Is there a reason we want to push this new f

[libcxx] r259564 - Creating release candidate rc2 from release_380 branch

2016-02-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 2 15:10:52 2016 New Revision: 259564 URL: http://llvm.org/viewvc/llvm-project?rev=259564&view=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxx/tags/RELEASE_380/rc2/ (props changed) - copied from r259563, libcxx/branches/release_

[libunwind] r259571 - Creating release candidate rc2 from release_380 branch

2016-02-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 2 15:11:13 2016 New Revision: 259571 URL: http://llvm.org/viewvc/llvm-project?rev=259571&view=rev Log: Creating release candidate rc2 from release_380 branch Added: libunwind/tags/RELEASE_380/rc2/ - copied from r259570, libunwind/branches/release_38/ ___

[libcxxabi] r259565 - Creating release candidate rc2 from release_380 branch

2016-02-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 2 15:10:55 2016 New Revision: 259565 URL: http://llvm.org/viewvc/llvm-project?rev=259565&view=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc2/ (props changed) - copied from r259564, libcxxabi/branches/re

Re: r259598 - Work around build failure due to GCC 4.8.1 bug. We don't completely understand

2016-02-02 Thread Hans Wennborg via cfe-commits
Yes! r259603. Cheers, Hans On Tue, Feb 2, 2016 at 3:17 PM, Richard Smith wrote: > Hans, this fixes a compile failure with one of our supported host > compilers (GCC 4.8.1). Can we get this patch into 3.8? > > On Tue, Feb 2, 2016 at 3:11 PM, Richard Smith via cfe-commits > wrote: >> Author: rsmi

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

2016-02-03 Thread Hans Wennborg via cfe-commits
On Wed, Feb 3, 2016 at 1:00 PM, Richard Smith wrote: > On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova > wrote: >> >> I think the main reason is that we have committed pipe type before the >> release branch was taken. It appears to have no use without the pipe builtin >> functions. >> >> Are t

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

2016-02-03 Thread Hans Wennborg via cfe-commits
I'm OK if Marshall is. Thanks, Hans On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via cfe-commits wrote: > Hans, do you mind merging this to the 3.8 branch? > > Marshall, do you agree this is okay to take? > >> On 2016-Feb-03, at 11:30, Duncan P. N. Exon Smith via cfe-commits >> wrot

Re: r259183 - Add target triple to CodeGenOpenCL/pipe_types.cl test case

2016-02-04 Thread Hans Wennborg via cfe-commits
Sure, r259808. Thanks, Hans On Thu, Feb 4, 2016 at 10:13 AM, Ulrich Weigand wrote: > Hans, > > would it be OK to backport this test case fix to the 3.8 branch? > This is currently the only failing test on the branch for SystemZ. > > Thanks! > >>Author: uweigand >>Date: Fri Jan 29 04:45:23 2016 >

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

2016-02-05 Thread Hans Wennborg via cfe-commits
It was requested that this be merged to 3.8 as it fixes PR25804. Manuel: does this look OK for the branch? Thanks, Hans On Fri, Feb 5, 2016 at 10:29 AM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Fri Feb 5 12:29:24 2016 > New Revision: 259898 > > URL: http://llvm.org/view

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

2016-02-05 Thread Hans Wennborg via cfe-commits
Probably not (unless someone corrects me). In that case, it can wait for the next release. Thanks, Hans On Fri, Feb 5, 2016 at 11:02 AM, Aaron Ballman wrote: > Is PR25804 a regression? > > ~Aaron > > On Fri, Feb 5, 2016 at 1:59 PM, Hans Wennborg via cfe-commits > wrote: &

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

2016-02-05 Thread Hans Wennborg via cfe-commits
Merged in r259939. Cheers, Hans On Fri, Feb 5, 2016 at 2:06 PM, Ulrich Weigand wrote: > Hans, > > this is one more patch that should go into 3.8 -- it fixes miscompiles of > code using GCC-provided C++11 system headers like . > > With this patch, the test suite is now clean also with a bootstrap

Re: [PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

2016-02-08 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

2016-02-10 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r260449 - Revert r260388 "[MS ABI] Never reference dllimport'd vtables"

2016-02-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 10 16:18:37 2016 New Revision: 260449 URL: http://llvm.org/viewvc/llvm-project?rev=260449&view=rev Log: Revert r260388 "[MS ABI] Never reference dllimport'd vtables" This caused the compiler to fail with "invalid linkage type for global declaration" (PR26569). Modified

Re: r260388 - [MS ABI] Never reference dllimport'd vtables

2016-02-10 Thread Hans Wennborg via cfe-commits
On Wed, Feb 10, 2016 at 9:40 AM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Wed Feb 10 11:40:47 2016 > New Revision: 260388 > > URL: http://llvm.org/viewvc/llvm-project?rev=260388&view=rev > Log: > [MS ABI] Never reference dllimport'd vtables > > Referencing a dllimported vta

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

2016-02-11 Thread Hans Wennborg via cfe-commits
On Tue, Sep 8, 2015 at 1:06 AM, John McCall via cfe-commits wrote: > Author: rjmccall > Date: Tue Sep 8 03:05:57 2015 > New Revision: 246985 > > URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev > Log: > Compute and preserve alignment more faithfully in IR-generation. Might be worth m

r260637 - UsersManual: update clang-cl commands

2016-02-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Feb 11 19:01:37 2016 New Revision: 260637 URL: http://llvm.org/viewvc/llvm-project?rev=260637&view=rev Log: UsersManual: update clang-cl commands Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm-project

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

2016-02-11 Thread Hans Wennborg via cfe-commits
I'm following the thread on r260235 to figure out what to merge in this series. On Thu, Feb 11, 2016 at 7:09 AM, Vasileios Kalintiris via cfe-commits wrote: > Hi Hans, > > Can we merge this on the release branch? It's a re-commit of D16613's patch > with the an additional option (-gcc-toolchain)

Re: r252474 - Create install targets for scan-build and scan-view

2016-02-11 Thread Hans Wennborg via cfe-commits
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits wrote: > Author: jroelofs > Date: Mon Nov 9 10:12:56 2015 > New Revision: 252474 > > URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev > Log: > Create install targets for scan-build and scan-view > > http://reviews.llvm.o

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

2016-02-12 Thread Hans Wennborg via cfe-commits
Marshall: ping? On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote: > Marshall: ping? > > On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: >> On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: >>> On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote: On 19 Jan 2016, at 01:50,

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

2016-02-12 Thread Hans Wennborg via cfe-commits
Marshall: ping? On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote: > I'm OK if Marshall is. > > Thanks, > Hans > > On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via > cfe-commits wrote: >> Hans, do you mind merging this to the 3.8 branch? >> >> Marshall, do you agree this is okay to

Re: [PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

2016-02-12 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D17218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: r260616 - Now that Sparc/Sparc64 backend is mostly usable, provide the same

2016-02-12 Thread Hans Wennborg via cfe-commits
On Thu, Feb 11, 2016 at 3:18 PM, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Thu Feb 11 17:18:36 2016 > New Revision: 260616 > > URL: http://llvm.org/viewvc/llvm-project?rev=260616&view=rev > Log: > Now that Sparc/Sparc64 backend is mostly usable, provide the same > linking d

[libcxx] r260982 - Merging r258107:

2016-02-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 16 11:16:15 2016 New Revision: 260982 URL: http://llvm.org/viewvc/llvm-project?rev=260982&view=rev Log: Merging r258107: r258107 | marshall | 2016-01-18 16:50:37 -0800 (Mon, 18 Jan 2016) | 1 line F

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

2016-02-16 Thread Hans Wennborg via cfe-commits
Marshall told me this one's approved. Merged in r260982. Thanks, Hans On Fri, Feb 12, 2016 at 10:22 AM, Hans Wennborg wrote: > Marshall: ping? > > On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote: >> Marshall: ping? >> >> On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: >>> On Tue, Jan

[libcxx] r260983 - Merging r259682:

2016-02-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 16 11:17:42 2016 New Revision: 260983 URL: http://llvm.org/viewvc/llvm-project?rev=260983&view=rev Log: Merging r259682: r259682 | dexonsmith | 2016-02-03 11:30:20 -0800 (Wed, 03 Feb 2016) | 7 lines

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

2016-02-16 Thread Hans Wennborg via cfe-commits
Marshall told me it's approved. Merged in r260983. Thanks, Hans On Fri, Feb 12, 2016 at 10:34 AM, Hans Wennborg wrote: > Marshall: ping? > > On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote: >> I'm OK if Marshall is. >> >> Thanks, >> Hans >> >> On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exo

Re: r260851 - As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,

2016-02-16 Thread Hans Wennborg via cfe-commits
On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote: > On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits > wrote: >> >> Author: dim >> Date: Sun Feb 14 10:08:20 2016 >> New Revision: 260851 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=260851&view=rev >> Log: >> As reported in http

Re: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

2016-02-16 Thread Hans Wennborg via cfe-commits
Do I understand correctly that there are still issues here's that are not fixed? (I'm trying to understand if there is something here to merge for 3.8, but I'm having trouble following these commits.) On Tue, Feb 16, 2016 at 6:44 AM, Vasileios Kalintiris wrote: > I changed the type of message fr

Re: r260370 - Fix PR26543: add a check for definition in CXXRecordDecl.

2016-02-16 Thread Hans Wennborg via cfe-commits
On Wed, Feb 10, 2016 at 2:50 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Wed Feb 10 04:50:12 2016 > New Revision: 260370 > > URL: http://llvm.org/viewvc/llvm-project?rev=260370&view=rev > Log: > Fix PR26543: add a check for definition in CXXRecordDecl. > > Modified: > cf

Re: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

2016-02-16 Thread Hans Wennborg via cfe-commits
Or is this comment on PR26059 all that needs to be done for 3.8? "Bug 26369, which has been fixed with r260961, requires the following commits to get merged on the release branch: - [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic." - [li

Re: r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-17 Thread Hans Wennborg via cfe-commits
On Tue, Feb 16, 2016 at 9:03 PM, Saleem Abdulrasool wrote: > On Thu, Feb 4, 2016 at 8:12 PM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Thu Feb 4 22:12:40 2016 >> New Revision: 259874 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=259874&view=rev >> Log: >> C

Re: r259874 - CodeGen: correct Windows ARM C++ assertion

2016-02-17 Thread Hans Wennborg via cfe-commits
On Wed, Feb 17, 2016 at 8:55 AM, Hans Wennborg wrote: > On Tue, Feb 16, 2016 at 9:03 PM, Saleem Abdulrasool > wrote: >> On Thu, Feb 4, 2016 at 8:12 PM, Saleem Abdulrasool via cfe-commits >> wrote: >>> >>> Author: compnerd >>> Date: Thu Feb 4 22:12:40 2016 >>> New Revision: 259874 >>> >>> URL: h

Re: r257763 - clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.

2016-02-18 Thread Hans Wennborg via cfe-commits
On Thu, Jan 14, 2016 at 5:36 AM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Thu Jan 14 07:36:46 2016 > New Revision: 257763 > > URL: http://llvm.org/viewvc/llvm-project?rev=257763&view=rev > Log: > clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0. > > Before:

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-19 Thread Hans Wennborg via cfe-commits
On Fri, Feb 19, 2016 at 4:00 AM, Ismail Donmez via cfe-commits wrote: > On Fri, Feb 19, 2016 at 3:52 AM, Nico Weber via cfe-commits > wrote: >> Author: nico >> Date: Thu Feb 18 19:52:46 2016 >> New Revision: 261297 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev >> Log: >> Impl

Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

2016-02-22 Thread Hans Wennborg via cfe-commits
On Sat, Feb 20, 2016 at 6:29 AM, Hal Finkel wrote: > > > - Original Message - >> From: "Dimitry Andric via cfe-commits" >> To: "Hans Wennborg" >> Cc: "Roman Divacky" , "cfe-commits" >> >> Sent: Saturday, February 20, 2016 8:24:36 AM >> Subject: Re: r261422 - Fix handling of vaargs on P

r261583 - Fix Visual Studio build after r261574

2016-02-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Feb 22 16:21:58 2016 New Revision: 261583 URL: http://llvm.org/viewvc/llvm-project?rev=261583&view=rev Log: Fix Visual Studio build after r261574 Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified:

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

2016-02-22 Thread Hans Wennborg via cfe-commits
On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add matcher hasAnyName as a

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Hans Wennborg via cfe-commits
Hi Aaron, I'll let it sit in the tree for a bit, and will then merge it later today. Many thanks, Hans On Tue, Feb 23, 2016 at 11:01 AM, Aaron Ballman wrote: > Hans, this should be safe to merge into 3.8 (as Richard had mentioned > in the review thread). Can you do the merge magic on my behalf?

r261670 - Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 13:10:16 2016 New Revision: 261670 URL: http://llvm.org/viewvc/llvm-project?rev=261670&view=rev Log: Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657 r261634 and r261633 seems to have caused PR26715. r261657 depends

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Hans Wennborg via cfe-commits
I'm sorry, but I had to revert this in order to revert r261634. r261657 On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Tue Feb 23 11:13:47 2016 > New Revision: 261657 > > URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev > Log: > Remove a

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Hans Wennborg via cfe-commits
On Tue, Feb 23, 2016 at 11:15 AM, Hans Wennborg wrote: > I'm sorry, but I had to revert this in order to revert r261634. r261657 Meant to say the revert is in r261670. > > On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits > wrote: >> Author: adrian >> Date: Tue Feb 23 11:13:47 2016

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Hans Wennborg via cfe-commits
On Tue, Feb 23, 2016 at 11:12 AM, Aaron Ballman wrote: > On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote: >> Hi Aaron, >> >> I'll let it sit in the tree for a bit, and will then merge it later today. > > Sounds great, thank you! r261684. >> Many thanks, >> Hans >> >> On Tue, Feb 23, 2016

[libcxxabi] r261691 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:04 2016 New Revision: 261691 URL: http://llvm.org/viewvc/llvm-project?rev=261691&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc3/ (props changed) - copied from r261690, libcxxabi/branches/re

<    8   9   10   11   12   13   14   15   16   17   >